diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2018-09-05 09:31:25 +0200 |
|---|---|---|
| committer | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2018-09-05 09:31:25 +0200 |
| commit | 22c6951d64e8b2c3a9e05306c52cd861c9c23ec7 (patch) | |
| tree | 0733830d55ff21e37213255cb53f268010b437a4 /lib | |
| parent | 306b6b5bf0e3dff50af8e37af4a28a36338a0dc6 (diff) | |
| download | gitlab-shell-22c6951d64e8b2c3a9e05306c52cd861c9c23ec7.tar.gz | |
Fix handling non 200 response codeszj-fix-non-200-resp-code
After the cleanup in https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/231
gitlab-shell mishandled the non 200 response codes. This commit removes
another few lines of codes, which fixes this. Also now we test against
this case through mocking.
Fixes https://gitlab.com/gitlab-org/gitlab-shell/issues/152
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab_access_status.rb | 2 | ||||
| -rw-r--r-- | lib/gitlab_net.rb | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/lib/gitlab_access_status.rb b/lib/gitlab_access_status.rb index 96dd6e8..00ea8de 100644 --- a/lib/gitlab_access_status.rb +++ b/lib/gitlab_access_status.rb @@ -1,7 +1,7 @@ require 'json' class GitAccessStatus - attr_reader :message, :gl_repository, :gl_id, :gl_username, :repository_path, :gitaly, :git_protocol, :git_config_options + attr_reader :message, :gl_repository, :gl_id, :gl_username, :gitaly, :git_protocol, :git_config_options def initialize(status, message, gl_repository:, gl_id:, gl_username:, gitaly:, git_protocol:, git_config_options:) @status = status diff --git a/lib/gitlab_net.rb b/lib/gitlab_net.rb index 28d1f0d..980897a 100644 --- a/lib/gitlab_net.rb +++ b/lib/gitlab_net.rb @@ -44,7 +44,6 @@ class GitlabNet # rubocop:disable Metrics/ClassLength gl_id: nil, gl_username: nil, git_config_options: nil, - repository_path: nil, gitaly: nil, git_protocol: nil) end |