Handle invalid number of arguments

When a remote user with a valid SSH key runs something like 'ssh
git@gitlab.example.com foobar', gitlab-shell would raise an exception in
the GitlabShell#escape_path method. With this change, we catch an
invalid number of arguments as soon as possible and exit.

1 files changed, 8 insertions, 0 deletions

diff --git a/spec/gitlab_shell_spec.rb b/spec/gitlab_shell_spec.rb
index f997477..4741303 100644
--- a/spec/gitlab_shell_spec.rb
+++ b/spec/gitlab_shell_spec.rb
@@ -48,6 +48,14 @@ describe GitlabShell do
       its(:repo_name) { should == 'dmitriy.zaporozhets/gitlab-ci.git' }
       its(:git_cmd) { should == 'git-upload-pack' }
     end
+
+    context 'with an invalid number of arguments' do
+      before { ssh_cmd 'foobar' }
+
+      it "should raise an DisallowedCommandError" do
+        expect { subject.send :parse_cmd }.to raise_error(GitlabShell::DisallowedCommandError)
+      end
+    end
   end
 
   describe :exec do