diff options
author | Alejandro RodrÃguez <alejorro70@gmail.com> | 2018-03-08 19:25:14 -0300 |
---|---|---|
committer | Alejandro RodrÃguez <alejorro70@gmail.com> | 2018-03-20 14:38:55 -0300 |
commit | 27bdba30336bf31242b8168ae710a52246c8f9eb (patch) | |
tree | 8136b7672ab3cecba1dd68c75ff90dced152c836 /spec | |
parent | 9b9ada1013bd91e316c2e85b7c0f0ef8cb02f688 (diff) | |
download | gitlab-shell-27bdba30336bf31242b8168ae710a52246c8f9eb.tar.gz |
Add Gitaly git-upload-archive migrated commandgitaly-upload-archive
Diffstat (limited to 'spec')
-rw-r--r-- | spec/gitlab_shell_spec.rb | 55 |
1 files changed, 55 insertions, 0 deletions
diff --git a/spec/gitlab_shell_spec.rb b/spec/gitlab_shell_spec.rb index 82db0cf..c3d4466 100644 --- a/spec/gitlab_shell_spec.rb +++ b/spec/gitlab_shell_spec.rb @@ -252,6 +252,61 @@ describe GitlabShell do end end + shared_examples_for 'upload-archive' do |command| + let(:ssh_cmd) { "#{command} gitlab-ci.git" } + let(:exec_cmd_params) { ['git-upload-archive', repo_path] } + let(:exec_cmd_log_params) { exec_cmd_params } + + after { subject.exec(ssh_cmd) } + + it "should process the command" do + subject.should_receive(:process_cmd).with(%W(git-upload-archive gitlab-ci.git)) + end + + it "should execute the command" do + subject.should_receive(:exec_cmd).with(*exec_cmd_params) + end + + it "should log the command execution" do + message = "executing git command" + user_string = "user with key #{key_id}" + $logger.should_receive(:info).with(message, command: exec_cmd_log_params.join(' '), user: user_string) + end + + it "should use usernames if configured to do so" do + GitlabConfig.any_instance.stub(audit_usernames: true) + $logger.should_receive(:info).with("executing git command", hash_including(user: 'John Doe')) + end + end + + context 'git-upload-archive' do + it_behaves_like 'upload-archive', 'git-upload-archive' + end + + context 'git upload-archive' do + it_behaves_like 'upload-archive', 'git upload-archive' + end + + context 'gitaly-upload-archive' do + before do + api.stub(check_access: gitaly_check_access) + end + + it_behaves_like 'upload-archive', 'git-upload-archive' do + let(:gitaly_executable) { "gitaly-upload-archive" } + let(:exec_cmd_params) do + [ + File.join(ROOT_PATH, "bin", gitaly_executable), + 'unix:gitaly.socket', + gitaly_message + ] + end + let(:exec_cmd_log_params) do + [gitaly_executable, 'unix:gitaly.socket', gitaly_message] + end + end + end + context 'arbitrary command' do let(:ssh_cmd) { 'arbitrary command' } after { subject.exec(ssh_cmd) } |