Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Clean up cmd_exec execution environmentzj-cleanup-exec | Zeger-Jan van de Weg | 2018-08-20 | 4 | -196/+41 |
| | | | | | | | | | | | Given the gitaly-* now proxy the data from the client to the Gitaly server, the environment variables aren't used. Therefor we don't have to set them either. Only exception to the rule, is the GITALY_TOKEN. These changes also remove the `GIT_TRACE` options, introduced by 192e2bd367494bf66746c8971896a2d9cb84fc92. Part of: https://gitlab.com/gitlab-org/gitaly/issues/1300 | ||||
* | Remove non Gitaly code paths | Zeger-Jan van de Weg | 2018-08-20 | 2 | -39/+23 |
| | | | | | | | All shell access goes through Gitaly, so dead code paths exist to support the legacy way too. This change mostly removes the dead code from `#process_cmd`. | ||||
* | Merge branch 'zj-remove-repo-path' into 'master' | Nick Thomas | 2018-08-17 | 4 | -43/+7 |
|\ | | | | | | | | | | | | | Remove repo_path from GitlabShell Closes #135 See merge request gitlab-org/gitlab-shell!231 | ||||
| * | Remove repo_path from GitlabShellzj-remove-repo-path | Zeger-Jan van de Weg | 2018-08-16 | 4 | -43/+7 |
|/ | | | | | | | | | | | | | | | The internal api returns '/' from gitlab, since `8fad07383ada021fc995294fd0fe0f77fe37da35` from GitLab CE. To clean up later, https://gitlab.com/gitlab-org/gitlab-shell/issues/135 was created. This change closes that issue, making it possible to remove the field from the response on GitLab-CE too. Given the Rails app always returns `/` as the repository_path, the associated checks are basically a noop too. The tests are updated and at times look a little fishy, but those are testing code that is to be removed in another MR. Closes https://gitlab.com/gitlab-org/gitlab-shell/issues/135 | ||||
* | Merge branch 'rs-rspec' into 'master' | Nick Thomas | 2018-08-16 | 19 | -319/+303 |
|\ | | | | | | | | | | | | | Update to RSpec 3 Closes #54 See merge request gitlab-org/gitlab-shell!229 | ||||
| * | Disable WEBrick logging in HTTPUNIXServer to reduce spec output noisers-rspec | Robert Speicher | 2018-08-15 | 1 | -0/+6 |
| | | |||||
| * | Fix a RuboCop warning | Robert Speicher | 2018-08-15 | 1 | -1/+1 |
| | | |||||
| * | Update webmock to 3.4.2 | Robert Speicher | 2018-08-15 | 4 | -7/+10 |
| | | |||||
| * | Reorganize spec_helper; add support files for VCR and HTTPUNIXServer | Robert Speicher | 2018-08-15 | 3 | -35/+40 |
| | | |||||
| * | Use `output` matcher in one test | Robert Speicher | 2018-08-15 | 1 | -4/+1 |
| | | |||||
| * | Require gitlab_init from spec_helper | Robert Speicher | 2018-08-15 | 1 | -0/+2 |
| | | | | | | | | This defines `ROOT_PATH`, which we later stub. | ||||
| * | Use secure RubyGems source | Robert Speicher | 2018-08-15 | 2 | -2/+2 |
| | | |||||
| * | Override `ROOT_PATH` in specs in a less insane way | Robert Speicher | 2018-08-15 | 2 | -3/+7 |
| | | |||||
| * | Remove usages of `its` in specs | Robert Speicher | 2018-08-15 | 3 | -16/+27 |
| | | |||||
| * | Update rspec to 3.8.0; remove rspec-its | Robert Speicher | 2018-08-15 | 3 | -17/+15 |
| | | |||||
| * | Autocorrect specs via `transpec -k its -v stub_with_hash` | Robert Speicher | 2018-08-15 | 10 | -195/+195 |
| | | |||||
| * | Remove guard and guard-rspec | Robert Speicher | 2018-08-15 | 3 | -42/+0 |
| | | |||||
| * | Update VCR to 4.0.0 | Robert Speicher | 2018-08-15 | 2 | -3/+3 |
|/ | |||||
* | Merge branch '148-merge-8-1-1-to-master' into 'master' | Robert Speicher | 2018-08-15 | 6 | -3/+176 |
|\ | | | | | | | | | | | | | Resolve "gitlab-shell 8.1.1 not on master" Closes #148 and #145 See merge request gitlab-org/gitlab-shell!230 | ||||
| * | Merge remote-tracking branch 'upstream/8-1-stable' into ↵ | Nick Thomas | 2018-08-14 | 6 | -3/+176 |
| |\ |/ / | | | | | 148-merge-8-1-1-to-master | ||||
| * | Release v8.1.1v8.1.18-1-stable | Nick Thomas | 2018-08-09 | 2 | -1/+4 |
| | | |||||
| * | Merge branch 'fix-ssh-certificate-regressions-8-1' into '8-1-stable' | Stan Hu | 2018-08-09 | 4 | -2/+172 |
| |\ | | | | | | | | | | | | | Fix two regressions in SSH certificate support (8.1) See merge request gitlab-org/gitlab-shell!226 | ||||
| | * | Guard discovery by username or key against bad API responses | Nick Thomas | 2018-08-09 | 1 | -1/+1 |
| | | | |||||
| | * | Harden gitlab-shell against arguments following the gl_id parameter in the ↵ | Nick Thomas | 2018-08-09 | 2 | -4/+4 |
| | | | | | | | | | | | | command line | ||||
| | * | Fix two regressions in SSH certificate support | Ævar Arnfjörð Bjarmason | 2018-08-08 | 4 | -2/+172 |
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix two regressions in my 2e8b670 ("Add support for SSH certificate authentication", 2018-06-14) merged in gitlab-org/gitlab-shell!207. This fixes the issue noted in gitlab-org/gitlab-shell#145 where the command-line contains things other than the key/user/username, and also a regression where SSH certificates are being used, and the username presented in the key is unknown to GitLab. In that case, we should log the user in as "Anonymous" (on an instance that allows public access), but because of how the error checking around api.discover() was implemented we ended up erroring out instead. | ||||
* | | Merge branch 'revert-refactor' into 'master' | Robert Speicher | 2018-08-14 | 66 | -2084/+1177 |
|\ \ | | | | | | | | | | | | | | | | | | | Revert refactor Closes #147 See merge request gitlab-org/gitlab-shell!228 | ||||
| * | | Restore "Pass custom git_config_options to Gitalyo" | Nick Thomas | 2018-08-14 | 12 | -275/+473 |
| | | | | | | | | | | | | This reverts commit 764f6f47fa6a8698ae033532ae49875a87030518. | ||||
| * | | Revert "Merge branch 'ash.mckenzie/srp-refactor' into 'master'" | Nick Thomas | 2018-08-14 | 66 | -2077/+1164 |
| | | | | | | | | | | | | | | | This reverts commit 3aaf4751e09262c53544a1987f59b1308af9b6c1, reversing changes made to c6577e0d75f51b017f2f332838b97c3ca5b497c0. | ||||
| * | | Revert "Pass custom git_config_options to Gitalyo" | Nick Thomas | 2018-08-14 | 11 | -468/+276 |
|/ / | | | | | | | This reverts commit f4ce4a3c31a9a7fb2fa0bb7daa185d34b8c03c00. | ||||
* | | Merge branch 'sh-add-require-create-hooks' into 'master' | Rémy Coutable | 2018-08-09 | 1 | -0/+1 |
|\ \ | | | | | | | | | | | | | | | | | | | Add missing require statement in create-hooks Closes gitlab-ce#50160 See merge request gitlab-org/gitlab-shell!225 | ||||
| * | | Add missing require statement in create-hooks | Stan Hu | 2018-08-09 | 1 | -0/+1 |
|/ / | | | | | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/50160 | ||||
* | | Merge branch 'rd-support-git-config-options' into 'master' | Robert Speicher | 2018-08-08 | 11 | -276/+468 |
|\ \ | | | | | | | | | | | | | Pass custom git_config_options to Gitaly See merge request gitlab-org/gitlab-shell!221 | ||||
| * | | Pass custom git_config_options to Gitalyo | Rubén Dávila | 2018-08-07 | 11 | -276/+468 |
| | | | | | | | | | | | | | | | The /api/internal/allowed endpoint on GitLab has been updated to return some custom git options that can be used with git commands, we need to pass these received options to Gitaly. | ||||
* | | | Merge branch 'ash.mckenzie/srp-refactor' into 'master' | Robert Speicher | 2018-08-08 | 66 | -1164/+2077 |
|\ \ \ | |_|/ |/| | | | | | | | | Refactor that focuses on SRP improvements See merge request gitlab-org/gitlab-shell!214 | ||||
| * | | Typo fix | Ash McKenzie | 2018-08-08 | 1 | -1/+1 |
| |/ | |||||
| * | Actor::Base audit_usernames? now an alias | Ash McKenzie | 2018-08-03 | 1 | -4/+2 |
| | | |||||
| * | Merge remote-tracking branch 'origin/master' into ash.mckenzie/srp-refactor | Ash McKenzie | 2018-08-02 | 10 | -13/+34 |
| |\ | |/ |/| | |||||
* | | Merge branch 'release-gitlab-8-1' into 'master'v8.1.0 | Nick Thomas | 2018-08-01 | 2 | -2/+4 |
|\ \ | | | | | | | | | | | | | Release v8.1.0 See merge request gitlab-org/gitlab-shell!219 | ||||
| * | | Release v8.1.0 | Nick Thomas | 2018-08-01 | 2 | -2/+4 |
|/ / | |||||
* | | Merge branch 'add-protocol-v2-logic' into 'master' | Nick Thomas | 2018-08-01 | 6 | -39/+61 |
|\ \ | | | | | | | | | | | | | Add Git protocol v2 See merge request gitlab-org/gitlab-shell!217 | ||||
| * | | use GIT_PROTOCOL env variable in gitlab_shell#exec | James Lopez | 2018-08-01 | 2 | -2/+6 |
| | | | |||||
| * | | update gitlab shell to remove git_protocol env var | James Lopez | 2018-08-01 | 2 | -2/+0 |
| | | | |||||
| * | | Add Git protocol v2 | James Lopez | 2018-08-01 | 6 | -40/+60 |
|/ / | |||||
| * | Added TODO to fixup whatever naming | Ash McKenzie | 2018-08-01 | 1 | -0/+2 |
| | | |||||
| * | Fixed comments in bin/gitlab-shell-authorized* | Ash McKenzie | 2018-08-01 | 2 | -4/+4 |
| | | |||||
| * | GitlatNet#discover only parse JSON if a 200 | Ash McKenzie | 2018-08-01 | 3 | -2/+54 |
| | | |||||
| * | Update Actor::Username, add specs | Ash McKenzie | 2018-08-01 | 4 | -5/+96 |
| | | |||||
| * | Actor::Base#label now describes the class nicely | Ash McKenzie | 2018-08-01 | 1 | -1/+5 |
| | | |||||
| * | Merge remote-tracking branch 'origin/master' into ash.mckenzie/srp-refactor | Ash McKenzie | 2018-08-01 | 19 | -103/+211 |
| |\ | |/ |/| | |||||
* | | Merge branch 'release-version-8' into 'master'v8.0.0 | Nick Thomas | 2018-07-31 | 2 | -1/+4 |
|\ \ | | | | | | | | | | | | | Release GitLab Shell v8.0.0 See merge request gitlab-org/gitlab-shell!218 |