summaryrefslogtreecommitdiff
path: root/internal/command/uploadpack
Commit message (Collapse)AuthorAgeFilesLines
* Generate and log correlation IDsStan Hu2020-07-311-3/+1
| | | | | This will make it easier to tie an SSH access request to Rails API and Gitaly requests.
* Log SSH key detailsStan Hu2020-07-231-0/+2
| | | | | | | | | | | | | | | | | | | | | Right now when a client such as gitlab-shell calls the `/api/v4/internal/allowed` API, the response only tells the client what user has been granted access, and it's impossible to tell which deploy key/token was used in the authentication request. This commit adds logs for the following when available: 1. `gl_key_type` (e.g. `deploy_key` or `key`) 2. `gl_key_id` These fields make it possible for admins to identify the exact record that was used to authenticate the user. API changes in the `/internal/allowed` endpoint in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/37289 are needed to support this. Relates to https://gitlab.com/gitlab-org/gitlab-shell/-/issues/203
* Fix race conditions in testssh-add-http-status-codeStan Hu2020-05-081-6/+4
| | | | | | | | Calling logrus hook.LastEntry() can lead to race conditions. Use AllEntries instead: https://github.com/sirupsen/logrus/blob/60c74ad9be0d874af0ab0daef6ab07c5c5911f0d/hooks/test/test.go#L77 Closes https://gitlab.com/gitlab-org/gitlab-shell/-/issues/450
* Move gitlabnet client to client packagejc-refactor-gitlabnet-clientJohn Cai2020-05-042-2/+2
|
* Geo Pull custom action supportAsh McKenzie2020-04-171-0/+10
|
* Remove unnecessary command argumentDavid Kim2020-04-081-1/+1
|
* Move logging to handler insteadDavid Kim2020-04-071-3/+2
|
* Add test for command loggingDavid Kim2020-04-032-13/+5
|
* Add tests for loggingDavid Kim2020-03-301-0/+8
|
* Add git-archive-packStan Hu2020-03-261-6/+6
|
* Log git-{upload-pack,receive-pack} requestsStan Hu2020-03-261-0/+12
| | | | This restores the previous Ruby gitlab-shell behavior.
* commands: pass through GIT_PROTOCOL envvar provided by clientsps-git-protocol-envvarPatrick Steinhardt2020-02-281-1/+2
| | | | | | | | | | | Both git-upload-pack and git-receive-pack services inspect the GIT_PROTOCOL environment transferred via SSH in order to decide which protocols are supported by a given client. Currently, we don't use the environment variable at all, though, but instead forward the GitProtocol field of the access verification response. Improve this by passing on the GIT_PROTOCOL environment variable provided by the client as-is.
* Merge branch 'pass-ff-to-gitaly' into 'master'Ash McKenzie2019-10-292-1/+13
| | | | | Add support for Gitaly feature flags See merge request gitlab-org/gitlab-shell!351
* Rename import pathsNick Thomas2019-10-184-18/+18
|
* Move go code up one levelNick Thomas2019-10-184-0/+143
View Lorry Controller Status