diff options
author | Philip Chimento <philip.chimento@gmail.com> | 2018-11-03 15:41:33 -0400 |
---|---|---|
committer | Philip Chimento <philip.chimento@gmail.com> | 2018-11-05 23:18:30 -0500 |
commit | 5d5f82dfa7c0a4683d8363a19e5e97898f2706a7 (patch) | |
tree | bab7f18ed7d54dac66fa77d19a536ec03a1f35bd /gjs/coverage.cpp | |
parent | 8e707747d676dda92051f98115b17b0afe0aeeb9 (diff) | |
download | gjs-5d5f82dfa7c0a4683d8363a19e5e97898f2706a7.tar.gz |
atoms: Use more atoms to avoid converting strings
There are a number of places where we used JS_{Get,Set,Define}Property()
or JS_DefineFunction() with a string literal. In these cases it would be
better to use an atom so that the string doesn't have to be converted from
UTF-8 internally each time.
In some cases there was already an atom defined, and in others we add a
new atom.
Diffstat (limited to 'gjs/coverage.cpp')
-rw-r--r-- | gjs/coverage.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/gjs/coverage.cpp b/gjs/coverage.cpp index b636b864..2e3055db 100644 --- a/gjs/coverage.cpp +++ b/gjs/coverage.cpp @@ -29,6 +29,7 @@ #include <gjs/context.h> #include "coverage.h" +#include "gjs/context-private.h" #include "global.h" #include "importer.h" #include "jsapi-util-args.h" @@ -348,9 +349,10 @@ bootstrap_coverage(GjsCoverage *coverage) if (!JS_WrapObject(context, &debuggeeWrapper)) return false; + const GjsAtoms& atoms = GjsContextPrivate::atoms(context); JS::RootedValue debuggeeWrapperValue(context, JS::ObjectValue(*debuggeeWrapper)); - if (!JS_SetProperty(context, debugger_compartment, "debuggee", - debuggeeWrapperValue) || + if (!JS_SetPropertyById(context, debugger_compartment, atoms.debuggee(), + debuggeeWrapperValue) || !gjs_define_global_properties(context, debugger_compartment, "coverage")) return false; |