summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Shea <dshea@redhat.com>2014-07-23 17:34:02 -0400
committerJuan Pablo Ugarte <juanpablougarte@gmail.com>2014-07-23 20:33:04 -0300
commitd00ece8aa71332930e4a2d0d490d175567dbde36 (patch)
tree408f50072ccab30f976b9e0e7b784d48b327b3e9
parent5a68585de92a4956f3b56731138ea341b9b049c2 (diff)
downloadglade-d00ece8aa71332930e4a2d0d490d175567dbde36.tar.gz
Avoid reading freed data in glade_project_read_requires
Ensure that required_lib is NULL at the start of each iteration through the loop.
-rw-r--r--gladeui/glade-project.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/gladeui/glade-project.c b/gladeui/glade-project.c
index eecdb86e..e91b0cb7 100644
--- a/gladeui/glade-project.c
+++ b/gladeui/glade-project.c
@@ -1435,7 +1435,6 @@ glade_project_read_requires (GladeProject *project,
GString *string = g_string_new (NULL);
GladeXmlNode *node;
- gchar *required_lib = NULL;
gboolean loadable = TRUE;
guint16 major, minor;
gint position = 0;
@@ -1443,6 +1442,8 @@ glade_project_read_requires (GladeProject *project,
for (node = glade_xml_node_get_children_with_comments (root_node);
node; node = glade_xml_node_next_with_comments (node))
{
+ gchar *required_lib = NULL;
+
/* Skip non "requires" tags */
if (!(glade_xml_node_verify_silent (node, GLADE_XML_TAG_REQUIRES) ||
(required_lib =