summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilip Withnall <philip@tecnocode.co.uk>2022-10-19 09:52:29 +0000
committerPhilip Withnall <philip@tecnocode.co.uk>2022-10-19 09:52:29 +0000
commit7cc95e0211a84fed0baecf639d8a864cc8eda3df (patch)
treeca517f245f2d64bcb34c3af8972cbb28ad3da456
parent0839556904b70edd9b62f4edd7a517b758cc7bc5 (diff)
parent5190354ad95c5a10fdde037de8177797ae4a7384 (diff)
downloadglib-7cc95e0211a84fed0baecf639d8a864cc8eda3df.tar.gz
Merge branch 'wip/pwithnall/2785-macos-fd-close-test-failure' into 'main'
gstdio: Temporarily disable g_close() warning on macOS See merge request GNOME/glib!2977
-rw-r--r--glib/gstdio.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/glib/gstdio.c b/glib/gstdio.c
index ed46bdf2d..22d1159ce 100644
--- a/glib/gstdio.c
+++ b/glib/gstdio.c
@@ -1802,7 +1802,13 @@ g_close (gint fd,
* not necessarily in the caller of g_close(), but somebody else
* might have wrongly closed fd. In any case, there is a serious bug
* somewhere. */
+ /* FIXME: This causes a number of unit test failures on macOS.
+ * Disabling the message for now until someone with access to a
+ * macOS machine can investigate.
+ * See https://gitlab.gnome.org/GNOME/glib/-/issues/2785 */
+#ifndef HAVE_COCOA
g_critical ("g_close(fd:%d) failed with EBADF. The tracking of file descriptors got messed up", fd);
+#endif
}
else
{