summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon McVittie <smcv@collabora.com>2021-08-05 12:46:13 +0100
committerSimon McVittie <smcv@collabora.com>2021-08-05 14:59:35 +0100
commit2c95eb6e876bf9c7852b298a71989a9bcfc47605 (patch)
treee380d9594ca1dd07e8ce6847a6d1ae0410c68688
parentbe4b8cbe96ecd8d7d738fb9c80729285123ecdf3 (diff)
downloadglib-2c95eb6e876bf9c7852b298a71989a9bcfc47605.tar.gz
tests: GThreadPool free-function is not reliably called on FreeBSD yetwip/freebsd-thread-pool-free
This new feature in 2.69.0 does not appear to be reliable on the FreeBSD CI runners. Disable this part of the test while it's investigated, so that we can use CI as an acceptance gate for unrelated branches again. Leave it enabled when run with `-m thorough` so that FreeBSD developers can debug the intermittent failure. Mitigates: https://gitlab.gnome.org/GNOME/glib/-/issues/2456 Signed-off-by: Simon McVittie <smcv@collabora.com>
-rw-r--r--glib/tests/thread-pool.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/glib/tests/thread-pool.c b/glib/tests/thread-pool.c
index 50a72a632..b497b9a00 100644
--- a/glib/tests/thread-pool.c
+++ b/glib/tests/thread-pool.c
@@ -194,6 +194,16 @@ test_thread_pool_full (gconstpointer shared_first)
g_assert_true (success);
g_thread_pool_free (pool, TRUE, TRUE);
+
+#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
+ if (!free_func_called && !g_test_thorough ())
+ {
+ g_test_incomplete ("GThreadPool free-function not called - "
+ "https://gitlab.gnome.org/GNOME/glib/-/issues/2456");
+ return;
+ }
+#endif
+
g_assert_true (free_func_called);
}