diff options
| author | Milan Crha <mcrha@redhat.com> | 2016-05-27 07:30:00 +0000 |
|---|---|---|
| committer | Matthias Clasen <mclasen@redhat.com> | 2016-07-16 21:15:30 -0400 |
| commit | 4215c0ce9158288619308c5fa6d2aa57ed4506b7 (patch) | |
| tree | fe9fa0eb1f92ea6302886f009ac16c05b37af42b | |
| parent | e3e3ed0d7d897de0f5107593deed353c5d15caf8 (diff) | |
| download | glib-4215c0ce9158288619308c5fa6d2aa57ed4506b7.tar.gz | |
Fix memory leaks in GNetworkMonitorNetlink
As claimed by valgrind in a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1317369
https://bugzilla.gnome.org/show_bug.cgi?id=766933
| -rw-r--r-- | gio/gnetworkmonitornetlink.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/gio/gnetworkmonitornetlink.c b/gio/gnetworkmonitornetlink.c index b9ff01101..776628bbe 100644 --- a/gio/gnetworkmonitornetlink.c +++ b/gio/gnetworkmonitornetlink.c @@ -295,7 +295,7 @@ read_netlink_messages (GSocket *socket, gssize len; gint flags; GError *error = NULL; - GSocketAddress *addr; + GSocketAddress *addr = NULL; struct nlmsghdr *msg; struct rtmsg *rtmsg; struct rtattr *attr; @@ -326,6 +326,7 @@ read_netlink_messages (GSocket *socket, if (len < 0) { g_warning ("Error on netlink socket: %s", error->message); + g_clear_object (&addr); g_error_free (error); if (nl->priv->dump_networks) finish_dump (nl); @@ -335,6 +336,7 @@ read_netlink_messages (GSocket *socket, if (!g_socket_address_to_native (addr, &source_sockaddr, sizeof (source_sockaddr), &error)) { g_warning ("Error on netlink socket: %s", error->message); + g_clear_object (&addr); g_error_free (error); if (nl->priv->dump_networks) finish_dump (nl); @@ -425,6 +427,7 @@ read_netlink_messages (GSocket *socket, done: g_free (iv.buffer); + g_clear_object (&addr); if (!retval && nl->priv->dump_networks) finish_dump (nl); |