summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorClaudio Saavedra <csaavedra@igalia.com>2012-01-04 00:18:59 +0200
committerClaudio Saavedra <csaavedra@igalia.com>2012-01-04 18:14:00 +0200
commit8b96fb3761bb094d7c0044114f377934b9b00c51 (patch)
tree2d10a684b7354381636bd662c353eb9fbfe228dd
parentf38a1dbca7d68eedc2d75cd7a7947c7217bbbd99 (diff)
downloadglib-8b96fb3761bb094d7c0044114f377934b9b00c51.tar.gz
GSocket: fix a couple of return values
g_socket_receive_with_blocking() and g_socket_send_with_blocking claim to return -1 in error, their return type is gssize, and yet they return FALSE if the initial g_return_val_if_fail() call fails. https://bugzilla.gnome.org/show_bug.cgi?id=667226
-rw-r--r--gio/gsocket.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gio/gsocket.c b/gio/gsocket.c
index 6bf12135d..167928001 100644
--- a/gio/gsocket.c
+++ b/gio/gsocket.c
@@ -1837,7 +1837,7 @@ g_socket_receive_with_blocking (GSocket *socket,
{
gssize ret;
- g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, FALSE);
+ g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, -1);
if (!check_socket (socket, error))
return -1;
@@ -2009,7 +2009,7 @@ g_socket_send_with_blocking (GSocket *socket,
{
gssize ret;
- g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, FALSE);
+ g_return_val_if_fail (G_IS_SOCKET (socket) && buffer != NULL, -1);
if (!check_socket (socket, error))
return -1;