diff options
author | Murray Cumming <murrayc@murrayc.com> | 2011-04-04 10:49:43 +0200 |
---|---|---|
committer | Murray Cumming <murrayc@murrayc.com> | 2011-04-04 10:49:43 +0200 |
commit | b71ee3c790c22202f363eecae2d9db2e5f7c8681 (patch) | |
tree | e31ee8e8c80a29972a1ddbc736d57f47548898b4 | |
parent | 7ee784767b9311b3dfebad040fc895350cf5d6f6 (diff) | |
download | glibmm-b71ee3c790c22202f363eecae2d9db2e5f7c8681.tar.gz |
ThemedIcon: Remove a property as suggested by a TODO.
* gio/src/themedicon.hg: The name property is write-only and construct-only
so we should not have any API for it.
Noticed by Kjell Ahlstedt.
-rw-r--r-- | ChangeLog | 9 | ||||
-rw-r--r-- | gio/src/themedicon.hg | 11 |
2 files changed, 14 insertions, 6 deletions
@@ -1,5 +1,13 @@ 2011-04-04 Murray Cumming <murrayc@murrayc.com> + ThemedIcon: Remove a property as suggested by a TODO. + + * gio/src/themedicon.hg: The name property is write-only and construct-only + so we should not have any API for it. + Noticed by Kjell Ahlstedt. + +2011-04-04 Murray Cumming <murrayc@murrayc.com> + Gio::Settings: Really add list_schemas(). * gio/src/gio_others.defs: Add g_settings_list_schemas(), though we do not @@ -7,6 +15,7 @@ because h2defs.py gets confused by the return type. * gio/src/settings.[hg|ccg]: list_schemas(): Make this static and hand-code it because gmmproc is confused by the declaration when it is static. + Noticed by Kjell Ahlstedt. 2011-04-02 Murray Cumming <murrayc@murrayc.com> diff --git a/gio/src/themedicon.hg b/gio/src/themedicon.hg index 42435582..4f54259e 100644 --- a/gio/src/themedicon.hg +++ b/gio/src/themedicon.hg @@ -47,19 +47,19 @@ class ThemedIcon _IMPLEMENTS_INTERFACE(Icon) protected: - /** Creates a new themed icon for @ iconname, and optionally all the names that can be created by shortening @a iconname at '-' characters. + /** Creates a new themed icon for @ iconname, and optionally all the names that can be created by shortening @a iconname at '-' characters. * * @param iconname A string containing an icon name. - * use_default_callbacks Whether to use all the names that can be created by shortening @a iconname at '-' characters. + * use_default_callbacks Whether to use all the names that can be created by shortening @a iconname at '-' characters. */ explicit ThemedIcon(const std::string& iconname, bool use_default_callbacks = false); _IGNORE(g_themed_icon_new, g_themed_icon_new_with_default_fallbacks) public: - /** Creates a new themed icon for @ iconname, and optionally all the names that can be created by shortening @a iconname at '-' characters. + /** Creates a new themed icon for @ iconname, and optionally all the names that can be created by shortening @a iconname at '-' characters. * * @param iconname A string containing an icon name. - * use_default_callbacks Whether to use all the names that can be created by shortening @a iconname at '-' characters. + * use_default_callbacks Whether to use all the names that can be created by shortening @a iconname at '-' characters. */ _WRAP_CREATE(const std::string& iconname, bool use_default_callbacks = false) @@ -78,8 +78,7 @@ public: //There are no signals. - //TODO: Remove these when we can break ABI. They are write-only and construct-only. - _WRAP_PROPERTY("name", std::string) + //The "name" property is write-only and construct-only so it should not be wrapped. //An array: This is awkward to wrap_WRAP_PROPERTY("names", ) _WRAP_PROPERTY("use-default-fallbacks", bool) }; |