diff options
author | Murray Cumming <murrayc@murrayc.com> | 2014-04-03 11:00:07 +0200 |
---|---|---|
committer | Murray Cumming <murrayc@murrayc.com> | 2014-04-03 11:00:07 +0200 |
commit | 415335bfd0a2393dd2650b483dbae4bb605c56e2 (patch) | |
tree | 44459556c84de4f46e020165b8d189ad91dae452 | |
parent | ca67c931dd24a27bb5bb9de56abb6cf6fcb28018 (diff) | |
download | glibmm-415335bfd0a2393dd2650b483dbae4bb605c56e2.tar.gz |
Add a TODO comment
-rw-r--r-- | gio/src/actiongroup.hg | 2 | ||||
-rw-r--r-- | glib/src/variant.ccg | 2 | ||||
-rw-r--r-- | glib/src/variant.hg | 1 |
3 files changed, 4 insertions, 1 deletions
diff --git a/gio/src/actiongroup.hg b/gio/src/actiongroup.hg index 434b7fad..54411cf6 100644 --- a/gio/src/actiongroup.hg +++ b/gio/src/actiongroup.hg @@ -173,6 +173,8 @@ void ActionGroup::get_action_state(const Glib::ustring& action_name, T_Value& va g_variant_type_equal(g_action_group_get_action_state_type(const_cast<GActionGroup*>(gobj()), action_name.c_str()), type_glib_variant::variant_type().gobj())); const Glib::VariantBase variantBase = get_action_state_variant(action_name); + + //TODO: Add a bool return instead of letting a std::bad_cast from the cast_dynamic() be thrown up to the caller? const type_glib_variant variantDerived = variantBase.cast_dynamic<type_glib_variant>(variantBase); value = variantDerived.get(); } diff --git a/glib/src/variant.ccg b/glib/src/variant.ccg index bfdff9fd..1689e6bd 100644 --- a/glib/src/variant.ccg +++ b/glib/src/variant.ccg @@ -58,7 +58,7 @@ void VariantBase::get_normal_form(VariantBase& result) const GVariant* const g_value = g_variant_get_normal_form(const_cast<GVariant*>(gobj())); - //The C function never returns NULL, according to its docuemenation, + //The C function never returns NULL, according to its documenation, //so we don't need a bool return value. result.init(g_value); // g_value is already referenced. } diff --git a/glib/src/variant.hg b/glib/src/variant.hg index 9c9e6860..0cb1a827 100644 --- a/glib/src/variant.hg +++ b/glib/src/variant.hg @@ -456,6 +456,7 @@ public: //TODO: Documentation void get(VariantBase& variant) const; + //TODO: Deprecate this in favour of get(VariantBase&)? _WRAP_METHOD(VariantBase get() const, g_variant_get_variant) }; |