summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJonas Dreßler <verdre@v0yd.nl>2019-12-12 12:09:14 +0100
committerBenjamin Berg <benjamin@sipsolutions.net>2019-12-12 11:51:53 +0000
commitcd4418653f317fcd2d6a6d69f14fdc2e005e092c (patch)
treec1303f4bfccb8875356cb8bf3a3b297e28ce52a1
parentd0cc7cc5543120eb86f66f44fd65d0f04477f1f5 (diff)
downloadgnome-settings-daemon-cd4418653f317fcd2d6a6d69f14fdc2e005e092c.tar.gz
backlight: Fix return value of async brightness changes
With cd051e6c7ccfb7e7b0ec440409c559b2e51284e8 we added another method for setting the display brightness, it was forgotten there to convert the actual brightness value to a percentage when setting the GTask return value. Since this return value is used to display the brightness OSD in gsd-media-keys-manager, we ended up with values above 100% shown in the brightness OSD. Fix that by adjusting the return value to be a percentage.
-rw-r--r--plugins/power/gsd-backlight.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/plugins/power/gsd-backlight.c b/plugins/power/gsd-backlight.c
index f4d60306..9f406c99 100644
--- a/plugins/power/gsd-backlight.c
+++ b/plugins/power/gsd-backlight.c
@@ -469,6 +469,7 @@ gsd_backlight_set_brightness_val_async (GsdBacklight *backlight,
GError *error = NULL;
GTask *task = NULL;
GnomeRROutput *output;
+ gint percent;
value = MIN(backlight->brightness_max, value);
value = MAX(backlight->brightness_min, value);
@@ -491,7 +492,11 @@ gsd_backlight_set_brightness_val_async (GsdBacklight *backlight,
G_DBUS_CALL_FLAGS_NONE,
-1, NULL,
NULL, NULL);
- g_task_return_int (task, backlight->brightness_target);
+
+ percent = ABS_TO_PERCENTAGE (backlight->brightness_min,
+ backlight->brightness_max,
+ backlight->brightness_target);
+ g_task_return_int (task, percent);
} else {
task_data = g_new0 (BacklightHelperData, 1);
task_data->value = backlight->brightness_target;