| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Currently, when disabling the night light plugin till tomorrow,
"tomorrow" is defined as "after midnight", which is counter-intuitive.
Instead, define it as "after sunrise" so it is applied on the next
night, whenever that happens.
Closes https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/3
|
|
|
|
|
| |
- turns libcommon to a static uninstalled library
- inject RPATH for libgsd in every installed plugin/executable
|
|
|
|
| |
This reverts commit 3f0a53324971eef7d33509537a3633ad908ad1f4.
|
|
|
|
|
|
|
| |
compiler_flags needs to be defined both when doing debug builds (as it
was) and non-debug builds to avoid an error.
Spotted by Kalev Lember <klember@redhat.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
meson uses gdbus-codegen for D-Bus code generation. However, both
files are generated implicitly, so meson is not able to know how
many files are generated, so it does generate only one opaque
target that represents the two files.
A new script has been created only to call gdbus-codegen and
simulate the generation of the source code and header as different
targets.
Please see:
https://bugzilla.gnome.org/show_bug.cgi?id=791015
https://github.com/mesonbuild/meson/pull/2930
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Every plugin generate an autostart desktop file, except `common`
and `dummy` that are special cases.
This desktop file generation is duplicated among the different
plugin's build files.
This code has been moved to the build file in the `plugins`
directory, avoiding any code duplication.
The downside of this is that meson is not able to generate files
in a different directory, so all the files will be generated in
the `plugin` directory, outside of the each plugin's directory.
This is something that it's worked on in a different feature and
it might be merged in the future.
See https://github.com/mesonbuild/meson/pull/2617
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
|
|
| |
Recent changes in libgnome-volume-control include some fixes and
a number of build improvements. However, none of them make a major
change that could affect gnome-settings-daemon, so these are nice
to have improvements.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
| |
To avoid the burden of maintaining multiple build systems, this
patch removes autotools support.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recent versions of Gettext are able to translate several formats
that are used in GNOME applications. This patch migrates from
Intltool to Gettext by using meson's i18n features.
Explicit encoding has also been added to the gschema files due to
an issue in gettext[0] with default encoding in XML files.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
[0] https://savannah.gnu.org/bugs/?52932
|
|
|
|
|
|
|
|
|
|
| |
The data contents for the enum related files are stored in the
build files.
This patch moves this information to template files to be used
along with glib-mkenums.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
|
| |
meson is a build system focused on speed an ease of use, which
helps speeding up the software development. This patch adds meson
support along autotools.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
|
|
|
| |
If mutter is built with Wayland support, it will fail to start up under
our mocked logind because it cannot get information about the session:
mutter-WARNING **: Can't initialize KMS backend: Could not get session ID: No such file or directory
See https://gitlab.gnome.org/GNOME/mutter/merge_requests/15
https://bugzilla.gnome.org/show_bug.cgi?id=793189
|
|
|
|
|
|
|
| |
Works-around a possible error on teardown in some circumstances:
rm: cannot remove '/tmp/gsd-power-testeSVBTD/runtime/gvfs': Transport endpoint is not connected
See https://bugzilla.gnome.org/show_bug.cgi?id=793187
|
| |
|
|
|
|
|
|
|
| |
There aren't any user-visible strings to translate, so let's remove
this.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When there is an MPRIS client, prefer it to clients using the
gnome-settings-daemon interface. MPRIS clients are always media clients,
and it's likely that the user wants the media keys to control music or
movie playback, rather than presentations.
This will make mixing and matching the 2 different types of clients
(for example, Spotify and Rhythmbox) always control the MPRIS client,
but it's more than likely what the users want.
See https://bugzilla.gnome.org/show_bug.cgi?id=789738
https://bugzilla.gnome.org/show_bug.cgi?id=792875
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=792875
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=792875
|
|
|
|
|
|
| |
Set a more restrictive mode than the default to avoid a warning at
runtime:
dbus[28036]: Unable to set up transient service directory: XDG_RUNTIME_DIR "/tmp/gsd-power-testF7oXJo/runtime" can be written by others (mode 040775)
|
| |
|
|
|
|
|
|
|
|
|
| |
The `gsd-power-constants-update.pl` has the files it uses hardcoded.
This patch modifies those hardcoded files so they can be specified
from the command line.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
|
| |
In order to share the gvc modules between autotools and meson, this
patch moves its directory to subprojects directory and updates
autotools.
https://bugzilla.gnome.org/show_bug.cgi?id=793087
|
|
|
|
|
|
|
| |
Do not use g_list_length when the number of elements can be easily
counted in the previous for-cycle.
https://bugzilla.gnome.org/show_bug.cgi?id=792235
|
|
|
|
|
|
| |
This feature is handled by mutter/clutter backends.
https://bugzilla.gnome.org/show_bug.cgi?id=790121
|
|
|
|
|
|
|
|
|
| |
The test was trying to verify that no suspend action happened. However,
this cannot happen during testing, as the suspend action for lid close
is not done by gsd-power. So instead just verify that the lid switch
inhibition works as expected.
https://bugzilla.gnome.org/show_bug.cgi?id=708280
|
|
|
|
|
|
|
| |
Udev is rather common, so this check doesn't suffice if anyone wants
to build with no wayland support whatsoever.
https://bugzilla.gnome.org/show_bug.cgi?id=780544
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to the EU Commission Regulation No 801/2013, amending
Regulation (EC) No 1275/2008:
"
The default period of time after which the power management function,
or a similar function, switches the equipment automatically into a
condition providing networked standby shall not exceed 20 minutes.
"
(Full text at:
http://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:32013R0801&from=EN )
Though this addition only seems to be applicable to "networked
equipment", the original directive and its 2008 "ecodesign" regulation
mentions that computers are covered (as "Information technology equipment intended
primarily for use in the domestic environment"), and that:
"
When equipment is not providing the main function, or when other energy-using
product(s) are not dependent on its functions, equipment shall, unless
inappropriate for the intended use, offer a power management function, or a
similar function, that switches equipment after the shortest possible period
of time appropriate for the intended use of the equipment, automatically into
[standby mode].
"
(Full text at:
http://eur-lex.europa.eu/legal-content/EN/TXT/HTML/?uri=CELEX:32008R1275&from=EN)
Furthermore, the EnergyStar standard that allows shipping into the USA
mentions that, for most computers types:
"
Sleep Mode shall be set to activate after no more than 30 minutes of
user inactivity.
"
(Full text at:
http://docketpublic.energy.ca.gov/PublicDocuments/16-AAER-02/TN213577_20160909T143121_ENERGY_STAR_Product_Specification_for_Computers_Eligibility_Cri.pdf)
https://bugzilla.gnome.org/show_bug.cgi?id=681869
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=792209
|
|
|
|
|
|
|
|
| |
When a new idle inhibitor is added then the state needs to be forced to
normal mode even when the user is idle. However, this should not happen
if the screensaver is active at the time.
https://bugzilla.gnome.org/show_bug.cgi?id=792209
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During testing debug output is enabled using --verbose.
Unfortunately the default logging handler in GLib is not flushing the
utput stream for each log message. In addition, the default buffering
for stdout seems to be block based (not line based) if stdout is not a
TTY.
This causes the log message to get stuck in the buffer and the tests
cannot read them.
See also https://bugzilla.gnome.org/show_bug.cgi?id=792432
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
| |
Use the helper introduced earlier instead of re-implementing the loop for
every function to test the gsd-power log. The helper was introduced in
the commit 450a93619 ("power: Add helper to read plugin log during test").
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tests create activity just after the screen is blanked. There is a
race condition as setting up the active monitor may only be done after
the idle time has been reset.
Prevent this by adding a short sleep. This race is inherent to
GnomeIdleMonitor.
Note that the race condition is actually between the call to
gnome_idle_monitor_add_user_active_watch and mutter receiving the dbus
method call.
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
|
| |
GSD waits a while before a lid close action can affect anything. As the
setup routine updates the monitors, this safety timeout will be taken
into account.
This could cause rare test failures if the initialisation was too quick.
Add the explicit sleep to prevent any errors.
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
|
| |
The new API has a composite device and g-s-d uses that rather than
collecting the information itself. Also, upower is doing the critical
action rather than g-s-d meaning that we can only check for the
notification.
Remove/Update the tests to reflect these changes.
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
| |
Add a generic helper to find needles in the gsd-power plugin log.
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
| |
When starting the tests dbus would print a warning as the
XDG_RUNTIME_DIR was not yet created. Simply create this directory to
prevent the warning from being printed.
dbus[2514]: Unable to set up transient service directory: XDG_RUNTIME_DIR "/tmp/gsd-power-testjFVT_p/runtime" not available: No such file or directory
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
| |
The logind object attribute was renamed when moving to the dbusmock
template rather than using something custom. Update the tests to reflect
this. This happened in commit f581667b (tests: Use existing logind template).
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
| |
Otherwise debug information may not be printed making testing
impossible.
This regression was introduced in commit 198f7ea
(plugins: Rename sources of all test applications).
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
| |
The test was setting GSD_MOCK but the C code checked GSD_MOCKED. Fix
this by using GSD_MOCKED in all cases.
This fixes a regression introduced in commit 5fc7cb64 (power: Make power
plugin "mock" support a run-time check).
https://bugzilla.gnome.org/show_bug.cgi?id=792210
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Size-based input/output matching doesn't raise the "found" flag, which
would result on input_info_guess_candidates() still trying to assign the
builtin output to the input device if that is the only match found.
For screen integrated devices (i.e. not on the builtin output) this is
and undesirable possibility, setting the "found" flag to TRUE results on
the correct output being assigned.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
https://bugzilla.gnome.org/show_bug.cgi?id=748589
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GsdDeviceMapper used to refrain from remapping devices that already had
a configured output. This however results on wrong mapping when the input
device is plugged before the output, since the heuristics will attempt
really hard to find an output for the device before the real one is
available, and not remapped again when the output is plugged.
Fix this by forcing remapping on all screen-integrated devices on every
hotplug event, so the input device will get remapped to the right screen
(hopefully!) when it is plugged. This is not applied to devices mapped
to the builtin output, or those with no attached output at all, as in both
of these cases the configured output should be left static.
https://bugzilla.gnome.org/show_bug.cgi?id=748589
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As iio-sensor-proxy isn't yet clever enough to only send property
changes signals to clients that have claimed a sensor, disconnect
the properties-changed signal so we don't attempt to make brightness
changes when we're not on the active seat.
See https://github.com/hadess/iio-sensor-proxy/issues/210
See https://bugzilla.gnome.org/show_bug.cgi?id=756539
See https://bugzilla.gnome.org/show_bug.cgi?id=773685
See https://bugzilla.gnome.org/show_bug.cgi?id=764896
See https://bugzilla.redhat.com/show_bug.cgi?id=1322588
https://bugzilla.gnome.org/show_bug.cgi?id=792409
|
|
|
|
|
|
|
| |
Select which choice should appear in the gnome-shell dialogue, and click
"Ask!". The result of the selection will appear underneath the button.
https://bugzilla.gnome.org/show_bug.cgi?id=782066
|
|
|
|
|
|
|
|
|
|
| |
The property change notification was trying to send a notification for
"kernel-noinput" which was the original name proposed for commit 3810072d2b
(rfkill: Add property to Rfkill helper to inhibit kernel handling).
There is no listener for the event, so this simply fixes a warning.
https://bugzilla.gnome.org/show_bug.cgi?id=790941
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On some devices the power-button sends a KEY_POWER event immediately
after resume when the power-button was used to wakeup the system, causing
the system to suspend immediately again. This is esp. a problem on tablets
where the power-button is often the only way to wakeup the system.
This commit fixes this by listening for suspend/resume signals from
logind (which requires taking a delay inhibitor on suspend to do reliabe)
and on suspend temporarily disabling the power-button.
https://bugzilla.gnome.org/show_bug.cgi?id=789771
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, when gsd-clipboard receives a response to a conversion
request for the MULTIPLE target that indicates failure (i.e. property
== None), it doesn't free the contents list. This leads it to believe
it owns the CLIPBOARD selection, when it actually doesn't. Because of
this, it returns an error for all subsequent SAVE_TARGETS requests,
effectively becoming inoperative as a clipboard manager.
So fix that. Because of the way the code is structured, free_contents
will also be called when a request for the TARGETS target fails, but
at that point the contents list should be empty, so it'll be harmless.
https://bugzilla.gnome.org/show_bug.cgi?id=790344
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=790344
|