| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
The audio feedback for volume changes is useful when nothing is outputting
sound, but only then. Skip the sound notification in that case.
|
|
|
|
| |
Just in case g_variant_get_strv() returns NULL when it really shouldn't.
|
|
|
|
|
|
|
| |
The loop would add items to the array in an infinite loop as the
position of the source "pos" never advanced.
Closes: #471
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the favored method, over our own polkit helper, and over RandR.
Since this helper does its own smart queueing of events, just forward them
as fast as possible, and mark all tasks as completed ASAP on our side.
However, as this is a recent logind feature (New in systemd 243), make this
a soft runtime dependency, by checking first that the required DBus method
exists. We forget about logind and go through the other methods if this one
is not available.
Closes: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/429
|
|
|
|
| |
This was missed in 41a84e315d.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is both broken currently on wayland (since this daemon doesn't
request the x11 backend, and wayland clients need a proper surface/serial
to request clipboard), and conceptually wrong (we wouldn't like to
enable the X11 backend just to let it save to clipboard).
Let gnome-shell handle saving the screenshot to clipboard instead, this
also saves us from saving to /tmp just to copy it to the clipboard
afterwards. We achieve this by passing an empty string as the filename.
Related: https://gitlab.gnome.org/GNOME/mutter/issues/789
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/810
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
We rounded properly for percentage to absolute value, but we always floored the other way around.
The new code achieves this by always rounding. This way the following rule holds (assuming the the min value is 0 for this discussion)
x = round (round (x * scale) / scale)
with
scale = (max - min) / 100
and assuming that scale >= 1
If scale < 1, the rule holds for the other direction.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
The 0.5s timeout was probably based on the fact that the
SECMOD_WaitForAnyTokenEvent call was blocking, it doesn't make sense to
have the timeout on the error case less than the timeout on the normal
case.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSS's SECMOND_WaitForAnyTokenEvent uses the pkcs11 C_WaitForSlotEvent,
and by default NSS will use p11-kit, at least on Fedora and Ubuntu.
p11-kit doesn't support the blocking call for C_WaitForSlotEvent so NSS
falls back to a polling simulation of the C_WaitForSlotEvent. This
causes the LED on the smartcard to blink constantly as the card is
polled.
If we instead use the non-blocking version of the call, which p11-kit
supports, NSS doesn't poll the card. The downside of this is that the
application will wake up every second to check for events even if there
hasn't been any, plus the fact that there could be up to a second delay
between the event and it being picked up by gsd-smartcard. However, NSS
is polling anyway so this is consistent with existing behaviour.
The reason a one second delay was chosen was because this is what was
currently used in NSS. nss/lib/dev/devslot.c:17
/* measured in seconds */
#define NSSSLOT_TOKEN_DELAY_TIME 1
|
|
|
|
|
|
|
|
| |
Currently there is no information on the project for a user who is new
to it. I found the Linux From Scratch page quite useful and so I have
based the README on this page.
http://www.linuxfromscratch.org/blfs/view/systemd/gnome/gnome-settings-daemon.html
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GDBusObjectSkeleton objects are larger than GObject, so we need to
allocate enough space. Otherwise, if we're lucky we'll get:
Sep 13 11:09:32 espresso gsd-smartcard[12882]: specified class size for type 'GsdSmartcardService' is smaller than the parent type's 'GsdSmartcardServiceManagerSkeleton' class size
Sep 13 11:09:32 espresso gsd-smartcard[12882]: g_type_add_interface_static: assertion 'G_TYPE_IS_INSTANTIATABLE (instance_type)' failed
and if we're unlucky we'll get object fields overwriting each other.
Signed-off-by: Simon McVittie <smcv@debian.org>
Fixes: 76b6b794 "smartcard: Use G_DECLARE_FINAL_TYPE for GsdSmartcardService"
|
|
|
|
| |
(cherry picked from commit 570d0881592681d1a3c41674927b74d47a9f58d4)
|
|
|
|
|
|
|
| |
Since the OSD in the shell changed [1] to using float values from 0.0 to
1.0, send a double instead of a percentage via DBus.
[1] https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/385
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The output format changed slightly in newer versions, some typing
information being embedded (eg. "dbus.UInt32(0)" vs. "0"). Those
integer arguments are not even what we are testing for here, so
make the regexes more generic to cater for old and new output
formats.
Closes: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/445
|
|
|
|
|
|
| |
This is an indirect dependency as we spawn gnome-session in them.
Closes: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/445
|
|
|
|
| |
(cherry picked from commit df084ebe974c832db99a440f1e9fe8ec09a8ab12)
|
|
|
|
| |
(cherry picked from commit 57abe92720290e95dff54594743b13a0a1aa2b74)
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit 978e00ccab5ebba757a23b5d2bbc55c00f7e65ed)
|
|
|
|
| |
(cherry picked from commit 4dd2f843d35fdefabbc8861dec05ce57bedd7994)
|
| |
|
|
|
|
| |
(cherry picked from commit bf8b68cf0df5ab0371144b0d698f8669e42b3aaa)
|
|
|
|
|
|
|
|
|
| |
In the processes of adding support to auto-shutdown Xwayland, the
"After" rule was accidentally deleted. Re-add the rule, as otherwise
gsd-xsettings may be started before gnome-shell is and that causes
an immediate session failure.
Fixes: #442
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's some changes in how this service is started:
- Instead of it being part of the gnome-session target initialization
chain, it now depends on a new gnome-session-x11-services target.
Initialization of this target is left up in the air here, and may
happen during startup or at any random point during the running
session. The same analogous behavior will be seen at shutdown.
- The Restart condition has been softened to on-abnormal, as unclean
exits are somewhat unavoidable on Xwayland restart scenarios. Other
crashes or abnormal signals should still be intercepted as usual,
and lead to the fail whale.
|
| |
|
|
|
|
| |
Grab the value of the key into a variable and adjust volume steps according to it.
|
|
|
|
| |
This adds new key so that it the value of the key can be edited with dconf.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit c8258744f4179b06b2ef44601e6a86540160e42f)
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since commit e4297f2ae ("media-keys: Use G_DECLARE_FINAL_TYPE for
MprisController"), the MPRIS support in g-s-d no longer works.
This is caused by the mpris_proxy_ready_cb changes, after the troublesome
commit, the MprisController self pointer is retreived by
the mpris_proxy_ready_cb like this:
MprisController *self = MPRIS_CONTROLLER (object);
But the object parameter to the GAsyncReadyCallback is the source object,
which in this case is the just created GDBusProxy, not our MprisController
object, leading to these warnings:
gsd-media-keys[x]: invalid cast from 'GDBusProxy' to 'MprisController'
Our MprisController is passed through the user_data pointer, so
this commit fixes the code to use this instead.
This fixes the warning and more importantly also makes the MPRIS support work
again, since it now will now properly set self->mpris_client_proxy again.
Fixes: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/437
|