| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Copy-paste error introduced in aa7e3440511. We're inside the loop listing
through all layouts here so returning early means we skip any layout after the
duplicate one.
Before:
$ test-xkb-info | wc -l
3913
Now:
$ test-xkb-info | wc -l
3923
Fixes aa7e344051170ea47585d3d72b1a36e3991121f9
Found by Jason Francis (@jf)
(cherry picked from commit bab269813e8d5254abd9f07b613d3646230be8c3)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the behavior to the one in the old code path before
libxkbregistry.
This also fixes a use-after-free bug when a duplicate layout is present. The
same layout struct is a member of multiple hashtables, specifically
priv->layouts_table, priv->layouts_by_language and priv->layouts_by_country.
When the duplicate layout is added, add_layouts calls g_hash_table_replace
(priv->layouts_table, l->id, l) which frees the original layout - but the
layouts_by_{country|language} still have that now-freed layout.
Immediately afterwards, add_layouts calls add_layout_to_locale_tables () which
calls add_layout_to_table () which triggers a use-after-free.
Avoid all this by simply skipping any duplicate layout.
Reproducible with
gsettings set org.gnome.desktop.input-sources show-all-sources true
valgrind /usr/libexec/gnome-desktop-debug/test-xkb-info
Requires xkeyboard-config <= 2.32, it has a duplicate cm(mmuock) entry
(one is marked exotic, hence the need for show-all-sources).
Fixes #190
Bug analysis by Barnabás Pőcze (@pobrn)
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
(cherry picked from commit aa7e344051170ea47585d3d72b1a36e3991121f9)
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
People might prefix their dates/times with 0 which leads to the number
being interpreted as octal value. This can then lead to "08" being
interpreted as 0, because 8 is not a valid octal value. This is also
much more likely than people intentionally trying to use octal or hex
values for dates/times.
Fixes https://gitlab.gnome.org/GNOME/gnome-desktop/-/issues/189
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix thumbnailing of CBZ comics with UTF-8 filenames, as libarchive will
not be able to parse UTF-8 filenames if a UTF-8 locale is not used.
This assumes that the C.UTF-8 locale is available on the host system,
which shouldn't be a problem on systems able to run GNOME in the first
place.
See https://github.com/libarchive/libarchive/issues/587
and https://github.com/flatpak/flatpak/pull/4138
|
|
|
|
|
|
|
|
| |
In a Flatpak, $FLATPAK_SANDBOX_DIR might be set, but the directory might
not exist. This means that the thumbnailing sandbox might fail to start
because the shared directory is missing.
(test-desktop-thumbnail:6): GnomeDesktop-DEBUG: 16:37:21.007: Thumbnail script ('evince-thumbnailer -s %s %u %o') failed for 'file:///home/hadess/foo.cbz': Could not create temporary sandbox directory
|
| |
|
|
|
|
|
|
| |
rxkb parser updates iso3166Ids by mistake for iso639Ids elements in evdev.
Resolves: https://gitlab.gnome.org/GNOME/gnome-desktop/-/issues/187
|
| |
|
| |
|
|
|
|
|
| |
again"
This reverts commit 9ef9f0e2b2c2e434122fd67cd8d27a706ef2527d
|
| |
|
| |
|
|
|
|
| |
(cherry picked from commit cf3b180d1e89de030a9ee3d01d37dd8853e76b5c)
|
| |
|
| |
|
| |
|
|
|
|
| |
I forgot to add these in commit ba73c28b.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
I request to change kkc to anthy since kkc has been delayed to move
gsettings migrations and etc for many years.
I got the agreement with the original anthy developers and has been forked
it to anthy-unicode.
Resolves: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3430
|
|
|
|
|
| |
See https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/40
and https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35
|
|
|
|
| |
This will make it easier to add new thumbnail sizes.
|
|
|
|
| |
(cherry picked from commit 3668f114223ae7b7eb5e7cd58116b7fa5fb6d34e)
|
| |
|
| |
|
| |
|
|
|
| |
This reverts commit 94bcc0696c7c399d3134cab485fb70172efccb6e
|
|
|
|
| |
I want to see if GitLab has gained any way to set a default issue
template, since almost all of our bug reports are unrelated to libgnome-desktop.
|
|
|
|
| |
This will speed up thumbnailers that need it.
|
| |
|
| |
|
| |
|