From 7344df9281f13a64bebaf189160ef0e31641574e Mon Sep 17 00:00:00 2001 From: Ray Strode Date: Thu, 15 Dec 2022 14:46:01 -0500 Subject: kerberos-identity: Fix buglet in update_identity The update_identity function is supposed to transfer the identity from one object to another. In practice, this is currently always a noop because only objects with the same identities get copied to each other. Nevertheless, there is a bug in the function. It grabs the identity from the target object instead of from the source object. This commit fixes that. --- src/goaidentity/goakerberosidentity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c index a20c043..bc60796 100644 --- a/src/goaidentity/goakerberosidentity.c +++ b/src/goaidentity/goakerberosidentity.c @@ -1507,7 +1507,7 @@ update_identifier (GoaKerberosIdentity *self, GoaKerberosIdentity *new_identity) { char *new_identifier; - new_identifier = get_identifier (self, NULL); + new_identifier = get_identifier (new_identity, NULL); if (g_strcmp0 (self->identifier, new_identifier) != 0 && new_identifier != NULL) { g_free (self->identifier); -- cgit v1.2.1