summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Meson build instructions for libmediaartmesonSam Thursfield2017-07-218-0/+217
| | | | | | | | | | | | | These are hopefully complete already. I have compared an Autotools-built and a Meson-built install of libmediaart and found only the following differences: * libmediaart-2.0.la isn't generated by Meson * External references in the gtk-doc documentation are relative with Meson and absolute with Autotools * Some changes in generated .vapi file and .pc file https://bugzilla.gnome.org/show_bug.cgi?id=783562
* Use compiler symbol visiblity features to hide internal functionsSam Thursfield2017-07-216-3/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we relied on libtool's -export-symbols-regex feature, but we are hoping to drop GNU Autotools and GNU Libtool in soon in favour of Meson. Meson doesn't have an equivalent feature, instead the advice is to control symbol visibility at compile time. The approach taken in this patch is based on Pango's build system. Pango tells the compiler to hide symbols by default (if possible), and then defines a _PANGO_EXTERN variable at compile time which marks a single symbol as public. In Pango's case there is then further machinary to hide symbols based on deprecation policies but I have not copied that here, instead I used _LIBMEDIAART_EXTERN directly. If a compiler doesn't support hiding symbols then the library we build makes all symbols available, which is exactly what would happen before on platforms where the libtool didn't have an implementation for -export-symbols-regex. See also: http://mesonbuild.com/FAQ.html#how-do-i-do-the-equivalent-of-libtools-exportsymbol-and-exportregex https://git.gnome.org/browse/pango/ https://git.gnome.org/browse/pango/tree/pango/pango-version-macros.h https://gcc.gnu.org/wiki/Visibility https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options (-fvisibility)
* Remove --enable-nemoSam Thursfield2017-07-212-25/+0
| | | | | | | | This flag was just enabling a codepath that sets QT_QPA_PLATFORM=minimal in the environment before constructing a QCoreApplication instance. This code path has no effect anyway: QT_QPA_PLATFORM only has an effect if you are using QGuiApplication.
* Remove duplicate introspection comment for media_art_error_quark()Sam Thursfield2017-07-211-7/+0
| | | | | | Fixes this warning: libmediaart/extract.h:93: Warning: MediaArt: multiple comment blocks documenting 'media_art_error_quark:' identifier (already seen at extract.c:1279).
* build: Add an explicit dependency on marshal filesEmmanuele Bassi2017-07-171-0/+2
| | | | | We need those files to be generated before the library is built, but it seems Automake is failing miserably in conditions of massive parallelism.
* build: Improve dependency tracking for marshallers sourcesEmmanuele Bassi2017-07-171-6/+8
| | | | | | | | | Under massive parallelism — like the Continuous build — we may end up in a situation where the sources get built before the marshaller sources are generated. Let's try to increase chances that the dependency tracking inside Automake will do the right thing.
* extract: Remove Nokia album art downloader supportJens Georg2017-06-301-143/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=767959
* Release 1.9.11.9.1Carlos Garnacho2017-03-052-1/+9
|
* extract: Add introspection annotations to media_art_buffer_to_jpeg()Carlos Garnacho2017-03-041-1/+1
| | | | Otherwise the function is unusable through gobject-introspection.
* extract: Initialize variableCarlos Garnacho2016-12-151-1/+1
| | | | | There are paths where the stop variable is not set, so might end up with an uninitialized value when checked.
* libmediaart: Fix _media_art_marshal*() errors when compilingbaserock/1.9.0-8-g52eb649Martyn Russell2015-07-122-4/+4
|
* build: Allow Qt4 or Qt5 to be forcedPaweł Stankowski2015-05-311-8/+17
| | | | | Adds optional configure flag "--with-qt-version=<4|5>" that may be used to enforce qt 4.x or qt 5.x version.
* build: hide private symbolsMichael Biebl2015-05-312-5/+6
| | | | | Use -export-symbols-regex to hide private symbols which should not be exported.
* extract: Align annotation with documentationJens Georg2015-05-151-1/+1
| | | | | | | Documentation says "or NULL" and the code also handles it, but the g-i for this was missing. https://bugzilla.gnome.org/show_bug.cgi?id=739943
* extract: Allow empty artist in media_art_setJens Georg2015-05-151-1/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=739942
* extract: Don't print confusing random strerrorJens Georg2015-05-151-2/+2
| | | | | | | debug was printing g_strerror(errno) even in success case, leaving weird confusing messages, indicating an error even if symlinking succeeded. https://bugzilla.gnome.org/show_bug.cgi?id=739873
* tests: No new temporary cache directories for subprocess testsYanko Kaneti2014-11-131-5/+10
| | | | Otherwise subprocess tests that assert by design leave those behind
* tests: Make mediarttest work as both installed and built testYanko Kaneti2014-11-132-14/+10
|
* Release 1.9.01.9.0Martyn Russell2014-10-172-4/+23
|
* Merge branch 'remove-mediaartlocal'Martyn Russell2014-10-174-307/+86
|\
| * extract, cache: Remove all .mediaartlocal usesremove-mediaartlocalMartyn Russell2014-10-174-307/+80
| | | | | | | | | | | | | | This is deemed quite useless now and we should not be littering the file system with .mediaartlocal directories everywhere. https://bugzilla.gnome.org/show_bug.cgi?id=722795
| * cache: Added media_art_remove_async() and _finish()Martyn Russell2014-10-171-3/+9
|/ | | | | | | | Part of this API changes makes the media_art_get_{path|file}() APIs not do i/o operations like creating the cache directory. This is now done in media_art_process_new(). https://bugzilla.gnome.org/show_bug.cgi?id=724879
* Merge branch 'async-api'Martyn Russell2014-10-176-483/+1333
|\
| * extract: Add async APIs for all functionsasync-apiMartyn Russell2014-10-173-424/+1062
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=724879
| * cache: Fixed removing media art, was failing badlyMartyn Russell2014-10-171-55/+51
| |
| * cache: Added media_art_remove_async() and _finish()Martyn Russell2014-10-176-34/+250
|/ | | | | | | | Part of this API changes makes the media_art_get_{path|file}() APIs not do i/o operations like creating the cache directory. This is now done in media_art_process_new(). https://bugzilla.gnome.org/show_bug.cgi?id=724879
* Release 0.7.00.7.0Martyn Russell2014-09-222-1/+10
|
* extract: Fixed gtkdoc warning for return value of media_art_error_quark()Martyn Russell2014-09-161-1/+1
|
* cache: Allow null values in artist, title and prefixArnel A. Borja2014-09-101-6/+6
| | | | | | | | | The function media_art_get_file checks for null values in artist, title and prefix arguments, and puts special values on them if they do. Do the same on media_art_get_path which calls media_art_get_file internally. https://bugzilla.gnome.org/show_bug.cgi?id=727478
* tests: Don't clear existing caches with unit tests, set XDG_CACHE_HOMEMartyn Russell2014-09-101-0/+12
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=731681
* Relase 0.6.00.6.0Martyn Russell2014-08-192-1/+16
|
* build: include m4 dir parsingVadim Rutkovsky2014-08-151-0/+2
|
* build: Fixed continuous build failure that was detectedMartyn Russell2014-08-151-2/+2
| | | | AutoMake warning += vs = for EXTRA_DIST/CLEANFILES
* cache: Make the documentation for media_art_get_path() and _get_file() clearerMartyn Russell2014-08-152-23/+76
| | | | | | | Also added some checks into the API and a return value to know if the function was successful. https://bugzilla.gnome.org/show_bug.cgi?id=734837
* tests: Use tap automake testing scripts, fixes output summariesMartyn Russell2014-08-1511-171/+910
| | | | Also updated the unit tests so they don't fail with the new tap system
* doap: add <programming-language>Andre Klapper2014-08-011-0/+1
|
* doap category coreOlav Vitters2014-07-301-1/+1
|
* extract: Fixed process_buffer() len check (was inverted) and artist/titleMartyn Russell2014-07-281-1/+4
|
* Release 0.5.00.5.0Martyn Russell2014-07-282-2/+27
|
* build: Fixed distcheck issuesMartyn Russell2014-07-283-8/+8
|
* build: Updated .gitignore to omit INSTALL, *.vapi...Martyn Russell2014-07-282-2/+4
|
* build: Updated configure.ac from autoscan suggestionsMartyn Russell2014-07-281-15/+5
|
* Merge branch 'api-cleanup'Martyn Russell2014-07-2817-602/+1734
|\
| * extract: Fixed 'since' versions in documentationapi-cleanupMartyn Russell2014-07-282-7/+7
| |
| * libmediaart: Split API into _process_buffer() and _process_file()Martyn Russell2014-07-2810-199/+397
| | | | | | | | | | | | | | This is quite an API break, but the previous API was confusing and a monster, so this was really necessary. The unit tests have been put in place to make sure things work correctly too.
| * docs: Fixed Makefile so we don't fail on distcheck with --enable-gtk-docMartyn Russell2014-07-281-3/+6
| | | | | | | | Use $top_srcdir, not relative links
| * build: Improve warnings used when compilingMartyn Russell2014-07-284-0/+552
| | | | | | | | | | | | | | | | | | Use CC_CHECK_FLAGS_APPEND m4 macro to make sure GCC supports flags This is after finding out that some platforms or versions of GCC don't support flags like -Wmaybe-uninitialized The attributes.m4 is stolen from systemd who stole it from xine-lib.
| * extract: Add _SYMLINK_FAILED error and report symlink() failure in ↵Martyn Russell2014-06-232-176/+280
| | | | | | | | get_heuristic()
| * extract: Add GError for _NO_TITLE, which is required in some casesMartyn Russell2014-06-232-5/+7
| |
| * tests: Don't expect media art extraction for NULL data buffer for !imagesMartyn Russell2014-06-232-10/+17
| |