summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Mandate that inputs are valid UTF8sam/valid-utf8Sam Thursfield2020-12-272-0/+28
| | | | | | | | | | | | | This restriction was already in place, since we passed the inputs directly to GLib functions that expect valid UTF8. If this library were widely used then we might proactively validate inputs to protect against exploits. At time of writing, this module is only used in 3 places (grilo-plugins, gnome-music and rygel), so just check they are doing the right thing when calling the API. See https://gitlab.gnome.org/GNOME/libmediaart/-/merge_requests/5 for background.
* Merge branch 'sam/ci' into 'master'Sam Thursfield2020-10-161-0/+63
|\ | | | | | | | | Initial CI config See merge request GNOME/libmediaart!6
| * Initial CI configSam Thursfield2020-10-161-0/+63
|/
* Merge branch 'master' into 'master'Sam Thursfield2020-10-161-0/+4
|\ | | | | | | | | Fix Qt5 backend crashing when running in Qt application See merge request GNOME/libmediaart!2
| * Fix Qt5 backend crashing when running in Qt applicationPekka Vuorela2020-04-221-0/+4
| | | | | | | | | | Creating a dummy QCoreApplication instance is bad in itself, but even worse when running in an app that already has one.
* | Merge branch 'master' into 'master'Sam Thursfield2020-10-162-1/+2
|\ \ | | | | | | | | | | | | meson.build: don't require C++ See merge request GNOME/libmediaart!3
| * | meson.build: don't require C++Fabrice Fontaine2020-05-082-1/+2
| |/ | | | | | | | | | | Does not mandate C++ as it is only required for extractqt.cpp Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
* | Merge branch 'wip/phako/remove-storage' into 'master'Carlos Garnacho2020-06-235-1244/+2
|\ \ | |/ |/| | | | | Remove storage class See merge request GNOME/libmediaart!4
| * extract: Remove Storagewip/phako/remove-storageJens Georg2020-05-315-1240/+2
| | | | | | | | | | | | After the removal of mediaartlocal, this is useless now. It can also cause some lock-ups if gvfs is missing
| * extract: Drop obsolete stringsJens Georg2020-05-311-4/+0
|/
* Replace Bugzilla by Gitlab URL in DOAP fileAndre Klapper2018-12-151-2/+1
|
* meson: Introspection fixMarinus Schraal2018-01-081-1/+5
| | | | | | | The meson build did not add the extractdummy.c to the sources, which contains introspection annotations. https://bugzilla.gnome.org/show_bug.cgi?id=792272
* Release 1.9.41.9.4Carlos Garnacho2017-08-113-2/+8
|
* extract*: Add missing config.h includesCarlos Garnacho2017-08-102-0/+4
| | | | | This was making the functions defined in extractgeneric.h not really exported.
* meson: Add missing mediaart-macros.h headerCarlos Garnacho2017-08-101-0/+1
| | | | This must be installed by the meson install as well...
* meson: Add with-docs optionCarlos Garnacho2017-08-102-7/+10
| | | | Allows disabling the API reference docs.
* Release 1.9.31.9.3Carlos Garnacho2017-08-103-2/+8
|
* meson: Fix library versioningJan Alexander Steffens (heftig)2017-08-102-0/+8
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=786067
* build: Install macros headerEmmanuele Bassi2017-08-101-1/+1
| | | | | The header is referenced by publicly installed headers, which means installations of libmediaart without it are now broken.
* Release 1.9.21.9.2Carlos Garnacho2017-08-093-2/+10
|
* Distcheck fixesCarlos Garnacho2017-08-092-1/+3
|
* docs: Rename main doc to .xmlCarlos Garnacho2017-08-093-2/+2
|
* build: Add meson.build files to EXTRA_DISTCarlos Garnacho2017-08-094-1/+6
|
* Meson build instructions for libmediaartSam Thursfield2017-08-095-0/+206
| | | | | | | | | | | | | These are hopefully complete already. I have compared an Autotools-built and a Meson-built install of libmediaart and found only the following differences: * libmediaart-2.0.la isn't generated by Meson * External references in the gtk-doc documentation are relative with Meson and absolute with Autotools * Some changes in generated .vapi file and .pc file https://bugzilla.gnome.org/show_bug.cgi?id=783562
* Use compiler symbol visiblity features to hide internal functionsSam Thursfield2017-08-096-3/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we relied on libtool's -export-symbols-regex feature, but we are hoping to drop GNU Autotools and GNU Libtool in soon in favour of Meson. Meson doesn't have an equivalent feature, instead the advice is to control symbol visibility at compile time. The approach taken in this patch is based on Pango's build system. Pango tells the compiler to hide symbols by default (if possible), and then defines a _PANGO_EXTERN variable at compile time which marks a single symbol as public. In Pango's case there is then further machinary to hide symbols based on deprecation policies but I have not copied that here, instead I used _LIBMEDIAART_EXTERN directly. If a compiler doesn't support hiding symbols then the library we build makes all symbols available, which is exactly what would happen before on platforms where the libtool didn't have an implementation for -export-symbols-regex. See also: http://mesonbuild.com/FAQ.html#how-do-i-do-the-equivalent-of-libtools-exportsymbol-and-exportregex https://git.gnome.org/browse/pango/ https://git.gnome.org/browse/pango/tree/pango/pango-version-macros.h https://gcc.gnu.org/wiki/Visibility https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options (-fvisibility) https://bugzilla.gnome.org/show_bug.cgi?id=783562
* Remove --enable-nemoSam Thursfield2017-08-092-25/+0
| | | | | | | | | | This flag was just enabling a codepath that sets QT_QPA_PLATFORM=minimal in the environment before constructing a QCoreApplication instance. This code path has no effect anyway: QT_QPA_PLATFORM only has an effect if you are using QGuiApplication. https://bugzilla.gnome.org/show_bug.cgi?id=783562
* Remove duplicate introspection comment for media_art_error_quark()Sam Thursfield2017-07-211-7/+0
| | | | | | Fixes this warning: libmediaart/extract.h:93: Warning: MediaArt: multiple comment blocks documenting 'media_art_error_quark:' identifier (already seen at extract.c:1279).
* build: Add an explicit dependency on marshal filesEmmanuele Bassi2017-07-171-0/+2
| | | | | We need those files to be generated before the library is built, but it seems Automake is failing miserably in conditions of massive parallelism.
* build: Improve dependency tracking for marshallers sourcesEmmanuele Bassi2017-07-171-6/+8
| | | | | | | | | Under massive parallelism — like the Continuous build — we may end up in a situation where the sources get built before the marshaller sources are generated. Let's try to increase chances that the dependency tracking inside Automake will do the right thing.
* extract: Remove Nokia album art downloader supportJens Georg2017-06-301-143/+2
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=767959
* Release 1.9.11.9.1Carlos Garnacho2017-03-052-1/+9
|
* extract: Add introspection annotations to media_art_buffer_to_jpeg()Carlos Garnacho2017-03-041-1/+1
| | | | Otherwise the function is unusable through gobject-introspection.
* extract: Initialize variableCarlos Garnacho2016-12-151-1/+1
| | | | | There are paths where the stop variable is not set, so might end up with an uninitialized value when checked.
* libmediaart: Fix _media_art_marshal*() errors when compilingbaserock/1.9.0-8-g52eb649Martyn Russell2015-07-122-4/+4
|
* build: Allow Qt4 or Qt5 to be forcedPaweł Stankowski2015-05-311-8/+17
| | | | | Adds optional configure flag "--with-qt-version=<4|5>" that may be used to enforce qt 4.x or qt 5.x version.
* build: hide private symbolsMichael Biebl2015-05-312-5/+6
| | | | | Use -export-symbols-regex to hide private symbols which should not be exported.
* extract: Align annotation with documentationJens Georg2015-05-151-1/+1
| | | | | | | Documentation says "or NULL" and the code also handles it, but the g-i for this was missing. https://bugzilla.gnome.org/show_bug.cgi?id=739943
* extract: Allow empty artist in media_art_setJens Georg2015-05-151-1/+0
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=739942
* extract: Don't print confusing random strerrorJens Georg2015-05-151-2/+2
| | | | | | | debug was printing g_strerror(errno) even in success case, leaving weird confusing messages, indicating an error even if symlinking succeeded. https://bugzilla.gnome.org/show_bug.cgi?id=739873
* tests: No new temporary cache directories for subprocess testsYanko Kaneti2014-11-131-5/+10
| | | | Otherwise subprocess tests that assert by design leave those behind
* tests: Make mediarttest work as both installed and built testYanko Kaneti2014-11-132-14/+10
|
* Release 1.9.01.9.0Martyn Russell2014-10-172-4/+23
|
* Merge branch 'remove-mediaartlocal'Martyn Russell2014-10-174-307/+86
|\
| * extract, cache: Remove all .mediaartlocal usesremove-mediaartlocalMartyn Russell2014-10-174-307/+80
| | | | | | | | | | | | | | This is deemed quite useless now and we should not be littering the file system with .mediaartlocal directories everywhere. https://bugzilla.gnome.org/show_bug.cgi?id=722795
| * cache: Added media_art_remove_async() and _finish()Martyn Russell2014-10-171-3/+9
|/ | | | | | | | Part of this API changes makes the media_art_get_{path|file}() APIs not do i/o operations like creating the cache directory. This is now done in media_art_process_new(). https://bugzilla.gnome.org/show_bug.cgi?id=724879
* Merge branch 'async-api'Martyn Russell2014-10-176-483/+1333
|\
| * extract: Add async APIs for all functionsasync-apiMartyn Russell2014-10-173-424/+1062
| | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=724879
| * cache: Fixed removing media art, was failing badlyMartyn Russell2014-10-171-55/+51
| |
| * cache: Added media_art_remove_async() and _finish()Martyn Russell2014-10-176-34/+250
|/ | | | | | | | Part of this API changes makes the media_art_get_{path|file}() APIs not do i/o operations like creating the cache directory. This is now done in media_art_process_new(). https://bugzilla.gnome.org/show_bug.cgi?id=724879
* Release 0.7.00.7.0Martyn Russell2014-09-222-1/+10
|