| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Most of them are taken from the Vala overrides: https://gitlab.gnome.org/GNOME/vala/-/blob/master/vapi/metadata/Rest-0.7.metadata
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Calling rest_xml_parser_parse_from_data() with an empty string ("")
currently causes a crash as xmlReaderForMemory() returns NULL in that
case, and we then try to dereference this pointer without checking it's
non-NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=789053
|
|
|
|
|
| |
This is already done in finish_call and the g_strdup to
priv->status_message was leaking the previously set one.
|
|
|
|
| |
So they end up being available in the generated html documentation.
|
|
|
|
|
| |
Before this, it was impossible to get the server payload from a proxy
call invoked via rest_proxy_call_upload.
|
|
|
|
|
|
| |
This reverts commit 2d1dbfe7073b1e153ff881426b40a9a517fb796b
https://bugzilla.gnome.org/show_bug.cgi?id=788960
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The order in which GHashTable returns its key-value pairs is undefined.
Therefore the output of rest_xml_node_print can change based on the
GHashTable implementation. While not strictly necessary, it would be
nice to avoid that. Having a stable order, even if it is not
documented and depends on the current RestXmlNode code, is handy for
testing.
This was the main reason behind the tests/xml.c breakage.
https://bugzilla.gnome.org/show_bug.cgi?id=788960
|
|
|
|
|
|
|
|
|
|
| |
The rest_xml_node_add_child API explicitly documents NULL parents as
the way to create top-level nodes. This had broken the second half of
tests/xml.c.
Fallout from b11a1664cd4dfcc62b07b4a68adc220fd1eb8305
https://bugzilla.gnome.org/show_bug.cgi?id=788960
|
|
|
|
|
|
|
|
| |
This had broken tests/xml.c.
Fallout from 61a7b231bd8b9d1b8d02dca120389e79d38b428d
https://bugzilla.gnome.org/show_bug.cgi?id=788960
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785818
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785818
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785811
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785811
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785811
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785811
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=785811
|
|
|
|
|
|
| |
Bump minimum GLib version to 2.44.0.
https://bugzilla.gnome.org/show_bug.cgi?id=785811
|
|
|
|
|
| |
Use assert macros instead of error counting and drop deprecated libsoup
API
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Currently rest_proxy_call_sync (and everything else using
prepare_message) might return FALSE without setting @error at all. Add
two new error codes to indicate the possible problems and reliably
set the error if something went wrong.
|
| |
|
|
|
|
|
|
|
| |
It has been deprecated for a long while, and we were only using it for
proxy support. However, now that we switched to using SoupSession rather
than SoupSession{Sync,Async}, a default proxy resolver will be used, so
we don't need to set it explicitly.
|
|
|
|
|
| |
We switched to using SoupSession directly, but it's only possible since
libsoup 2.42
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes:
==16342== 93 (64 direct, 29 indirect) bytes in 1 blocks are definitely lost in loss record 211 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342== by 0x4009E6: test_url_fragment_no_access_token (oauth2.c:36)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 133 (64 direct, 69 indirect) bytes in 1 blocks are definitely lost in loss record 262 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342== by 0x400A25: test_access_token_simple (oauth2.c:44)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 137 (64 direct, 73 indirect) bytes in 1 blocks are definitely lost in loss record 263 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342== by 0x400A97: test_url_encoding_access_token (oauth2.c:51)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The string returned from oauth2_proxy_extract_access_token() must be
freed. This fixes:
==16342== 27 bytes in 1 blocks are definitely lost in loss record 125 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F75917: g_strndup (gstrfuncs.c:425)
==16342== by 0x56D9BA4: soup_uri_decoded_copy (soup-uri.c:761)
==16342== by 0x4E48C0B: oauth2_proxy_extract_access_token (oauth2-proxy.c:392)
==16342== by 0x400A25: test_access_token_simple (oauth2.c:44)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 27 bytes in 1 blocks are definitely lost in loss record 126 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F75917: g_strndup (gstrfuncs.c:425)
==16342== by 0x56D9BA4: soup_uri_decoded_copy (soup-uri.c:761)
==16342== by 0x4E48C0B: oauth2_proxy_extract_access_token (oauth2-proxy.c:392)
==16342== by 0x400A97: test_url_encoding_access_token (oauth2.c:51)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes:
==16369== 16 bytes in 1 blocks are definitely lost in loss record 885 of 3,291
==16369== at 0x4C2DA60: calloc (vg_replace_malloc.c:711)
==16369== by 0x5F5CEB0: g_malloc0 (gmem.c:124)
==16369== by 0x5F57BF1: g_main_loop_new (gmain.c:3929)
==16369== by 0x401B13: test_request_token (oauth-async.c:183)
==16369== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16369== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16369== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16369== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16369== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16369== by 0x401D1C: main (oauth-async.c:237)
==16369==
==16369== 16 bytes in 1 blocks are definitely lost in loss record 886 of 3,291
==16369== at 0x4C2DA60: calloc (vg_replace_malloc.c:711)
==16369== by 0x5F5CEB0: g_malloc0 (gmem.c:124)
==16369== by 0x5F57BF1: g_main_loop_new (gmain.c:3929)
==16369== by 0x401BA9: test_access_token (oauth-async.c:199)
==16369== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16369== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16369== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16369== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16369== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16369== by 0x401D1C: main (oauth-async.c:237)
==16369==
==16369== 16 bytes in 1 blocks are definitely lost in loss record 887 of 3,291
==16369== at 0x4C2DA60: calloc (vg_replace_malloc.c:711)
==16369== by 0x5F5CEB0: g_malloc0 (gmem.c:124)
==16369== by 0x5F57BF1: g_main_loop_new (gmain.c:3929)
==16369== by 0x401C3F: test_calls (oauth-async.c:215)
==16369== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16369== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16369== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16369== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16369== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16369== by 0x401D1C: main (oauth-async.c:237)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
==16230== 24 bytes in 1 blocks are definitely lost in loss record 1,292 of 3,425
==16230== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16230== by 0x5F5CE58: g_malloc (gmem.c:94)
==16230== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16230== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16230== by 0x5CEE821: g_type_create_instance (gtype.c:1857)
==16230== by 0x5CD06AA: g_object_new_internal (gobject.c:1781)
==16230== by 0x5CD20CC: g_object_newv (gobject.c:1928)
==16230== by 0x5CD28B3: g_object_new (gobject.c:1621)
==16230== by 0x4E4557B: rest_xml_parser_new (rest-xml-parser.c:62)
==16230== by 0x401126: test_flickr (flickr.c:62)
==16230== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16230== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16230== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16230== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16230== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16230== by 0x40169A: main (flickr.c:115)
==16230==
==16230== 24 bytes in 1 blocks are definitely lost in loss record 1,293 of 3,425
==16230== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16230== by 0x5F5CE58: g_malloc (gmem.c:94)
==16230== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16230== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16230== by 0x5CEE821: g_type_create_instance (gtype.c:1857)
==16230== by 0x5CD06AA: g_object_new_internal (gobject.c:1781)
==16230== by 0x5CD20CC: g_object_newv (gobject.c:1928)
==16230== by 0x5CD28B3: g_object_new (gobject.c:1621)
==16230== by 0x4E4557B: rest_xml_parser_new (rest-xml-parser.c:62)
==16230== by 0x40142C: test_flickr (flickr.c:90)
==16230== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16230== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16230== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16230== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16230== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16230== by 0x40169A: main (flickr.c:115)
==16230==
==16230== 1,010 (48 direct, 962 indirect) bytes in 1 blocks are definitely lost in loss record 3,333 of 3,425
==16230== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16230== by 0x5F5CE58: g_malloc (gmem.c:94)
==16230== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16230== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16230== by 0x4E44C8D: _rest_xml_node_new (rest-xml-node.c:126)
==16230== by 0x4E45763: rest_xml_parser_parse_from_data (rest-xml-parser.c:118)
==16230== by 0x401460: test_flickr (flickr.c:91)
==16230== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16230== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16230== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16230== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16230== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16230== by 0x40169A: main (flickr.c:115)
==16230==
==16230== 2,516 (32 direct, 2,484 indirect) bytes in 1 blocks are definitely lost in loss record 3,370 of 3,425
==16230== at 0x5CEE964: g_type_create_instance (gtype.c:1854)
==16230== by 0x5CD06AA: g_object_new_internal (gobject.c:1781)
==16230== by 0x5CD25ED: g_object_new_valist (gobject.c:2040)
==16230== by 0x5CD28A0: g_object_new (gobject.c:1624)
==16230== by 0x50524F8: _new_call (flickr-proxy.c:59)
==16230== by 0x4E40601: rest_proxy_new_call (rest-proxy.c:584)
==16230== by 0x4013BF: test_flickr (flickr.c:85)
==16230== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16230== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16230== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16230== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16230== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16230== by 0x40169A: main (flickr.c:115)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes:
==16342== 93 (64 direct, 29 indirect) bytes in 1 blocks are definitely lost in loss record 211 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342== by 0x4009E6: test_url_fragment_no_access_token (oauth2.c:36)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 133 (64 direct, 69 indirect) bytes in 1 blocks are definitely lost in loss record 262 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342== by 0x400A25: test_access_token_simple (oauth2.c:44)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
==16342==
==16342== 137 (64 direct, 73 indirect) bytes in 1 blocks are definitely lost in loss record 263 of 278
==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16342== by 0x5F5CE58: g_malloc (gmem.c:94)
==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025)
==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051)
==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283)
==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519)
==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384)
==16342== by 0x400A97: test_url_encoding_access_token (oauth2.c:51)
==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158)
==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241)
==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253)
==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328)
==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596)
==16342== by 0x400B64: main (oauth2.c:65)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current code is using xml = g_strconcat (xml, ...) which is causing
some leaks as g_strconcat returns a newly allocated string. Using
GString avoids this issue without constantly freeing the intermediate
strings.
This fixes multiple leaks like:
==16611== 18 bytes in 1 blocks are definitely lost in loss record 124 of 301
==16611== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299)
==16611== by 0x5F5CE58: g_malloc (gmem.c:94)
==16611== by 0x5F75B8E: g_strconcat (gstrfuncs.c:585)
==16611== by 0x4E450CF: rest_xml_node_print (rest-xml-node.c:287)
==16611== by 0x4E451DA: rest_xml_node_print (rest-xml-node.c:305)
==16611== by 0x4E450F8: rest_xml_node_print (rest-xml-node.c:292)
==16611== by 0x4009A0: main (xml.c:40)
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|