summaryrefslogtreecommitdiff
path: root/rest
Commit message (Collapse)AuthorAgeFilesLines
* Add several missing annotationstintou/annotations-fixesCorentin Noël2020-10-152-8/+19
| | | | Most of them are taken from the Vala overrides: https://gitlab.gnome.org/GNOME/vala/-/blob/master/vapi/metadata/Rest-0.7.metadata
* xml: Don't crash parsing empty XML stringChristophe Fergeau2017-10-181-0/+3
| | | | | | | | | Calling rest_xml_parser_parse_from_data() with an empty string ("") currently causes a crash as xmlReaderForMemory() returns NULL in that case, and we then try to dereference this pointer without checking it's non-NULL. https://bugzilla.gnome.org/show_bug.cgi?id=789053
* proxycall: remove double-assign to status_{code,message}Timm Bäder2017-10-171-3/+0
| | | | | This is already done in finish_call and the g_strdup to priv->status_message was leaking the previously set one.
* RestProxy: Set the payload after _uploadTimm Bäder2017-10-171-1/+1
| | | | | Before this, it was impossible to get the server payload from a proxy call invoked via rest_proxy_call_upload.
* xml-node: Define the order in which attributes & children are printedDebarshi Ray2017-10-161-1/+22
| | | | | | | | | | | | | The order in which GHashTable returns its key-value pairs is undefined. Therefore the output of rest_xml_node_print can change based on the GHashTable implementation. While not strictly necessary, it would be nice to avoid that. Having a stable order, even if it is not documented and depends on the current RestXmlNode code, is handy for testing. This was the main reason behind the tests/xml.c breakage. https://bugzilla.gnome.org/show_bug.cgi?id=788960
* xml-node: Unbreak the creation of top-level nodesDebarshi Ray2017-10-161-1/+0
| | | | | | | | | | The rest_xml_node_add_child API explicitly documents NULL parents as the way to create top-level nodes. This had broken the second half of tests/xml.c. Fallout from b11a1664cd4dfcc62b07b4a68adc220fd1eb8305 https://bugzilla.gnome.org/show_bug.cgi?id=788960
* xml-node: Remove stray blank spaceDebarshi Ray2017-10-161-1/+1
| | | | | | | | This had broken tests/xml.c. Fallout from 61a7b231bd8b9d1b8d02dca120389e79d38b428d https://bugzilla.gnome.org/show_bug.cgi?id=788960
* oauth2-proxy: Use G_DEFINE_TYPE_WITH_PRIVATEDebarshi Ray2017-08-041-6/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785818
* rest-proxy-auth: Use G_DEFINE_TYPE_WITH_PRIVATEDebarshi Ray2017-08-041-7/+4
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785818
* oauth2-proxy-call: Use G_DECLARE_DERIVABLE_TYPEDebarshi Ray2017-08-041-22/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785811
* oauth-proxy-call: Use G_DECLARE_DERIVABLE_TYPEDebarshi Ray2017-08-041-22/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785811
* rest-xml-parser: Use G_DECLARE_DERIVABLE_TYPEDebarshi Ray2017-08-041-23/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785811
* rest-proxy-call: Use G_DECLARE_DERIVABLE_TYPEDebarshi Ray2017-08-041-23/+3
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=785811
* rest-proxy: Use G_DECLARE_DERIVABLE_TYPEDebarshi Ray2017-08-041-23/+1
| | | | | | Bump minimum GLib version to 2.44.0. https://bugzilla.gnome.org/show_bug.cgi?id=785811
* RestProxy: Remove unused session_syncTimm Bäder2016-07-191-1/+0
|
* RestProxyCall: Add documentation for _syncTimm Bäder2016-07-191-0/+14
|
* RestProxyCall: Make sure _sync reliably sets error_outTimm Bäder2016-07-192-2/+24
| | | | | | | Currently rest_proxy_call_sync (and everything else using prepare_message) might return FALSE without setting @error at all. Add two new error codes to indicate the possible problems and reliably set the error if something went wrong.
* RestProxyCall: Remove unused structTimm Bäder2016-07-191-6/+0
|
* proxy: Remove use of libsoup-gnomeChristophe Fergeau2016-07-191-8/+0
| | | | | | | It has been deprecated for a long while, and we were only using it for proxy support. However, now that we switched to using SoupSession rather than SoupSession{Sync,Async}, a default proxy resolver will be used, so we don't need to set it explicitly.
* oauth-proxy: Add docs for request_token_finishwip/baedert/gtask2Timm Bäder2016-07-141-0/+11
|
* Add more missing precondition checksTimm Bäder2016-07-143-2/+14
|
* rest-param: Add missing preconditionsTimm Bäder2016-07-141-2/+22
|
* oauth-proxy: Fix some gtkdoc errorsTimm Bäder2016-07-141-8/+0
|
* oauth-proxy-call: Remove an unnecessary castTimm Bäder2016-07-141-1/+1
|
* rest-proxy: Fix precondition in new_callTimm Bäder2016-07-141-1/+5
|
* rest-proxy: Add some missing preconditionsTimm Bäder2016-07-141-2/+9
|
* oauth2: Fix SoupUri leak in oauth2_proxy_extract_access_token()wip/teuf/gtaskChristophe Fergeau2016-06-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes: ==16342== 93 (64 direct, 29 indirect) bytes in 1 blocks are definitely lost in loss record 211 of 278 ==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299) ==16342== by 0x5F5CE58: g_malloc (gmem.c:94) ==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025) ==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051) ==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283) ==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519) ==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384) ==16342== by 0x4009E6: test_url_fragment_no_access_token (oauth2.c:36) ==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158) ==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241) ==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253) ==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328) ==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596) ==16342== by 0x400B64: main (oauth2.c:65) ==16342== ==16342== 133 (64 direct, 69 indirect) bytes in 1 blocks are definitely lost in loss record 262 of 278 ==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299) ==16342== by 0x5F5CE58: g_malloc (gmem.c:94) ==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025) ==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051) ==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283) ==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519) ==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384) ==16342== by 0x400A25: test_access_token_simple (oauth2.c:44) ==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158) ==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241) ==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253) ==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328) ==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596) ==16342== by 0x400B64: main (oauth2.c:65) ==16342== ==16342== 137 (64 direct, 73 indirect) bytes in 1 blocks are definitely lost in loss record 263 of 278 ==16342== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299) ==16342== by 0x5F5CE58: g_malloc (gmem.c:94) ==16342== by 0x5F73D42: g_slice_alloc (gslice.c:1025) ==16342== by 0x5F7436D: g_slice_alloc0 (gslice.c:1051) ==16342== by 0x56DA77A: soup_uri_new_with_base (soup-uri.c:283) ==16342== by 0x56DAA42: soup_uri_new (soup-uri.c:519) ==16342== by 0x4E48BB5: oauth2_proxy_extract_access_token (oauth2-proxy.c:384) ==16342== by 0x400A97: test_url_encoding_access_token (oauth2.c:51) ==16342== by 0x5F7C983: test_case_run (gtestutils.c:2158) ==16342== by 0x5F7C983: g_test_run_suite_internal (gtestutils.c:2241) ==16342== by 0x5F7CB4E: g_test_run_suite_internal (gtestutils.c:2253) ==16342== by 0x5F7CD5D: g_test_run_suite (gtestutils.c:2328) ==16342== by 0x5F7CD80: g_test_run (gtestutils.c:1596) ==16342== by 0x400B64: main (oauth2.c:65)
* xml-node: Use GString in rest_xml_node_print()Christophe Fergeau2016-06-201-9/+12
| | | | | | | | | | | | | | | | | | The current code is using xml = g_strconcat (xml, ...) which is causing some leaks as g_strconcat returns a newly allocated string. Using GString avoids this issue without constantly freeing the intermediate strings. This fixes multiple leaks like: ==16611== 18 bytes in 1 blocks are definitely lost in loss record 124 of 301 ==16611== at 0x4C2BBAD: malloc (vg_replace_malloc.c:299) ==16611== by 0x5F5CE58: g_malloc (gmem.c:94) ==16611== by 0x5F75B8E: g_strconcat (gstrfuncs.c:585) ==16611== by 0x4E450CF: rest_xml_node_print (rest-xml-node.c:287) ==16611== by 0x4E451DA: rest_xml_node_print (rest-xml-node.c:305) ==16611== by 0x4E450F8: rest_xml_node_print (rest-xml-node.c:292) ==16611== by 0x4009A0: main (xml.c:40)
* build: Fix "intospection" typoChristophe Fergeau2016-06-201-1/+1
|
* OAuthProxy: g_free is NULL-safeTimm Bäder2016-06-201-3/+1
|
* RestProxy(Call): Simplify _disposeTimm Bäder2016-06-202-28/+5
|
* RestProxyCall: Use G_DEFINE_TYPE_WITH_PRIVATETimm Bäder2016-06-202-97/+30
|
* rest-proxy: Use G_DEFINE_TYPE_WITH_PRIVATETimm Bäder2016-06-202-29/+16
|
* RestProxyCall: Prevent segfault in prepare_messageTimm Bäder2016-06-201-0/+4
| | | | | soup_form_request_new_from_hash can return NULL, e.g. if the given url is malformed.
* RestProxy: Remove SoupSession[A]sync usageTimm Bäder2016-06-201-29/+2
| | | | | priv->session was a SoupSession since the last commit, which also removed every practical usage or priv->session_sync.
* RestProxyCall: Use GTaskTimm Bäder2016-06-204-228/+37
|
* OAuthProxy: Use GTaskChristophe Fergeau2016-06-202-74/+82
| | | | Based on initial work from Timm Bäder <mail@baedert.org>
* rest-proxy: Port _invoke_async to GTaskTimm Bäder2016-06-202-32/+19
|
* Remove glib-compat.{c,h}Timm Bäder2016-06-164-161/+0
|
* Remove all GLIB_CHECK_VERSION usesTimm Bäder2016-06-162-4/+1
| | | | Where the checked version is < 2.36, which we now require
* oauth-proxy: Remove deprecated APITimm Bäder2016-06-162-118/+0
|
* xml-node: Remove deprecated APITimm Bäder2016-06-162-8/+0
|
* oauth-proxy-call: Remove _parse_token_reponseTimm Bäder2016-06-162-12/+0
| | | | An equivalent _parse_token_response exists that does not contain a typo.
* sha: Use GHmacTimm Bäder2015-10-051-63/+7
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=658725
* oauth: Don't leak temp data in steal_oauth_paramsChristophe Fergeau2015-07-301-0/+1
| | | | | | | | steal_oauth_params() creates a list of strdup'ed strings containing the name of the ouath parameters which should be stolen from the call arguments. However, the code makes sure to free the list, but never frees its content, causing a leak. This commit makes sure the dup'ed strings are freed.
* rest-xml-parser: Ignore text content at the top-level of a documentPhilip Withnall2015-04-141-3/+9
| | | | | | | | This prevents a crash due to cur_node being NULL. Found by scan-build. https://bugzilla.gnome.org/show_bug.cgi?id=719550
* rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authenticationPavel Grunt2015-04-082-0/+18
| | | | | It can be helpful when handling the "authenticate" signal to allow to cancel the authentication instead of failing with an error.
* Don't dump XML parsing errors to stderr/stdout by defaultChristophe Fergeau2015-03-161-0/+10
| | | | These errors should only be shown if REST_DEBUG=xml-parser is set.
* xml-parser: Add missing break in switch statementRob Bradford2014-09-191-0/+1
| | | | | This would result in an inappropriate debug message appearing on valid text data.
* oauth: Add missing includeChristophe Fergeau2014-09-031-0/+1
| | | | This fixes a compilation warning about a missing prototype.
View Lorry Controller Status