summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiří Klimeš <jklimes@redhat.com>2013-10-11 13:24:10 +0200
committerJiří Klimeš <jklimes@redhat.com>2013-10-14 09:56:12 +0200
commit329efc980274a1411c8f582aa9a081ef4d41c723 (patch)
tree71cd632e5316e48412a697636a21aa10ed6d0500
parent6884e176053d1d112ad61b34dd91756c673af114 (diff)
downloadnetwork-manager-applet-329efc980274a1411c8f582aa9a081ef4d41c723.tar.gz
mobile-wizard: fix a potential crash if nm_client_new() return NULL
-rw-r--r--src/libnm-gtk/nm-mobile-wizard.c16
1 files changed, 9 insertions, 7 deletions
diff --git a/src/libnm-gtk/nm-mobile-wizard.c b/src/libnm-gtk/nm-mobile-wizard.c
index 9f586a0d..86f7dddc 100644
--- a/src/libnm-gtk/nm-mobile-wizard.c
+++ b/src/libnm-gtk/nm-mobile-wizard.c
@@ -1260,7 +1260,7 @@ intro_add_initial_devices (NMAMobileWizard *self)
gboolean selected_first = FALSE;
int i;
- devices = nm_client_get_devices (self->client);
+ devices = self->client ? nm_client_get_devices (self->client) : NULL;
for (i = 0; devices && (i < devices->len); i++) {
if (__intro_device_added (self, g_ptr_array_index (devices, i), !selected_first)) {
if (selected_first == FALSE)
@@ -1381,12 +1381,14 @@ intro_setup (NMAMobileWizard *self)
GtkTreeIter iter;
self->client = nm_client_new ();
- g_signal_connect (self->client, "device-added",
- G_CALLBACK (intro_device_added_cb), self);
- g_signal_connect (self->client, "device-removed",
- G_CALLBACK (intro_device_removed_cb), self);
- g_signal_connect (self->client, "notify::manager-running",
- G_CALLBACK (intro_manager_running_cb), self);
+ if (self->client) {
+ g_signal_connect (self->client, "device-added",
+ G_CALLBACK (intro_device_added_cb), self);
+ g_signal_connect (self->client, "device-removed",
+ G_CALLBACK (intro_device_removed_cb), self);
+ g_signal_connect (self->client, "notify::manager-running",
+ G_CALLBACK (intro_manager_running_cb), self);
+ }
self->dev_store = gtk_tree_store_new (3, G_TYPE_STRING, NM_TYPE_DEVICE, G_TYPE_BOOLEAN);
self->dev_combo = gtk_combo_box_new_with_model (GTK_TREE_MODEL (self->dev_store));