| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
|
|
|
| |
These seem to have been forgotten during migration.
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/79
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Applet requires libnma-1.8.28 because "org.gnome.nm-applet.gschema.xml"
moved to libnma.
Now libnma 1.8.28 got released. Explicitly encode the dependency.
Note that it is still inconvenient at this point to bootstrap
and build applet as such.
It is inconvenient if you are on current Fedora 31 with
gnome-control-center. Then, gnome-control-center will require
nm-connection-editor (1.8.24) which will require libnma-1.8.24.
That means, even if you rebuild libnma-1.8.28 RPM, you cannot
install it (because you have no suitable nm-connection-editor
which gnome-control-center requires).
As workaround, build nm-connection-editor first in a build root
without Gnome, only libnma-1.8.28 present.
Still bump the dependency because it's right to do before release
and we will applet 1.16.0 shortly. While inconvenient to boot strap,
it's doable to have libnma-1.8.28 present for building applet.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
libnma-1.8.28
I think a plain shell script makes it easier to implement the build
steps. It's easier to read and to extend.
Also, the gitlab-ci script tried to install libnma from rawhide.
However, while the libnma-1.8.26 package is currently built in koji,
it is still (for some reasons) not available for installation. The
build step would still install libnma-1.8.24 (which was still bundled
with applet). Aside that, there are currently other issues in rawhide
that prevent this from working.
This only worked accidentally, because the network-manager-applet build
does not yet explicitly require a new libnma package. However, in practice
it does already, because when building against libnma-2.8.24, the
"org.gnome.nm-applet.gschema.xml" is missing. Next we are going to explicitly
require libnma-1.8.28, so this wouldn't work anymore.
Instead I did a scratch build of libnma-1.8.28 in koji. Adjust the
build steps and install the package. This is a temporary solution,
that helps to boot strap the update to an unbundled libnma-1.8.28.
|
| |
|
| |
|
| |
|
|
|
|
| |
These macros belong to libnma and no longer to applet.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the split of libnma to a new repository, we also moved the
"org.gnome.nm-applet.gschema.xml" file. For that (and maybe other
reasons), we really need to build master of applet against latest
libnma (1.8.28).
However, libnma is not yet widely packaged, so for development and testing
this is rather inconvenient. Relax the requirement to allow building against
older libnma.
This patch should eventually be reverted.
|
|
|
|
| |
Fixes: 9674424fbe3d ('build: use NMA_VERSION_MIN_REQUIRED/NMA_VERSION_MAX_ALLOWED macros')
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For applet, we (usually) don't maintain stable branches upstream. Nor
did the versioning scheme so far (with 3 numbers) give space for
that.
Up to now, the first two numbers (1.8) indicate the minimum required
libnm version API. There is no particular good reason to do (or not
to do) that. It worked reasonably well.
However, let's change our versioning scheme. For one, we only seldom
bump the required libnm version, so expressing it in the version
number of applet is not spectacular. Also, we have other important
libraries too (gtk3/gtk4, libnma-1.8.27). It's not clear that libnm's
version number is more relevant than the one of other libraries,
or why applet's version number should follow libnm's version number.
Start a new versioning scheme with the next release. The next release
will be 1.16.0 (still to reflect that we now require libnm 1.16.0).
Also, future (major) releases will bump the second version number. Basically,
we will adopt the same versioning scheme as NetworkManager, and their
versions will move independently.
Note that we are still in a development, pre-release version for 1.16.0.
Hence, bump the version to 1.15.0.
|
|
|
|
|
| |
NetworkManager 1.16.0 was released in March 2019. It introduces WireGuard
support, and as we soon will use that API, require it.
|
|
|
|
|
| |
This probably should be fixed by somebody giving love to
"page-mobile.c". For now, just ignore the deprecation warning.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
info_dialog_add_page()
It's a false positive. Avoid it.
../src/applet-dialogs.c: In function applet_info_dialog_show:
../src/applet-dialogs.c:709:21: warning: ip6_config may be used uninitialized in this function [-Wmaybe-uninitialized]
709 | dns6 = def6_addr ? nm_ip_config_get_nameservers (ip6_config) : NULL;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/applet-dialogs.c:481:14: note: ip6_config was declared here
481 | NMIPConfig *ip6_config;
| ^~~~~~~~~~
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to libnma
The schema is also used by libnma's "src/nma-ws/nma-eap.c" (formerly
"src/wireless-security/eap-method.c") and g-c-c's
"panels/network/wireless-security/eap-method.c".
That means, despite the name of the schema, it really belongs to libnma.
Move it to libnma ([1]).
[1] https://gitlab.gnome.org/GNOME/libnma/-/commit/50cda26ae4beab31f30fb93fd36a7bcc5435adc1
See-also: https://gitlab.gnome.org/GNOME/gnome-control-center/issues/881
See-also: https://gitlab.gnome.org/GNOME/libnma/-/merge_requests/11
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the COPYING file from NetworkManager ([1]). It's basically
the same. The difference are some only punctuation, white space and
it refers to "Lesser" GPL (LGPL-2.1) instead of "Library" GPL (LGPL-2.0).
I think it's preferable to have the exact same license text in
network-manager-applet as in NetworkManager.
Also, this version is exactly the same we get from the GNU site ([2])
as of today.
The same was done for libnma ([3]).
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/3ceb7bf099b61224290c036f19187c9c327ece84/COPYING
[2] https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
[3] https://gitlab.gnome.org/GNOME/libnma/-/merge_requests/10
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't pass a floating variant to the callback function but convert it
into a full one so that we can guarantee that the callback function
will not assume ownership.
(nm-applet:691510): GLib-CRITICAL **: 18:02:29.581: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed
_g_log_abort () at /lib64/libglib-2.0.so.0
g_logv () at /lib64/libglib-2.0.so.0
g_log () at /lib64/libglib-2.0.so.0
g_atomic_ref_count_dec () at /lib64/libglib-2.0.so.0
g_variant_unref () at /lib64/libglib-2.0.so.0
gs_local_variant_unref (v=<synthetic pointer>) at ./shared/nm-utils/gsystem-local-alloc.h:73
complete_request (info=info@entry=0xaaf340) at src/applet-vpn-request.c:273
external_ui_from_child_response (error=0x7fffffffd380, info=<optimized out>) at src/applet-vpn-request.c:261
process_child_response (info=<optimized out>) at src/applet-vpn-request.c:298
g_child_watch_dispatch () at /lib64/libglib-2.0.so.0
g_main_context_dispatch () at /lib64/libglib-2.0.so.0
...
https://gitlab.gnome.org/GNOME/network-manager-applet/-/merge_requests/77
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
[thaller@redhat.com: cherry-picked this patch from a larger
merge request and trivial conflict resolution]
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/73
|
|\
| |
| |
| | |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/75
|
| |
| |
| |
| |
| |
| |
| |
| | |
Fix ce-ppp-auth-methods.ui as well per Mikhail's comment
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/75#note_685501
Fixes: 5fbf69f2e21c ('glade: get rid of GtkContainer.border-width')
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a transparent border issue that appears to have been introduced
with commit 5fbf69f2:
With commit 5fbf69f2, ipv4/ipv6 route and new connection dialog boxes
were modified to use margin properties due to the deprecation of border
properties. Margin properties were placed under GtkDialog instead of the
immediate child GtkBox. Margin properties were also placed under another
GtkBox further below. This seemed to have the effect of margins not
being recognized on the top or left of the dialogs, but also creating a
transparent margin on the bottom and right. This was visible on the
ipv4/ipv6 route dialogs, but somehow also affected the new connection
dialog despite that file not having margin properties listed under
GtkDialog. Fixing properties in ce-ip4-routes.ui and ce-ip6-routes.ui
also fixed the new connection dialog.
Fixes: 5fbf69f2e21c ('glade: get rid of GtkContainer.border-width')
|
|\
| |
| |
| | |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/72
|
| |
| |
| |
| |
| |
| | |
It looks more C-like and does does not compile code conditionally (while
the compiler still sees when compiled without appindicator support and
can strip the unreachable code).
|
| | |
|
|/
|
|
|
|
|
| |
This converts menu items from GdkPixbuf to a correctly scaled
cairo_surface_t so that it can render properly on HiDPI displays. This
change only applies to the GtkStatusIcon version of nm-applet, since
appindicator icon-data is currently set to handle GdkPixbuf.
|
|
|
|
|
|
| |
Fixes: dc9ee4e1129c ('applet: scale icons for HiDPI displays')
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/74
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The description is not filled in. We can't merge this with the NEWS file
because this pertains only to the editor.
There's no machinery to automatically check this yet. Just the bare
minimum to keep the new version of appdata-util happy.
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/67
|
|
|
|
|
|
|
|
|
|
| |
There's no content that would be ranked objectionable by OARS unless you're
the sort of person that likes to put nudity, religious violence and
adultery into your connections. That's none of our business though.
The new version of appdata-util insists on this tag being around.
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/67
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/71
|
| |
|
| |
|
| |
|
|\
| |
| |
| | |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/70
|