| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Previously the secondary field would be focused even if the first was
empty.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a connection is opened for editing in nm-c-e, secrets are asked
to NM. NM in turn asks them to registered agents, including the applet
if available; the applet now supports an external-ui-mode in which it
spawns a VPN-specific authentication dialog binary that doesn't have a
graphical component and contains the knowledge about which secrets are
missing, how to retrieve them from keyrings and how to ask them to
users; the binary then returns through stdout a keyfile that describes
the known secrets, their values returned from keyrings and the labels
to present to users. The applet uses this information to show a GTK
dialog (only when necessary) and returns the secrets to NM.
Currently when using the external-ui-mode and the auth-dialog binary
returns secrets with the ShouldAsk key set to false, the applet
doesn't show a GTK dialog and returns an empty response. This breaks
when the auth-dialog returns secrets from keyrings as they are
dropped.
This commit changes the handling of secrets in external-ui-mode: now
we first build a list of known secrets and, if necessary, populate the
dialog with the ones that must be asked. After the dialog quits we
update the secret values in the list from the dialog and return all
secrets, including ones not asked.
https://gitlab.gnome.org/GNOME/network-manager-applet/issues/59
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/193
Fixes: bce8d0a75c1d ("applet/vpn-request: add external UI mode")
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/network-manager-applet/issues/71
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the following warning:
"Failed to set text 'ab&cd' from markup due to error parsing markup:
Error on line 1: Entity did not end with a semicolon; most likely you
used an ampersand character without intending to start an entity —
escape ampersand as &"
Don't first enable markup (with the old label) and then set the text;
do both with one call to gtk_label_set_markup().
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/244
|
|
|
|
|
|
|
| |
Without gtk_widget_show_all() the popup menu for password flags is
displayed empty when using GTK3.
Fixes: 2ded57d949db ("utils: support GTK4")
|
|
|
|
|
|
|
|
| |
It was added in meson 0.50 while we require 0.46. Furthermore it
defaults to true when a install directory is specified and so it can
be omitted.
https://gitlab.gnome.org/GNOME/network-manager-applet/issues/70
|
|\
| |
| |
| |
| |
| | |
Uh, huh, let's see how well this flies.
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/38
|
| |
| |
| |
| |
| |
| | |
This is not perfect yet, but as of gtk4-3.96.0 none of the test programs
crash, which is a good starting point i guess. Improvements should go to
gtk4-builder-tool.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is EXPERIMENTAL EXPERIMENTAL EXPERIMENTAL. GTK4 is not released yet
and things will change in incompatible ways.
A new library called "libnma-gtk4" is added. The non-libnma parts
(applet, editor) are not ported.
There are few reasons for merging this early and none of them is
shipping the library to the users at this point:
* To allow bringup of GTK4-enabled VPN plugins
* Do not block GTK4 enablement of GNOME Control Center
* Help avoid using features that will be difficult to port from GTK3
All the test programs work, they emit a fair amount of warnings about
properties that were removed in GTK4. To deal with those, we'd need to
build different GResources for GTK3 and GTK4. The differencies seem
small enough to the point the conversion could be automated. TODO,
doesn't block testing.
Tested to build with gtk+-4.0 = 3.94.0, but even the pkg-config name
changed since in GTK4 git master. Did I say this is EXPERIMENTAL and
there will be incompatible changes?
|
| |
| |
| |
| | |
Cover a trivial difference with an ifdef.
|
| |
| |
| |
| | |
Just paint over the differencies with a few ifdefs.
|
| |
| |
| |
| |
| | |
It's going away in Gtk4. We don't do show_all() anyway -- just hide the
widgets by default.
|
| |
| |
| |
| | |
Essentially to get the thing to compile for now.
|
| |
| |
| |
| |
| | |
Replaces Gtk4's gtk_window_activate_default. This probably deserves a
better solution, but it will have to do for now.
|
| |
| |
| |
| |
| |
| | |
There's no no-show-all in GTK4. Using it in GTK3 is perhaps also a bad
idea, but we can't change that now without potentially breaking things
at this point.
|
| | |
|
|/
|
|
|
| |
Some calls were moved to GtkEditable. Call the new variants, while
providing a compatibility wrappers for the GTK3 versions.
|
|
|
|
|
|
| |
NetworkManager 1.20 introduced the 'disabled' IPv6 method. Support it.
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/59
|
|
|
|
|
|
| |
Now that NM supports ad-hoc WPA2 connections, enable them in the applet.
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/58
|
|
|
|
|
|
|
| |
If the outermost widget has margins, they end up as transparent or black shadow
artifacts of the window.
https://gitlab.gnome.org/GNOME/network-manager-applet/issues/41
|
|
|
|
| |
They're a waste of electrons.
|
|
|
|
| |
Makes licensing audits easier.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/57
|
| |
|
| |
|
|\
| |
| |
| | |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/54
|
| | |
|
| |
| |
| |
| | |
https://bugzilla.redhat.com/show_bug.cgi?id=1712291
|
| |
| |
| |
| | |
https://bugzilla.redhat.com/show_bug.cgi?id=1709431
|
|/ |
|
|\
| |
| |
| |
| | |
https://bugzilla.redhat.com/show_bug.cgi?id=1543958
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/55
|
| |
| |
| |
| |
| |
| |
| | |
The callback was called multiple times for a single removal because it
was registered multiple times.
Fixes: 4d7546e7d0e56c3a102a12ba03695eac6f8109f8
|
|/
|
|
|
|
|
|
|
|
|
| |
When a connection is added the editor adds a new empty item to the
tree store with gtk_tree_store_append() and then populates
it. Therefore, has_visible_children() must be prepared to deal with
missing values.
Fixes: 4645c9ae9dd6edd41f9cae48f2de26b39f884795
https://bugzilla.redhat.com/show_bug.cgi?id=1543958
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This was a misunderstanding of what it does on my part.
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/51
|