summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* applet: fix some visual ugliness and ensure available connections show in ↵dcbw/indicator-cleanupsDan Williams2016-03-171-18/+20
| | | | | | | | indicator mode Remove the separator after the active connection, and put a new separator between devices. Also ensure that connection items show themselves, otherwise they don't get picked up by dbusmenu-gtk.
* applet: add --indicator to switch between indicator and status icon at runtimeDan Williams2016-03-172-12/+21
|
* applet: allow indicator and status icon to be built togetherDan Williams2016-03-173-153/+140
|
* applet: build (but disable) notifications code for indicator tooDan Williams2016-03-172-32/+32
|
* applet: don't use GtkImageMenuItems (bgo #740574)Dan Williams2016-03-155-54/+9
| | | | | | | | | GtkImageMenuItems are deprecated and we shouldn't use them anymore. So don't; appindicator/dbusmenu can handle GtkImages in normal GtkMenuItems now with the 16.04.0 release. appindicator/dbusmenu also strips Pango markup so we can remove the conditionals around label text.
* applet: use fewer deprecated GtkImageMenuItems (bgo #740574)Dan Williams2016-03-151-28/+21
| | | | | | | | | | | | | GtkImageMenuItem is deprecated and we should use fewer of them. Most GTK-based desktop environments seem to have stopped showing icons in menus by default anyway. This will allow us to simplify the code for both the regular applet and the appindictor version. So: 1) remove the stock icons from the static menu items so they won't be displayed 2) override gtk-menu-images to TRUE for later appindicator changes, since we actually want our custom menu item images displayed, just not the stock ones (that we just removed anyway)
* applet: appindicator/dbusmenu can deal just fine with Pango markupDan Williams2016-03-151-2/+0
|
* Updated Finnish translationJiri Grönroos2016-03-131-660/+692
|
* applet: merge branch 'th/applet-icon'Thomas Haller2016-03-137-85/+182
|\ | | | | | | | | | | When compiling with --with-appindicator, I got a lot of criticals due to missing icons. First, ensure we call nm_icons_reload() as needed. Then, better cope with errors loading icons.
| * applet: anticipate nma_icon_check_and_load() returning no iconThomas Haller2016-03-134-57/+63
| | | | | | | | | | | | | | | | | | | | | | nma_icon_check_and_load() uses the fallback_icon when it fails to load the icon. Probably a fallback_icon should be always present. But nma_icons_reload() goes through some lengths to cope with an error creating the fallback_icon. So, either we assert that the fallback_icon is always present, or users of nma_icon_check_and_load() must cope with a NULL icon. Do the latter.
| * applet: also cache absent icon in nma_icon_check_and_load()Thomas Haller2016-03-131-5/+3
| | | | | | | | This way, we only log a warning about a missing icon once.
| * applet: create fallback_icon only once in nma_icons_reload()Thomas Haller2016-03-131-2/+4
| |
| * applet: ensure to load icons in nma_icons_init()Thomas Haller2016-03-131-1/+2
| |
| * shared: update shared files from NetworkManagerThomas Haller2016-03-133-21/+111
|/ | | | To get nm_g_object_unref().
* info-dialog: don't try to process ipv4 settings where there are noneLubomir Rintel2016-03-111-5/+16
| | | | Who uses IPv4 anyway?
* (lt-nm-applet:25513): GLib-CRITICAL **: Source ID 217 was not found when ↵Lubomir Rintel2016-03-111-2/+3
| | | | | | | | | | | attempting to remove it Program received signal SIGTRAP, Trace/breakpoint trap. 0x00007ffff316081b in _g_log_abort (breakpoint=1) at gmessages.c:324 324 G_BREAKPOINT (); Missing separate debuginfos, use: dnf debuginfo-install dbus-glib-0.106-1.fc23.x86_64 GConf2-3.2.6-15.fc23.x86_64 libgcc-5.3.1-2.fc23.x86_64 (gdb) bt (gdb)
* Updated Occitan translationCédric Valmary2016-03-101-1224/+1637
|
* all: remove last dbus-glib bitsLubomir Rintel2016-03-085-10/+2
|
* gitignore: ignore some test artifactsThomas Haller2016-03-081-0/+4
|
* applet: fix tracking of active access-pointThomas Haller2016-03-081-31/+155
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Caught the following valgrind error on network-manager-applet-1.2.0-0.3.beta1.fc24: == Invalid read of size 8 == at 0x822471D: g_type_check_instance (gtype.c:4137) == by 0x8218B63: g_signal_handlers_disconnect_matched (gsignal.c:2925) == by 0x129B3D: update_active_ap (applet-device-wifi.c:1195) == by 0x129C92: wifi_device_state_changed (applet-device-wifi.c:1219) == by 0x11C96E: foo_device_state_changed_cb (applet.c:2308) == by 0xF2FCC57: ffi_call_unix64 (in /usr/lib64/libffi.so.6.0.2) == by 0xF2FC6B9: ffi_call (in /usr/lib64/libffi.so.6.0.2) == by 0x81FF279: g_cclosure_marshal_generic_va (gclosure.c:1604) == by 0x81FE7A6: _g_closure_invoke_va (gclosure.c:867) == by 0x821A1D7: g_signal_emit_valist (gsignal.c:3294) == by 0x821A82E: g_signal_emit (gsignal.c:3441) == by 0x7ED59DC: g_simple_async_result_complete (gsimpleasyncresult.c:801) This happens, because we hookup the access-point at the device, without taking any strong references or otherwise ensuring proper lifetime handling. Fix that, by registering a weak-ref to the access-point, so that we notice when the access-point gets destroyed. Note that we don't want to take strong references, because neither device, access-point nor applet should keep each other alive only because of an active access-point. Also, instead of registering the access-point at the device, register it at the applet. In principle there could be multiple applet instances and it is wrong that they all try to register the access-point on the same device. https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00039.html
* wireless-security: fix some error handlingLubomir Rintel2016-03-081-1/+1
| | | | | | CID 59915 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: g_set_error_literal(error, ....
* wifi: remove some dead codeLubomir Rintel2016-03-081-2/+2
| | | | | | | | The world is a better place now. CID 59916 (#1 of 2): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach the expression "" inside this statement: if (!strcmp((band ? band : ....
* wifi: add a comment to make coverity happyLubomir Rintel2016-03-081-0/+1
| | | | | | CID 59917 (#1 of 1): Missing break in switch (MISSING_BREAK) unterminated_case: The case for value 1 is not terminated by a 'break' statement.
* wep: fix a couple of potential buffer overflowsLubomir Rintel2016-03-082-3/+4
| | | | | | | | | | | | | | | | | | | | Coverity thinks we're no good at string manipulation. Can't argue with that. (Not a security issue; the user could overflow the buffer by typing a too long WEP key, but no privilege boundary is crossed.) CID 59920 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 2. fixed_size_dest: You might overrun the 65 byte fixed-size string sec->keys[sec->cur_index] by copying key without checking the length. CID 59919 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 1. fixed_size_dest: You might overrun the 65 byte fixed-size string sec->keys[sec->cur_index] by copying key without checking the length. CID 59918 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 4. fixed_size_dest: You might overrun the 65 byte fixed-size string sec->keys[i] by copying tmp without checking the length.
* applet: refactor handling string allocations in applet_update_icon()Thomas Haller2016-03-071-21/+26
|
* applet: fix leaking icon_name in foo_set_icon()Thomas Haller2016-03-071-2/+2
|
* applet: add some assertions to get_icon() functionsThomas Haller2016-03-075-1/+16
|
* applet: fix leak in ethernet_get_icon()Thomas Haller2016-03-071-1/+1
|
* Updated Hungarian translationGábor Kelemen2016-03-051-634/+645
|
* applet: workaround crash in applet codeThomas Haller2016-03-041-4/+5
| | | | | | | | | rh#1313866 and rh#1314650 show a crash due to "g_assert (s_con)". It's unclear how this can happen, but for now downgrade the crash to a warning. https://bugzilla.redhat.com/show_bug.cgi?id=1313866 https://bugzilla.redhat.com/show_bug.cgi?id=1314650
* build: add our own version of the introspection.m4 macroThomas Haller2016-03-041-0/+96
| | | | | | | | | | | | | | When buiding with "CFLAGS=-O0 -Werror", introspection.m4 passes those flags to the compiler, which then get mixed with the system-provided flags "-D_FORTIFY_SOURCE=2". Which in turn causes a fatal warning. $ export CFLAGS=-O0; ./autogen.sh --enable-more-warnings=error && make Workaround that, by injecting "-Wno-error" to the CFLAGS, like we do for NetworkManager (commit f6272144e98c00db18cf6708aceab96e6e7b1705). Related: https://bugzilla.gnome.org/show_bug.cgi?id=757934
* connection-editor: remove unused variableThomas Haller2016-03-041-1/+1
|
* libnm-gtk/tests: don't check for translated valueThomas Haller2016-03-021-1/+1
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=762950
* tests: run tests on "make check"Michael Biebl2016-03-022-2/+2
| | | | | | Fixes: aa69f9c7cd441e1b091bf4c400182b27b0fb8314 https://bugzilla.gnome.org/show_bug.cgi?id=762944
* release: bump version to 1.1.91 (1.2-beta2)1.2-beta2Beniamino Galvani2016-03-011-1/+1
|
* release: update NEWSBeniamino Galvani2016-03-011-1/+1
|
* applet: merge branch 'th/applet-icon-crash-bgo762421'Thomas Haller2016-02-291-50/+42
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=762421
| * applet: avoid setting negative icon-size for appletth/applet-icon-crash-bgo762421Thomas Haller2016-02-291-1/+6
| | | | | | | | | | | | | | | | Seems we can hit (nm-applet:4985): nm-applet-CRITICAL **: nma_icons_reload: assertion 'applet->isize > 0' failed which can only happen if the icon-size reported by "size-changed" is negative. Avoid that.
| * applet: cleanup nma_icons_reload() and fix leakThomas Haller2016-02-241-12/+9
| | | | | | | | | | | | | | | | | | | | - adjust the signature of nma_icons_reload() to the "changed" signal of GtkIconTheme. - don't return TRUE or FALSE depending on success (note that we already asserted that FALSE must not happen). Instead, log a warning with g_critical(), which is more graceful. - free @fallback_icon, avoiding leaking the icon on multiple invocations.
| * applet: fix crash due to wrongly handling references for iconsThomas Haller2016-02-241-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | nma_icon_check_and_load() would not take an additional reference for the @fallback_icon. Note that nma_icons_free() would not unref the icon if it equals the fallback_icon, but destroying @icon_cache would. So, during finalize() we hit the bug, but also when nma_icons_reload() replaces @fallback_icon. https://bugzilla.gnome.org/show_bug.cgi?id=762421 https://bugzilla.redhat.com/show_bug.cgi?id=1284671 https://bugzilla.redhat.com/show_bug.cgi?id=1279937
| * applet: refactor handling @pixbuf in foo_set_icon()Thomas Haller2016-02-241-7/+10
| |
| * applet: don't check for non-null @errorThomas Haller2016-02-241-9/+6
| | | | | | | | ... and some whitespace.
| * applet: fix leaking @loader in nma_icons_reload()Thomas Haller2016-02-241-2/+1
| |
| * applet: minor refactoring and drop nma_clear_icon()Thomas Haller2016-02-241-18/+10
|/
* all: merge branch 'th/include-nm-default'Thomas Haller2016-02-2478-484/+21
|\ | | | | | | Cleanup includes.
| * all: include <gtk/gtk.h> via "nm-default.h"Thomas Haller2016-02-2443-81/+7
| |
| * all: include <glib.h> via "nm-default.h"Thomas Haller2016-02-2410-17/+0
| |
| * all: include <glib/gi18n-lib.h> via "nm-default.h"Thomas Haller2016-02-2412-15/+0
| |
| * all: include <glib/gi18n.h> via "nm-default.h"Thomas Haller2016-02-2456-58/+0
| |
| * all: include "config.h" via "nm-default.h"Thomas Haller2016-02-2475-147/+7
| | | | | | | | | | | | Every internal source file should include "nm-default.h" as first. Therefore, also include "nm-config.h" via the default header.
View Lorry Controller Status