summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* utils: move *_password_storage() functions to utilsjk/rh879566-secret-flagsJiří Klimeš2013-12-0410-190/+199
| | | | Thus they can also be used on other places, like VPN plugins.
* wireless-security: use different icons for user and system password storagesJiří Klimeš2013-12-041-3/+28
|
* trivial: rename new_connection to editing_connectionJiří Klimeš2013-12-046-22/+24
| | | | | Because it is actually not a new connection, rather it denotes that we edit the connection as opposed to just providing password(s).
* editor: store secrets by default only for current user (rh #879566)Jiří Klimeš2013-12-0414-87/+286
| | | | | | | | | | | | | | | | | | | | | | | | Storing secrets system-wide can be a security breach. Because such a secret is available to all users on the system. So we default to NM_SETTING_SECRET_FLAG_AGENT_OWNED flag for all passwords, regardless whether the connection profile itself is available to all users or not. And we add a popup menu for password entries that allows users to override password storage. This is useful e.g. for the case when a user (admin) needs the connection profile to be usable at boot time. There and two pieces of data to store: profile storage/availability - it is influenced with "Available to all users" secret storage/availability - it is influenced with secret flags This commit decouples these two things, so that they are independent now. Test case: Alice creates a connection profile for her WPA Wi-Fi access point. When she logouts, Bobs comes in, logs into his own account and he is able to connect to Alice's AP, because the profile contains the password, and it is available for Bob (and all users). https://bugzilla.redhat.com/show_bug.cgi?id=879566
* trivial: correct a warning messageJiří Klimeš2013-11-181-1/+1
|
* Revert "libnm-gtk: default to system CA certificates for validation for new ↵Thomas Haller2013-11-153-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | connections" This reverts commit 3021ce121b162fc69ec2fd800776a5dd28d72042. For EAP connections it usually does not make sense to validate the certificate with the system CA store. User mostly either want to provide the one exact certificate (ca-cert) or don't do any validation at all. Previously, nm-connection-editor set the property system-ca-certs=true for new connections, but there was no field in the UI to unset this setting. This effectively meant, that if the user did not provide a valid ca-cert (or put the certificate in the system wide store) the connection could not be established. Change the behavior, so that new connections created by nm-c-e don't have system-ca-certs set. The system-ca-certs property cannot be configured from the UI and nm-c-e will not touch it in existing connection. This makes sense, because referring to the system store is not a common use case. On the other hand, users who *really* want to use this option, can do so using e.g. nmcli. In that case, nm-c-e will not tamper with the setting. Connections that were created by older versions of nm-c-e might be unable to connect. The system-ca-certs option can be unset with: $ nmcli connection modify id "$ID" 802-1x.system-ca-certs false https://bugzilla.gnome.org/show_bug.cgi?id=702608 Signed-off-by: Thomas Haller <thaller@redhat.com>
* coverity: fix warnings found with Coverity in nm-applet/nm-c-eJiří Klimeš2013-11-1513-32/+26
| | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1025894#c3 Signed-off-by: Thomas Haller <thaller@redhat.com>
* Updated Greek translationDimitris Spingos2013-11-141-455/+760
|
* Updated Polish translationPiotr Drąg2013-11-071-24/+43
|
* Updated Spanish translationDaniel Mustieles2013-11-061-363/+513
|
* connection-editor: improve handling of NPAR/SR-IOV devices (rh #804527)Dan Winship2013-11-066-6/+122
| | | | | Warn the user when a bond or team connection contains multiple slaves on the same physical port.
* connection-editor: fix a signal callback signatureDan Winship2013-11-061-2/+1
|
* Updated Galician translationsFran Diéguez2013-11-011-320/+432
|
* applet: remove wrong assert in eap_method_ca_cert_not_required_toggledThomas Haller2013-10-295-15/+6
| | | | | | | | | | | | | With the previous commit, the "Connect" button in the "Connect to Hidden Network" is disabled, if the EAP connection does not validate. Before, the user was able to click on the "Connect" button and the assert in eap_method_ca_cert_not_required_toggled failed. Still, the assert is too strict, so remove it. Also fix an invalid warning in eap-method-tls.c Signed-off-by: Thomas Haller <thaller@redhat.com>
* applet: initialize ca_cert_ignore checkbox for "Connect to Hidden"Thomas Haller2013-10-291-0/+3
| | | | | | | | | | | | | | | When opening the "Connect to Hidden Network" dialog for a connection without CA authority, the ca_cert_ignore checkbox was not properly loaded and always stayed unchecked. With this change, EAP connections without ca_cert_ignore flag will be validate as erroneous and the "Connect" button in the "Connect to Hidden Network" dialog stays disabled. Previously, the behaviour was indeterministic, and also it might trigger an assert in eap_method_ca_cert_not_required_toggled. Signed-off-by: Thomas Haller <thaller@redhat.com>
* nm-applet: change logging to use g_debugDan Winship2013-10-282-8/+12
| | | | | | | and define a log domain so you can use G_MESSAGES_DEBUG=nm-applet to enable them. https://bugzilla.gnome.org/show_bug.cgi?id=709419
* applet: redo the gnome-shell interaction codeDan Winship2013-10-283-75/+31
| | | | | | | | | | | | Change the shell interaction code so that we only create an NMSecretAgent if the shell is not running, and we permanently destroy it if the shell ever starts up. Revert the change to not run nm-applet under GNOME 3 now, since it should be safe to do so, and this solves the problem for users who need the GSM PIN unlock dialog. https://bugzilla.gnome.org/show_bug.cgi?id=709419
* Updated Polish translationPiotr Drąg2013-10-241-14/+18
|
* editor: allow creating master bridge connections without slaves (rh #700948)Jiří Klimeš2013-10-243-5/+10
| | | | | | Such bridges are useful e.g. for virtualization. https://bugzilla.gnome.org/show_bug.cgi?id=700948
* Implement EAP-PWD supportjvoisin2013-10-223-0/+17
|
* mobile-wizard: fix a potential crash if nm_client_new() return NULLJiří Klimeš2013-10-141-7/+9
|
* Updated Polish translationPiotr Drąg2013-10-121-133/+211
|
* editor: make Team config importing dialog modal and set parent window for itJiří Klimeš2013-10-112-79/+75
| | | | | | | | | Else the user could close the connection window and the dialog still referring to it would make the editor crash. Top level window fixed up by dcbw: The widget may not be in a window at page init time, but is when the widget is realized. Get the toplevel parent at realize time.
* Tajik translation updatedVictor Ibragimov2013-10-091-788/+656
|
* editor: do not gtk_widget_destroy() dialog on "close" signalJiří Klimeš2013-10-081-9/+0
| | | | | | | | "response" signal is sufficient. It is issued for dialog closing too (Cancel, Esc, Alt-F4, ...). Trying to destroy dialog as a response to "close" signal caused: GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT (object)' failed
* Updated POTFILES.inPiotr Drąg2013-10-071-0/+5
|
* team: merge a branch adding support for Team to applet/editor (bgo #708245)Jiří Klimeš2013-10-0716-2/+1243
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=708245
| * editor: only allow adding compatible slaves to master Team connectionJiří Klimeš2013-10-071-6/+61
| | | | | | | | | | | | Compatible slaves: - InfiniBand - ethernet, Wi-Fi, VLAN
| * editor: change JSON Team/TeamPort config widget from GEntry to GTextViewJiří Klimeš2013-10-074-41/+220
| | | | | | | | | | | | | | | | | | | | and allow importing the config from a file. libteam configuration is a string that can be quite long, and simple GEntry is not much appropriate for it. This commit uses GTextView instead, so that structured multiline JSON config can be typed. In addition to that, the import button allows selecting a file whose content will be imported as the config text.
| * team: make algorithm for choosing new team_num deterministicThomas Haller2013-10-071-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous algorithm for choosing the team_num is not deterministic. It does neither choose one of (a) MAX(existing team_nums) + 1 (b) MIN(unused team_nums) What it actually chooses depends on the order how the existing connections are returned. For example: [0 2] => 1 [2 0] => 3 Change it to use (a). Signed-off-by: Thomas Haller <thaller@redhat.com>
| * libnm-gtk: recognize Team as a valid virtual deviceJiří Klimeš2013-10-071-0/+5
| |
| * editor: use unambiguous mnemonic kyes for Team and TeamPort pagesJiří Klimeš2013-10-072-3/+3
| |
| * add support for team devicesJiri Pirko2013-10-0715-2/+1006
|/ | | | Signed-off-by: Jiri Pirko <jiri@resnulli.us>
* l10n: Update Japanese translationHajime Taira2013-10-081-170/+141
|
* Updated Polish translationPiotr Drąg2013-10-041-71/+80
|
* editor: extend tooltip for IPv6 DNS servers in ce-page-ip6 (scope of link-local)Thomas Haller2013-10-041-1/+1
| | | | | | | | | | The user cannot input a %scope-id in this field because this parameter would be ignored anyway. NetworkManager automatically scopes link-local addresses to the connecting device. https://bugzilla.redhat.com/show_bug.cgi?id=962449 Signed-off-by: Thomas Haller <thaller@redhat.com>
* editor: disallow unexpected characters for DNS serversThomas Haller2013-10-042-0/+47
| | | | | | | | | | | | | | | Do not allow to input unexpected (ascii) characters as DNS servers, both for IPv4 and IPv6. This especially disallows to add a %scope-id suffix for IPv6 link-local addresses (because '%' is not allowed). The reason to disallow this is that link-local addresses are always scoped to the connecting device anyway, so this parameter would get ignored anyway. This is related to bug https://bugzilla.redhat.com/show_bug.cgi?id=962449 Signed-off-by: Thomas Haller <thaller@redhat.com>
* editor: refactor filtering of characters for GtkEntryThomas Haller2013-10-0410-294/+210
| | | | | | | | | | | | | | | | | | | | | | Some GtkEntry only allow certain characters. This code was duplicated over several places. Refactor them and add a function utils_filter_editable_on_insert_text to implement the filtering. This also fixes some minor hitches: - at some places, the is<type> functions from ctype.h were used. These functions behave differently depending on the locale, but we ~really~ want to check for ASCII characters (in the UTF-8) string. - at several places, the allocated memory for `result` did not include the terminating zero caracter. This was not a real bug, because gtk_editable_insert_text was called with the `count` parameter and nowhere the terminating zero was actually needed. - adjust the signature of the *_filter_cb functions to the insert-text signal. Signed-off-by: Thomas Haller <thaller@redhat.com>
* editor: fix mem leak when calling gtk_editable_get_charsThomas Haller2013-09-274-10/+10
| | | | | | | The return value of gtk_editable_get_chars is owned by the caller, so calling g_strdup leaks memory. Signed-off-by: Thomas Haller <thaller@redhat.com>
* Updated Polish translationPiotr Drąg2013-09-271-13/+25
|
* connection-editor: add bond "primary" optionDan Winship2013-09-272-20/+103
|
* Updated Hungarian translationBalázs Úr2013-09-221-149/+156
|
* l10n: Update Japanese translationJiro Matsuzawa2013-09-221-710/+855
|
* nma-bt-device: fix creation of BT settings when creating connectionThomas Haller2013-09-191-2/+2
| | | | | | | Due to a typo, the created setting contained wrong fields for IP4 and IP6. Signed-off-by: Thomas Haller <thaller@redhat.com>
* editor: make algorithm for choosing num for bond and bridge deterministicThomas Haller2013-09-182-12/+6
| | | | | | | | | | | | | | | | | The previous algorithm for choosing bond_num/bridge_num is not deterministic. It does neither choose one of (a) MAX(existing nums) + 1 (b) MIN(unused nums) What it actually chooses depends on the order how the existing connections are returned. For example: [0 2] => 1 [2 0] => 3 This commit changes the algorithm to use (a). Signed-off-by: Thomas Haller <thaller@redhat.com>
* editor: don't use 'wep40 'wep104' values for pairwise (rh #1005171)Jiří Klimeš2013-09-181-5/+0
| | | | | | | The values were removed from the allowed 'pairwise' property values by 5f61594585b22cdb72ee5279de5a8d9e86b125cf commit. Anyway, both 'pairwise' and 'group' property (ciphers) are only valid for WPA.
* Updated Danish translationAsk H. Larsen2013-09-171-427/+570
|
* eap: use G_DEFINE_BOXED_TYPE to simplify code and be thread-safe (rh #979123)Jiří Klimeš2013-09-139-34/+10
| | | | | | | | | | | | | | | | | | | | | | | | inner_auth_combo_changed_cb(): model = gtk_combo_box_get_model (GTK_COMBO_BOX (combo)); gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter); gtk_tree_model_get (model, &iter, I_METHOD_COLUMN, &eap, -1); g_assert (eap); gtk_combo_box_get_model() failed and thus g_assert (eap) failed as well. On some circumstances type_id resets to 0 in eap_method_get_g_type(). It makes g_boxed_type_register_static() be called again, which results in failing assertion 'g_type_form_name (name) == 0' and thus eap_method_get_g_type() returns 0 instead of proper GType. Later using 0 make gtk_list_store_new() fail to get proper GListStore: inner_auth_combo_init: auth_model = gtk_list_store_new (2, G_TYPE_STRING, eap_method_get_type ()) Even if this patch is right, the problem is not solved, because instead of the crash a deadlock may occur. It might be the same issue as described in https://bugzilla.gnome.org/show_bug.cgi?id=674885. https://bugzilla.redhat.com/show_bug.cgi?id=979123
* Updated Brazilian Portuguese translationEnrico Nicoletto2013-09-121-160/+168
|
* editor: initialize the destroy handler at last in ↵Thomas Haller2013-09-122-2/+3
| | | | | | | | | | | | | | | eap_method_init/wireless_security_init When 'eap_method_init' or 'wireless_security_init' fails to read the UI xml file, it calls 'eap_method_unref' or 'wireless_security_unref', respectively. The unref methods call the destroy handler, but they should not do it in this case, because the objects were not fully constructed. Fix this, be setting the destroy handler only at the end of the init methods. Signed-off-by: Thomas Haller <thaller@redhat.com>
View Lorry Controller Status