| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
This is essentially an usability thing that allows system-owned secrets to
be used even when GNOME keyring is not installed.
https://gitlab.gnome.org/GNOME/network-manager-applet/issues/3
|
|
|
|
|
| |
If getting old secrets fails for whichever reason, get_existing_secrets_cb()
is called with error set and NULL settings (by keyring_find_secrets_cb()).
|
|
|
|
| |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/4
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handling of nm-connection-editor command line arguments was changed in
f3782da2. Since that commit, most args are handled by `editor_command_line`,
but one (`--keep-above`) is handled by `main`. Unfortunately, if
`--keep-above` appears with other arguments, `main` does not strip it from
argv and parsing in `editor_command_line` fails with "Failed to parse
options".
To handle this, let's just have `editor_command_line` recognize but ignore
`--keep-above` if it encounters it.
https://gitlab.gnome.org/GNOME/network-manager-applet/issues/1
Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
"with_appindicator" is the global variable set when parsing command
line arguments. It later results in the initialization of applet's
app-indicator instance. We always should check for INDICATOR_ENABLED(),
not "with_appindicator".
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=796258
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We must use premade icons for the indicator VPN case.
The icons are copies of the original with the padlock pre-composited, because
indicators can't use pixbufs; we use the suffix -secure.
This change got introduced with Ubuntu 16.04. Several icon themes have
upstreamed those -secure icons meanwhile (Numix, MATE Faenza,
elementaryXubuntu-dark from murrine-themes).
This patch requires additional icons in nm-applet:
nm-signal-<xx>.png -> nm-signal-<xx>-secure.png
nm-device-wired.png -> nm-device-wired-secure.png
Patch author: Mathieu Trudel-Lapierre <mathieu@canonical.com>
https://bugzilla.gnome.org/show_bug.cgi?id=796258
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Icons were created for Ubuntu and have been obtained from the
network-manager-applet src:package in Ubuntu. The package maintainer
applied no specific copyrights to those files. In debian/copyright of
the Ubuntu package they are covered by this copyright info block:
Files: *
Copyright: 2004 - 2015 Red Hat, Inc.
2005 - 2008 Novell, Inc.
2001, 2002 Free Software Foundation
License: GPL-2+
https://bugzilla.gnome.org/show_bug.cgi?id=796258
|
|
|
|
|
|
|
|
| |
https://bugs.archlinux.org/task/58767
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/2
Fixes: 15ac92e6a42317e86ffb6d52a9ce5cacbf9e8c87
|
|\
| |
| |
| | |
https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/1
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The pipeline begins with "build" stage doing a distcheck on Fedora 28
(which is still known to ship libnm-glib) and outputting a tarball
artifact.
The output is then used in the "test" stage.
Some repetition is avoided with YAML map capability, but that's fairly
limited.
Both autotools and meson build/installs are done with both autotools and
meson on latest Fedora (happens to be Fedora 28 too). That seems to be a
reasonable enough for start, given we can't test all possible
combinations.
In future, builds on some older platforms, CentOS and Ubuntu and clang
builds would be nice. Not implemented at this point, but it should be
straightforward enough.
Maybe a build with a Git snapshot of NetworkManager would be useful at
some point, but that's not implemented wither.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
g-ir-scanner uses distutils that have an unfortunate misfeature of
inheriting the compiler flags it itself was built with.
This includes the hardening flags that don't work with without
redhat-rpm-build and break with clang every full moon.
A configure check makes it clear about what went wrong in case
introspection is desired, otherwise turns it off.
|
| |
| |
| |
| |
| |
| |
| |
| | |
It's not necessarily present among the packages in a minimal
installation (such as Fedora's docker image). Worse even, libtool just
ends up not linking to some .la libraries.
Don't assume it's there.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It's a not necessarily present among the packages in a minimal
installation (such as Fedora's docker image). Worse even, configure just
ends up passing wrong linker flags on some architectures, without a word
of complain.
Don't assume it's there.
|
|/
|
|
| |
Autoconf installs it on autogen.
|
| |
|
| |
|
| |
|
| |
|
|\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=796211
|
| |
| |
| |
| |
| | |
Just so that the Quit action is not lonely. Also, we can now use the
Ctrl+N accelerator.
|
| |
| |
| |
| |
| |
| |
| | |
It just contains a Quit entry solemnly for the purpose of using a
standard accelerator (Ctrl+Q).
https://bugzilla.redhat.com/show_bug.cgi?id=1539697
|
| |
| |
| |
| |
| | |
This simplifies things as we can replace the custom-made D-Bus interface
with a standard one.
|
|/
|
|
| |
Make it the name we use on D-Bus.
|
| |
|
| |
|
|
|
|
|
|
| |
Fixes: 2644d631afd072f66878799e75c5aa1947510c7a
https://bugzilla.redhat.com/show_bug.cgi?id=1574908
|
| |
|
| |
|
|
|
|
| |
This makes GCC 8 unhappy, almost sad.
|
|
|
|
|
| |
This will make it easier to selectively disable it for Gtk 4, since a
Gtk 4 flavor is not yet available.
|
| |
|
| |
|
|
|
|
| |
See https://developer.gnome.org/hig/stable/typography.html
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PPPoE connection that specify a parent interface are more flexible
because they work not only on Ethernet and allow another connection to
be active on the same device. However, due to this last feature,
nm-applet can't control them because it would not be possible to show
two connections active for the same device.
Now the editor can only create pppoe connection with parent-interface
and this made it impossible to activate the connection from the
applet. Add a new checkbox that allows to choose the pppoe connection
type, with a tooltip documenting the behavior of the two choices.
Fixes: 3c83f844ced4f620993054cddb19b22fe459fa0b
https://bugzilla.gnome.org/show_bug.cgi?id=791985
https://bugzilla.redhat.com/show_bug.cgi?id=1574175
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
- always #define USE_AYATANA_INDICATORS to either 0 or 1 in case
WITH_APPINDICATOR is defined.
- previously, with meson -Dappindicator=no was not working. Fix it.
- merge the autotools variant APPINDICATOR_VARIANT with the
--with-appindicator option. We don't need two flags to select
a particular appindicator variant.
- add "yes" as an alias for "auto". It mirrors "no". However, I wonder
if such kind of autodetection is really desirable. Shouldn't the user
be required to specify the variant to use?
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=795333
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
See https://developer.gnome.org/hig/stable/typography.html
|
| |
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=794674
|
|
|
|
|
|
| |
Use two columns to align combo boxes and the spin button. Also, don't
waste space but put related items (auto-connect checkbox and
auto-connect priority spin-button, etc.) on the same row.
|