summaryrefslogtreecommitdiff
path: root/src/connection-editor/page-8021x-security.c
Commit message (Collapse)AuthorAgeFilesLines
* editor/page: use defines for signal namesLubomir Rintel2018-06-191-1/+1
| | | | | Doing this for consistency with code where Thomas insists this is a good idea. Easier than fixing Thomas.
* editor/page: streamline initialized signallingLubomir Rintel2018-06-191-4/+1
| | | | | | The error argument is never used, don't pretend we handle it and avoid leaking it. Just dumping the error on the console is still not optimal, but unconfusing things is a good start.
* editor: add the WirelessSecurity to a size groupLubomir Rintel2017-07-111-0/+7
| | | | Otherwise the labels are messy.
* editor: add macsec supportBeniamino Galvani2017-06-181-1/+23
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1456007
* editor: fix crash when destroying 802.1x pageBeniamino Galvani2017-06-061-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EAP methods keep a pointer to wireless-security without holding any reference to it (to avoid a circular dependency). Thus, their lifetime must be shorter than the wireless-security's. When the page is disposed, EAP methods are kept alive because they are referenced by the combo box displayed in the page. When the page is destroyed, they try to access the wireless-security that is already gone. Fix this by removing the security widgets from the page before destroying the wireless-security, so that EAP methods instances don't stay around longer and are disposed at the same time of wireless-security. ==11224== Invalid read of size 8 ==11224== at 0x444FA1: wireless_security_set_userpass (wireless-security.c:220) ==11224== by 0x93033E4: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.5000.3) [...] ==11224== by 0x5DB3BBF: gtk_widget_unrealize (gtkwidget.c:5520) ==11224== by 0x5DB63DF: gtk_widget_dispose (gtkwidget.c:12065) ==11224== by 0x5DC9E47: gtk_window_dispose (gtkwindow.c:3151) ==11224== by 0x9309AE8: g_object_run_dispose (in /usr/lib64/libgobject-2.0.so.0.5000.3) ==11224== by 0x415F98: dispose (nm-connection-editor.c:513) ==11224== Address 0x1c635820 is 64 bytes inside a block of size 136 free'd ==11224== at 0x4C2ED4A: free (vg_replace_malloc.c:530) ==11224== by 0x97996CD: g_free (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x97B221F: g_slice_free1 (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x41FE99: dispose (page-8021x-security.c:222) ==11224== by 0x9308095: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.5000.3) ==11224== by 0x97B321C: g_slist_foreach (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x97B323A: g_slist_free_full (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x415E77: dispose (nm-connection-editor.c:495) ==11224== Block was alloc'd at ==11224== at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) ==11224== by 0x97995B8: g_malloc (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x97B1B12: g_slice_alloc (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x97B213D: g_slice_alloc0 (in /usr/lib64/libglib-2.0.so.0.5000.3) ==11224== by 0x444DD8: wireless_security_init (wireless-security.c:160) ==11224== by 0x448381: ws_wpa_eap_new (ws-wpa-eap.c:107) ==11224== by 0x41FF22: finish_setup (page-8021x-security.c:69) ==11224== by 0x93033E4: g_closure_invoke (in /usr/lib64/libgobject-2.0.so.0.5000.3) ==11224== by 0x931E05E: g_signal_emit_valist (in /usr/lib64/libgobject-2.0.so.0.5000.3) ==11224== by 0x931E43E: g_signal_emit (in /usr/lib64/libgobject-2.0.so.0.5000.3) ==11224== by 0x41CFEA: emit_initialized (ce-page.c:667) ==11224== by 0x41CFEA: ce_page_complete_init (ce-page.c:719) ==11224== by 0x416EEA: get_secrets_cb (nm-connection-editor.c:822) ==11224== by 0x8FD82B6: g_simple_async_result_complete (in /usr/lib64/libgio-2.0.so.0.5000.3) ==11224== by 0x7466F58: get_secrets_cb (nm-remote-connection.c:456) Fixes: 39bf39a394f94619d1135d48968704c09924c98b https://bugzilla.redhat.com/show_bug.cgi?id=1458567
* connection-editor: Fix handling of wired 802-1x security settingMikhail Efremov2016-08-261-1/+5
| | | | | | | | | | | | | Function nm_setting_duplicate() can't copy object's data. As a result a value of the "Ignore CA certificate" checkbox was always lost. So don't copy settings, just use g_object_ref() again and remove the 8021x setting from the temporary object to prevent the clearing of secrets. https://mail.gnome.org/archives/networkmanager-list/2016-August/msg00109.html Fixes: c21d56dd22057103c8125a49307b4ff47b5b644d (cherry picked from commit 2c844acc8f00d9c1d3536b114208170c9cdbe7f2)
* editor: spell 802.1X standard right with capital "X" (rh #1274505)Jiří Klimeš2016-07-271-3/+3
| | | | | | and update po files accordingly https://bugzilla.redhat.com/show_bug.cgi?id=1274505
* connection-editor: fix wired 802-1x secrets savingMikhail Efremov2016-06-071-1/+1
| | | | | | | | | In case of wired 802-1x connection a temporary connection object is used, but since NM commit 6a19e68a7d856629600655a076b0cea4be346799 secrets are cleared when the object is destroyed. So duplicate 802-1x settings instead of using g_object_ref(). https://mail.gnome.org/archives/networkmanager-list/2016-May/msg00097.html
* wireless-security: make broken configuration entries redBastien Nocera2016-06-071-0/+16
| | | | | | | | | | | | | When a configuration setting is wrong, set the entry or file chooser that contains the incorrect information to be surrounded by red. This makes it easier for users to find where the error was made that disallows them to click the "Apply" button. See https://bugzilla.gnome.org/show_bug.cgi?id=734446 See https://bugzilla.gnome.org/show_bug.cgi?id=734472 https://bugzilla.gnome.org/show_bug.cgi?id=767210
* all: include <gtk/gtk.h> via "nm-default.h"Thomas Haller2016-02-241-2/+0
|
* all: include <glib/gi18n.h> via "nm-default.h"Thomas Haller2016-02-241-1/+0
|
* all: include "config.h" via "nm-default.h"Thomas Haller2016-02-241-2/+0
| | | | | | Every internal source file should include "nm-default.h" as first. Therefore, also include "nm-config.h" via the default header.
* all: include "nm-default.h" in every source fileThomas Haller2016-02-161-0/+2
|
* editor: allow changes on one page modify other pagesJiří Klimeš2015-10-141-1/+3
| | | | | | | | | Changes in properties on a page may require changes on other pages. Let's add an infrastructure for that. When a change should influence other page(s), the information is set using nm_connection_editor_inter_page_set_value(). And then that can be retrieved by nm_connection_editor_inter_page_get_value() in another page in method inter_page_change().
* c-e: forward the validation error to print more sensible error message to stdoutThomas Haller2015-09-111-4/+2
| | | | | | | | | | | | | When a connection doesn't verify, the "Save" dialog stays desensitized. Even for an advanced user it's not immediately clear what causes the valdation failure. We already print a message like "Invalid setting Ethernet" to stdout. Extend the message to also print an more detailed error that gets propagated from the validation. This later should be improved further to indicating the failure reason in the UI too.
* c-e/trivial: rename virtual method validate()Thomas Haller2015-09-111-2/+2
| | | | | | There are other function names with the same name. This makes it hard to grep the source code to find all type implementations of ce_page_validate().
* connection-editor: port to libnmDan Winship2015-02-251-11/+2
| | | | Based on a patch by Jiří Klimeš.
* wireless-security: build separate libnm-based and libnm-glib-based versionsDan Winship2015-02-241-1/+1
| | | | | | Also, drop the "ssid" parameter from wireless_security_validate(), since it would need to be different between the two versions, but it turns out it's not actually used anyway.
* editor: clean up object dispose()Dan Williams2014-10-101-8/+3
| | | | | Remove unused 'disposed' private variables and make every dispose() safe to be called multiple times.
* applet: remove the ca cert nag dialog.Thomas Haller2013-08-271-9/+0
| | | | | | | | | The previous commit introduced a new flag "No CA certificate required". This change of the UI replaces the warning dialog (nag_dialog). Remove all parts of the nag dialog from the code and translation files. Signed-off-by: Thomas Haller <thaller@redhat.com>
* build: remove GTK_CHECK_VERSION checksDan Winship2013-03-121-4/+0
| | | | In particular, remove all gtk2-only code.
* connection-editor: keep track of the NMRemoteSettings on CEPageDan Winship2012-10-041-0/+1
|
* connection-editor: pass the NMRemoteSettings object to page constructorsDan Winship2012-08-201-0/+1
|
* connection-editor: rename "wired" and "wireless" in files/classes/functionsDan Winship2012-08-091-0/+232
Update internal names to match the UI.
View Lorry Controller Status