diff options
| author | Bastien Nocera <hadess@hadess.net> | 2022-11-24 10:45:28 +0100 |
|---|---|---|
| committer | Bastien Nocera <hadess@hadess.net> | 2023-02-13 15:00:18 +0100 |
| commit | 8ebbd7f7a8909cec389acaebfe809ea7c5100618 (patch) | |
| tree | e91af03e84b9adfaeacf9429e193b9bd2ade6057 | |
| parent | 65f62adc6c5d6a7c061144edd6da63c1ea51729f (diff) | |
| download | totem-8ebbd7f7a8909cec389acaebfe809ea7c5100618.tar.gz | |
opensubtitles: Re-fix blank dialogue (and traceback)
Traceback (most recent call last):
File "/usr/lib/python3.11/site-packages/gi/overrides/Gtk.py", line 85, in _builder_connect_callback
handler, args = _extract_handler_and_args(obj_or_map, handler_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.11/site-packages/gi/_gtktemplate.py", line 34, in _extract_handler_and_args
raise AttributeError('Handler %s not found' % handler_name)
AttributeError: Handler Gtk.Widget.hide_on_delete not found
Fixes: f2ae04f ("opensubtitles: Fix blank dialogue when reopened")
| -rw-r--r-- | src/plugins/opensubtitles/opensubtitles.py | 6 | ||||
| -rw-r--r-- | src/plugins/opensubtitles/opensubtitles.ui | 2 |
2 files changed, 6 insertions, 2 deletions
diff --git a/src/plugins/opensubtitles/opensubtitles.py b/src/plugins/opensubtitles/opensubtitles.py index 589ef10fb..32340500a 100644 --- a/src/plugins/opensubtitles/opensubtitles.py +++ b/src/plugins/opensubtitles/opensubtitles.py @@ -455,7 +455,7 @@ class OpenSubtitles (GObject.Object, # pylint: disable=R0902 def _build_dialog (self): ui_file_path = os.path.dirname (os.path.abspath (__file__)) + sep + 'opensubtitles.ui' builder = Gtk.Builder.new_from_file (ui_file_path) - builder.connect_signals(None) + builder.connect_signals(self) # Obtain all the widgets we need to initialize combobox = builder.get_object ('language_combobox') @@ -527,6 +527,10 @@ class OpenSubtitles (GObject.Object, # pylint: disable=R0902 self._tree_view.connect ('row-activated', self.__on_treeview__row_activate) + def _hide_on_delete(self, *_): + self._dialog.hide_on_delete() + return True + def _show_dialog (self, *_): if not self._dialog: self._build_dialog () diff --git a/src/plugins/opensubtitles/opensubtitles.ui b/src/plugins/opensubtitles/opensubtitles.ui index d0f8161b6..3b8929b3d 100644 --- a/src/plugins/opensubtitles/opensubtitles.ui +++ b/src/plugins/opensubtitles/opensubtitles.ui @@ -29,7 +29,7 @@ <property name="default_width">400</property> <property name="default_height">400</property> <property name="type_hint">dialog</property> - <signal name="delete-event" handler="gtk_widget_hide_on_delete" swapped="no"/> + <signal name="delete-event" handler="_hide_on_delete" swapped="no"/> <child> <object class="GtkBox" id="vbox1"> <property name="orientation">vertical</property> |