build: Re-add pylint tests

They were never ported from autotools, even leaving the file around.

6 files changed, 10 insertions, 63 deletions

diff --git a/src/plugins/Makefile.plugins b/src/plugins/Makefile.plugins
deleted file mode 100644
index 087c977a5..000000000
--- a/src/plugins/Makefile.plugins
+++ /dev/null
@@ -1,63 +0,0 @@
-%.plugin: %.plugin.in
-	$(AM_V_GEN)$(INTLTOOL_MERGE) $(INTLTOOL_MERGE_OPTIONS) $(top_srcdir)/po $< $@ -d -u -c $(top_builddir)/po/.intltool-merge-cache
-
-# Quieten the intltool-merge process
-INTLTOOL_MERGE_OPTIONS = $(INTLTOOL_MERGE_OPTIONS_$(V))
-INTLTOOL_MERGE_OPTIONS_ = $(INTLTOOL_MERGE_OPTIONS_$(AM_DEFAULT_VERBOSITY))
-INTLTOOL_MERGE_OPTIONS_0 = -q
-
-plugin_DATA = $(plugin_in_files:.plugin.in=.plugin)
-
-CLEANFILES = $(plugin_DATA)
-DISTCLEANFILES = $(plugin_DATA)
-EXTRA_DIST = $(plugin_in_files)
-
-AM_CPPFLAGS = \
-	-DG_LOG_DOMAIN=\""Totem"\"	\
-	$(DISABLE_DEPRECATED)		\
-	-I$(top_srcdir)/		\
-	-I$(top_srcdir)/src		\
-	-I$(top_srcdir)/src/plugins	\
-	-I$(top_srcdir)/src/gst
-
-plugin_cflags =			\
-	$(PLAYER_CFLAGS)	\
-	$(WARN_CFLAGS)
-
-plugin_ldflags = \
-	-export-dynamic \
-	-no-undefined \
-	-avoid-version \
-	-module
-
-plugin_libadd = \
-	$(top_builddir)/src/libtotem.la
-
-# Disable some C warnings for Vala plugins which just create noise because the
-# C code Vala generates is a little messy.
-vala_plugin_cflags = \
-	-Wno-unused-but-set-variable \
-	-Wno-unused-variable \
-	-Wno-unused-function \
-	$(NULL)
-
-# Checking rules for Python plugins
-# Execute pylint on all the requisite files individually, returning non-zero
-# iff any of the calls to pylint returned non-zero.
-# Don't bother adding this as a prerequisite rule of 'check', since it can
-# easily cause spurious and painful distcheck failures.
-check-pylint: $(plugin_PYTHON)
-if ENABLE_PYTHON
-	@exitstatus=0; \
-	for py in $^; do \
-		$(PYLINT) -d C0111 -d W0511 -d F0401 $$py; \
-		\
-		newexitstatus=$$?; \
-		if [ $$exitstatus == 0 ]; then \
-			exitstatus=$$newexitstatus; \
-		fi; \
-	done; \
-	exit $$exitstatus
-endif
-
-.PHONY: check-pylint
diff --git a/src/plugins/dbusservice/meson.build b/src/plugins/dbusservice/meson.build
index 0dc653f56..3998234fa 100644
--- a/src/plugins/dbusservice/meson.build
+++ b/src/plugins/dbusservice/meson.build
@@ -17,3 +17,5 @@ custom_target(
   install: true,
   install_dir: plugin_dir
 )
+
+test('pylint-' + plugin_name, pylint, args: pylint_flags + [ plugin_name + '.py' ])
diff --git a/src/plugins/meson.build b/src/plugins/meson.build
index 6c884dc81..1bc31af7e 100644
--- a/src/plugins/meson.build
+++ b/src/plugins/meson.build
@@ -147,6 +147,8 @@ if plugins_option != 'none'
   endif
 endif
 
+pylint_flags = ['-d', 'C0111', '-d', 'W0511', '-d', 'F0401' ]
+
 foreach plugin: plugins
   subdir(plugin)
 endforeach
diff --git a/src/plugins/opensubtitles/meson.build b/src/plugins/opensubtitles/meson.build
index f4692f4b7..7beab4dfb 100644
--- a/src/plugins/opensubtitles/meson.build
+++ b/src/plugins/opensubtitles/meson.build
@@ -38,3 +38,5 @@ install_data(
   plugin_name + '.convert',
   install_dir: join_paths(totem_datadir, 'GConf', 'gsettings')
 )
+
+test('pylint-' + plugin_name, pylint, args: pylint_flags + [ plugin_name + '.py', 'hash.py' ])
diff --git a/src/plugins/pythonconsole/meson.build b/src/plugins/pythonconsole/meson.build
index e782e5b84..768cb0c78 100644
--- a/src/plugins/pythonconsole/meson.build
+++ b/src/plugins/pythonconsole/meson.build
@@ -37,3 +37,5 @@ install_data(
   plugin_name + '.convert',
   install_dir: join_paths(totem_datadir, 'GConf', 'gsettings')
 )
+
+test('pylint-' + plugin_name, pylint, args: pylint_flags + [ plugin_name + '.py', 'console.py' ])
diff --git a/src/plugins/samplepython/meson.build b/src/plugins/samplepython/meson.build
index bada009a9..bfcc06075 100644
--- a/src/plugins/samplepython/meson.build
+++ b/src/plugins/samplepython/meson.build
@@ -21,3 +21,5 @@ custom_target(
   install: plugin_install,
   install_dir: plugin_dir
 )
+
+test('pylint-' + plugin_name, pylint, args: pylint_flags + [ plugin_name + '.py' ])