diff options
| author | Mathieu Bridon <bochecha@daitauha.fr> | 2018-06-27 15:45:14 +0200 |
|---|---|---|
| committer | Bastien Nocera <hadess@hadess.net> | 2018-06-27 15:12:39 +0000 |
| commit | 73a637145a4691e91d268c4ba00ce624be989544 (patch) | |
| tree | c0daa7ff28089ee56d7ce4d7472dcb1830651b88 | |
| parent | 7f54e1f0369cf2087655ab3e7fd071440d3f867f (diff) | |
| download | totem-73a637145a4691e91d268c4ba00ce624be989544.tar.gz | |
opensubtitles: Fix a function signature
Commit 6afabc102b4ac50cbf4497847fceeaae1dfa07f5 changed the method
signature to please pylint:
- def _show_dialog (self, params, _):
+ def _show_dialog (self, _):
This effectively makes the method take a single parameter instead of
two.
However the method is typically called with two arguments. (it is an
action callback)
This completely broke the OpenSubtitles plugin, which wasn't able to
show its dialog any more.
This commit makes the code ignore all parameters of the method, so
Pylint is still happy, but fixes the issue.
| -rw-r--r-- | src/plugins/opensubtitles/opensubtitles.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/opensubtitles/opensubtitles.py b/src/plugins/opensubtitles/opensubtitles.py index d11e2816d..80fc810a7 100644 --- a/src/plugins/opensubtitles/opensubtitles.py +++ b/src/plugins/opensubtitles/opensubtitles.py @@ -514,7 +514,7 @@ class OpenSubtitles (GObject.Object, # pylint: disable=R0902 self._tree_view.connect ('row-activated', self.__on_treeview__row_activate) - def _show_dialog (self, _): + def _show_dialog (self, *_): if not self._dialog: self._build_dialog () |