| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Users shouldn't have to do maths to understand how the actions
relate to each other. Simple descriptions are much easier to
understand.
https://bugzilla.gnome.org/show_bug.cgi?id=759548
Closes: #155
|
|
|
|
| |
Closes: #130
|
| |
|
|
|
|
| |
This means that we now always show content in the subtitles menu.
|
| |
|
| |
|
|
|
|
| |
And remove some UI niceties in the (hidden) debug window.
|
| |
|
|
|
|
|
| |
The icons need to be in a specific format for GtkBuilder to parse them
properly.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
tmw_bvw_box contained the video widget and an unused revealer.
|
|
|
|
| |
totem_main_vbox wasn't used anymore, so remove it from the hierarchy.
|
|
|
|
| |
tmw_main_vbox wasn't used anymore, so remove it from the hierarchy.
|
|
|
|
|
|
|
|
| |
When there's no video because we're playing an audio-only file, or
because a plugin is missing, show a placeholder that corresponds to that
type of media.
See https://gitlab.gnome.org/Teams/Design/icon-development-kit/-/issues/44
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace the clutter-gtk based video widget with a native GL GStreamer
widget, "gtkglsink".
- Display aspect-ratio support for non-square pixels was removed. While
it still worked correctly (you can try setting your display's resolution
to a different aspect ratio), things like text and icons, and everything
else in every application and the shell chrome would have been looked
broken, including the video player. Except the video in the video player.
- Video aspect ratio, pillar-boxing, letter-boxing and automatic rotation
is now handled in the GStreamer widget
- The placeholder logos, when playing files with unsupported video, or
no video tracks have been changed.
- Handling of mouse events has been simplified
Some functionality could not be brought forward at this time:
- Crop-zooming (available using the R/T keys) isn't implemented yet
- Gestures support, which never worked properly anyway, wasn't
reimplemented
|
|
|
|
|
|
|
|
| |
Rather than using an icon, use a string that can be translated as the
app name.
"Preview" will the suffix for that app name until we agree on a common
name in https://gitlab.gnome.org/Teams/Design/os-mockups/-/issues/155
|
|
|
|
|
|
| |
We were using the wrong configuration to substitute the application ID.
But appstream-glib validate should have caught this, but didn't:
https://github.com/hughsie/appstream-glib/issues/426
|
| |
|
|
|
|
| |
So we can reuse variables declared locally in the appdata subfolder.
|
| |
|
|
|
|
| |
It won't be implemented in the first pass at porting to gtkglsink.
|
|
|
|
|
| |
data/meson.build:78:0: ERROR: Function does not take positional arguments.
data/appdata/meson.build:3:0: ERROR: Function does not take positional arguments.
|
|
|
|
|
|
|
| |
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: https://github.com/mesonbuild/meson/issues/9300
|
|
|
|
| |
Same as previous commits.
|
|
|
|
| |
Same as previous commits.
|
|
|
|
| |
Identical to the previous commit.
|
|
|
|
|
|
| |
Despite the large diff, the only relevant change here is
the same of the previous commit: "left-padding" is replaced
by "margin-start".
|
|
|
|
|
|
| |
GtkAlignment is a deprecated widget. This particular one is
an easy case, where we only need to replace the "left-padding"
property by the "margin-start" property in the child.
|
|
|
|
|
|
| |
Almost identically to previous commit, except that the
"hexpand" property was set to all children to make sure
the grid is pixel-by-pixel similar to the current state.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the "homogeneous" property, since it's set to false
and GtkGrid's column-homogeneous and row-homogeneous are
false by default.
Replace the "right_attach" and "bottom_attach" packing
properties by "width" and "height", respectively, since
that's what GtkGrid supports.
Next GtkTable -> GtkGrid conversions will look similar to
this commit.
|
|
|
|
|
|
|
| |
GtkTable is deprecated in favour of GtkGrid. In addition to
that, in this case, table3_1 only contains a single widget,
and doesn't have any particularly relevant property set, so
it can be simply removed without further consequences.
|
|
|
|
|
|
|
|
|
|
|
| |
This button box has a single child, a GtkButton, and
is effectively only used to horizontally align the
button at the end. This property can be trivially set
in the button itself nowadays.
Remove the GtkHButtonBox holding the "Reset to Defaults"
button, and preserve the end alignment of the button by
setting the "halign" to "end" in the button itself.
|
|
|
|
| |
Another easy one since horizontal is the default.
|
|
|
|
|
|
|
| |
Surprisingly, all but one GTKVBoxes already have the
orientation property set to vertical, which saves us
some work. While at it, cleanup object ids that are
not used.
|
|
|
|
|
|
| |
No other changes are needed besides changing the class,
since GtkBox defaults to horizontal. While at it, remove
the object ids, since they're unused.
|
|
|
|
|
| |
Rename these files to match the class name they implement. Rename the
.ui file to match them.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most of the code is what was there in preferences.c, but with a twist: it now
has a GtkDialog subclass handling the preferences.
The laborious part of this change is replacing the old GtkBuilder-based
mechanism to retrieve widgets by their name with binding template children.
Signal callbacks can now be static, and be passed explicitly instead of using
G_MODULE_EXPORT to preserve their symbols.
This commit is the smallest possible way to achieve this, and doesn't make
use of various niceties and good practices of GTK development. Next commits
will cleanup and improve preferences to actually use more modern GTK practices.
|
|
|
|
| |
Seems to be a copy-paste mistake.
|
|
|
|
|
|
|
|
|
| |
The hue, brightness, saturation, and contrast labels have their visibility
programatically tied to their corresponding ranges. We can do that in the
.ui file more easily.
Bind these labels' visibility to their corresponding ranges' in the
preferences.ui file itself.
|
|
|
|
| |
They can easily be declared in the .ui file.
|
|
|
|
|
| |
Move yet another property that can be defined in the .ui file directly
to preferences.ui.
|
|
|
|
|
|
|
|
|
|
| |
Instead of installing preferences.ui and opening the file, embed it
as a GResource and load it using gtk_builder_new_from_resource().
We don't need extra caution because the file is now guaranteed to
be embedded into the application.
This will be very handy for the next commit where we start using
a GtkBuilder template for the preferences dialog.
|
|
|
|
|
|
|
| |
There's no need to programatically set it when it can be done declaratively
in the .ui file.
Set the 'modal' property of the preferences dialog at preferences.ui.
|
|
|
|
|
|
|
| |
Because the file to validate wasn't created yet.
/run/build/totem/_flatpak_build/data/appdata/org.gnome.Totem.appdata.xml: /run/build/totem/_flatpak_build/data/appdata/org.gnome.Totem.appdata.xml could not be read: Failed to open file “/run/build/totem/_flatpak_build/data/appdata/org.gnome.Totem.appdata.xml”: No such file or directory
/run/build/totem/_flatpak_build/data/org.gnome.Totem.desktop: file does not exist
|
|
|
| |
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/445
|
|
|
|
|
|
|
|
|
|
| |
Both the audio/ogg and video/ogg mime-types are subclasses of
application/ogg. Seeing as we only support the video subclass (see
e4a1aaf7d9d3b2c50e2540d5d7f0059ffa30c26b), remove application/ogg
from the supported mime-types.
This will also stop the “Default Applications” panel in GNOME's Settings
from listing Videos as a potential audio player.
|