| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
When popping down the search entry, and scrolling down to activate the
"load content" action, we would try and load more search results but we
never really started a search, leading to a crash.
Make sure that a search is only considered to be started when the search
entry has been activated.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2079657
|
|
|
|
| |
See https://blog.ometer.com/2011/01/20/boolean-parameters-are-wrong/
|
| |
|
|
|
|
| |
Use G_DECLARE_FINAL_TYPE(), and remove intermediate private struct.
|
|
|
|
| |
Could be for any reason, and it's really useful to know.
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f672175701ad4b8320a771854ad6364f51fe6570.
2 problems:
- we remove the whole conditional, which meant never setting the
"monitor" variable
- the tracker2 plugin doesn't resolve media before passing it to
the content-changed functions, so it still isn't useful
|
|
|
|
|
|
| |
This reverts commit 0ed1d793feade5f9e8a28a82f1fe1e00456f3b37.
Fixed in https://gitlab.gnome.org/GNOME/grilo-plugins/-/issues/73
|
|
|
|
|
| |
They don't work well enough for now. See:
https://gitlab.gnome.org/GNOME/grilo-plugins/-/issues/73
|
|
|
|
| |
It should be working correctly now that we only add videos to the view.
|
|
|
|
|
| |
Don't handle changes related to non-video files in monitored grilo
sources.
|
|
|
|
| |
Just the name of the plugin changed.
|
|
|
|
| |
No need for this to be code, it's a static configuration option.
|
|
|
|
|
|
|
| |
Handle https://gitlab.gnome.org/GNOME/grilo/-/issues/140 locally
and specify an upper range that does not translate to 0. This
will be necessary for the tracker3 grilo source, as it doesn't
try to interpret what that 0 means.
|
| |
|
|
|
|
|
|
|
|
| |
Don't make the search entry insensitive while the search is ongoing,
instead cancel the ongoing operation if a new search is started.
Closes: #188
Helps: #113
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix possible use of an uninitialised variable, as spotted by valgrind.
(totem:28635): Gtk-CRITICAL **: 17:22:01.811: gtk_tree_model_get_iter: assertion 'path != NULL' failed
==28635== Conditional jump or move depends on uninitialised value(s)
==28635== at 0x50BCC94: gtk_tree_store_get_value (gtktreestore.c:655)
==28635== by 0x50AF14D: gtk_tree_model_get_valist (gtktreemodel.c:1798)
==28635== by 0x50AF47C: gtk_tree_model_get (gtktreemodel.c:1762)
==28635== by 0x48989C6: browse_cb (totem-grilo.c:688)
==28635== by 0x608EFE3: queue_process (grl-source.c:2088)
==28635== by 0x4994917: g_main_dispatch (gmain.c:3189)
==28635== by 0x4994917: g_main_context_dispatch (gmain.c:3854)
==28635== by 0x4994D07: g_main_context_iterate.isra.26 (gmain.c:3927)
==28635== by 0x4994D9B: g_main_context_iteration (gmain.c:3988)
==28635== by 0x4B3A71C: g_application_run (gapplication.c:2516)
==28635== by 0x10A277: main (totem.c:83)
See https://gitlab.gnome.org/GNOME/totem/issues/304
|
|
|
|
| |
Update Bugzilla links for GitLab links when the bugs are still opened.
|
|
|
|
|
|
|
|
| |
They're not supported in GStreamer:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/203
Note that this will only work with a new enough grilo-plugins, but will
not throw errors with older ones.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This reverts commit 833526d06f9ac9ad44966b00a9fd62648ccaf489.
This was still not working, see:
https://gitlab.gnome.org/GNOME/grilo-plugins/merge_requests/29
https://gitlab.gnome.org/GNOME/grilo-plugins/issues/14
|
|
|
|
|
|
|
|
|
| |
When a cached stream is created in the cache dir after a "Make available
offline" click, we need to make sure, in delete_foreach() that the file
is trashed as well as the bookmarks entry removed, otherwise "Make
available offline" would fail later for that same stream.
Closes: #294
|
|
|
|
|
|
| |
This reverts commit e88c4d5806986cd82781c5447d7301d248bf1bdd.
As https://bugzilla.gnome.org/show_bug.cgi?id=746974 has been fixed.
|
|
|
|
|
|
|
| |
Rework the grilo plugins loading code to make sure that the bookmarks
plugin and offline metadata plugins are available when the UI is opened
without going through the content selection view, directly into the
player.
|
|
|
|
|
|
|
|
| |
As spotted by dcb.
https://bugzilla.gnome.org/show_bug.cgi?id=787262
Signed-off-by: Philip Withnall <withnall@endlessm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
duplicate ‘const’ declaration specifier [-Wduplicate-decl-specifier]
The warning was added in:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43651
just for this purpose.
"
int foo(const char const *data);
^~~~~~
1 warning generated.
[...] In that case it was clearly a mistake, because the author meant
'const char *const data' [...]
"
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=774411
|
|
|
|
| |
Some small changes to the API.
|
|
|
|
|
|
| |
b1eee82 was slightly incorrect. We still use the local-metadata source
to fetch the URL to the local thumbnails. Both the local-metadata (for
thumbnail paths) and video-title-parsing sources are required.
|
|
|
|
|
| |
grl-local-metadata is now gone, replaced by a Lua source
that does the same.
|
|
|
|
|
|
|
|
|
| |
When visiting the Channels page, we'd create a filter model, but
switching back to the Videos page, we wouldn't reset it. Harden the
selection request checks to check whether we're on the Channels page
(and at the root of it) before refusing selection.
https://bugzilla.gnome.org/show_bug.cgi?id=754389
|
|
|
|
|
| |
We want films with a minimum length of 5 seconds, not a maximum length
of 5 seconds.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=746165
|
|
|
|
|
| |
See also:
https://bugzilla.gnome.org/show_bug.cgi?id=746974
|
|
|
|
| |
A little bit cleaner.
|
|
|
|
|
|
|
|
|
|
|
| |
Thumbnails are now square to avoid reflow when loading new items which
might have mixed types of media (vertical videos, covers vs. horizontal
TV/cinema videos).
Mockup is at:
https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/thumbnails-square.png
https://bugzilla.gnome.org/show_bug.cgi?id=743247
|
|
|
|
| |
Instead of the deprecated version.
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=743190
|
|
|
|
|
|
| |
As we don't have GStreamer support for them yet.
See https://bugzilla.gnome.org/show_bug.cgi?id=741063
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=737469
|
|
|
|
| |
Just in case the source doesn't want to give us that.
|
| |
|
|
|
|
| |
Stop thumbnailing when TotemGrilo object is destroyed.
|
| |
|
| |
|
|
|
|
|
|
| |
And make sure we don't simply return from a failed icon fetch!
https://bugzilla.gnome.org/show_bug.cgi?id=727748
|
|
|
|
| |
https://bugzilla.gnome.org/show_bug.cgi?id=728716
|
|
|
|
|
|
|
|
| |
In some locations, because the Euronews source would give out broken
URIs such as:
UNAVAILABLEUNAVAILABLE playpath=UNAVAILABLE swfVfy=1 swfUrl=http://euronews.com/media/player_live_1_14.swf live=1
https://bugzilla.gnome.org/show_bug.cgi?id=731224
|
|
|
|
| |
The code now lives directly in GTK+'s GtkIconTheme handling.
|