From 65f62adc6c5d6a7c061144edd6da63c1ea51729f Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Thu, 24 Nov 2022 10:16:23 +0100 Subject: opensubtitles: Fix blank dialogue when reopened totem_plugin_load_interface() used to call totem_interface_load_with_full_path() which itself called gtk_builder_connect_signals(). And as we didn't do that anymore when we started loading the file ourselves, gtk_widget_hide_on_delete() wasn't called so the dialogue was destroyed which we didn't expect. With help from Krifa75 Fixes: 2001dfe ("opensubtitles: Fix dialogue not showing up") Closes: #549 --- src/plugins/opensubtitles/opensubtitles.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/opensubtitles/opensubtitles.py b/src/plugins/opensubtitles/opensubtitles.py index 3163c377b..589ef10fb 100644 --- a/src/plugins/opensubtitles/opensubtitles.py +++ b/src/plugins/opensubtitles/opensubtitles.py @@ -455,6 +455,7 @@ class OpenSubtitles (GObject.Object, # pylint: disable=R0902 def _build_dialog (self): ui_file_path = os.path.dirname (os.path.abspath (__file__)) + sep + 'opensubtitles.ui' builder = Gtk.Builder.new_from_file (ui_file_path) + builder.connect_signals(None) # Obtain all the widgets we need to initialize combobox = builder.get_object ('language_combobox') -- cgit v1.2.1