From 7b85fb9361181c2eb45e1d056afca359c1b4338e Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Sat, 20 Mar 2021 13:47:03 +0100 Subject: libtracker-data: Reorder unref call The add_literal_binding() above keeps a ref to it, so it's not really used after free, but should help both Coverity and the casual reader. CID: #1501108 --- src/libtracker-data/tracker-sparql.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libtracker-data/tracker-sparql.c b/src/libtracker-data/tracker-sparql.c index 7d066f980..fd9ca99dc 100644 --- a/src/libtracker-data/tracker-sparql.c +++ b/src/libtracker-data/tracker-sparql.c @@ -1627,7 +1627,6 @@ _add_quad (TrackerSparql *sparql, tracker_binding_set_db_column_name (binding, "fts5"); tracker_select_context_add_literal_binding (TRACKER_SELECT_CONTEXT (sparql->context), TRACKER_LITERAL_BINDING (binding)); - g_object_unref (binding); fts_table = tracker_sparql_add_fts_subquery (sparql, graph, subject, TRACKER_LITERAL_BINDING (binding)); @@ -1635,6 +1634,7 @@ _add_quad (TrackerSparql *sparql, db_table = fts_table; share_table = FALSE; is_fts = TRUE; + g_object_unref (binding); } else if (property != NULL) { db_table = tracker_property_get_table_name (property); -- cgit v1.2.1