From a066b1e607e182167f6e6e083df1e963df421ef9 Mon Sep 17 00:00:00 2001
From: Robert Mader <robert.mader@posteo.de>
Date: Mon, 23 Aug 2021 17:36:30 +0200
Subject: ci: Avoid deadlock while reading uncrustify output

The docu for `Popen.wait()` says:
> This will deadlock when using stdout=PIPE and/or stderr=PIPE and
> the child process generates enough output to a pipe such that it
> blocks waiting for the OS pipe buffer to accept more data.
---
 check-style.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'check-style.py')

diff --git a/check-style.py b/check-style.py
index f3f718c90..7275af042 100755
--- a/check-style.py
+++ b/check-style.py
@@ -76,11 +76,11 @@ def reformat_chunks(chunks, rewrite):
 
         # uncrustify chunk
         proc = subprocess.Popen(["uncrustify", "-c", uncrustify_cfg, "-f", tmp.name], stdout=subprocess.PIPE)
+        reindented = proc.stdout.readlines()
         proc.wait()
         if proc.returncode != 0:
             continue
 
-        reindented = proc.stdout.readlines()
         tmp.close()
 
         # Remove INDENT-ON/OFF comments
-- 
cgit v1.2.1