diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2007-01-20 21:54:28 +0000 |
|---|---|---|
| committer | Chris Wilson <cpwilson@src.gnome.org> | 2007-01-20 21:54:28 +0000 |
| commit | 9c70a15321c4f01cc87728c76958780eb58a2050 (patch) | |
| tree | e20cceae004311ac8a044551f525cfbed4084644 | |
| parent | 633016c80df82f651e3add9f947fcaacb4fc427e (diff) | |
| download | vte-9c70a15321c4f01cc87728c76958780eb58a2050.tar.gz | |
<kmaraas> ickle: sparse complains about dubious 1 bit bitfields if you use
2007-01-20 Chris Wilson <chris@chris-wilson.co.uk>
<kmaraas> ickle: sparse complains about dubious 1 bit bitfields
if you use gboolean instead of guint
<kmaraas> so s/gboolean/guint at line 166 and 174
<mariano> unless that changes the API, of course...
<kmaraas> it doesn't
<mariano> gboolean a:1 is not very correct anyways
<kmaraas> ickle: we've done the same change in other modules
<ickle> if I do it quick, behdad might not even notice ;)
* src/vte.h:
Convert signed single bit field to unsigned. The code
was setting it to 1 anyhow (and not -1 as the type indicated).
svn path=/trunk/; revision=1488
| -rw-r--r-- | ChangeLog | 15 | ||||
| -rw-r--r-- | src/vte.h | 4 |
2 files changed, 17 insertions, 2 deletions
@@ -1,5 +1,20 @@ 2007-01-20 Chris Wilson <chris@chris-wilson.co.uk> + <kmaraas> ickle: sparse complains about dubious 1 bit bitfields + if you use gboolean instead of guint + <kmaraas> so s/gboolean/guint at line 166 and 174 + <mariano> unless that changes the API, of course... + <kmaraas> it doesn't + <mariano> gboolean a:1 is not very correct anyways + <kmaraas> ickle: we've done the same change in other modules + <ickle> if I do it quick, behdad might not even notice ;) + + * src/vte.h: + Convert signed single bit field to unsigned. The code + was setting it to 1 anyhow (and not -1 as the type indicated). + +2007-01-20 Chris Wilson <chris@chris-wilson.co.uk> + Bug 398602 – Build Failure * src/vte.c: (vte_terminal_expose): @@ -163,7 +163,7 @@ typedef enum { struct _VteCharAttributes { long row, column; GdkColor fore, back; - gboolean underline:1, strikethrough:1; + guint underline:1, strikethrough:1; }; typedef struct _VteCharAttributes VteCharAttributes; @@ -171,7 +171,7 @@ typedef struct _VteCharAttributes VteCharAttributes; struct vte_char_attributes { long row, column; GdkColor fore, back; - gboolean underline:1, strikethrough:1; + guint underline:1, strikethrough:1; }; /* The widget's type. */ |