diff options
| author | Tomas Popela <tpopela@redhat.com> | 2018-07-23 10:55:52 +0200 |
|---|---|---|
| committer | David King <amigadave@amigadave.com> | 2019-01-21 14:38:59 +0000 |
| commit | 14d995eeb38b2173615736754bc9288670f185c0 (patch) | |
| tree | 2afab33c6ca59104d6e74cc228f46c5456b62bbb | |
| parent | 45292455a213671d2345fc15a87bb4810f0d43c8 (diff) | |
| download | yelp-14d995eeb38b2173615736754bc9288670f185c0.tar.gz | |
Check whether variable node is set before dereferencing it
yelp-3.28.1/libyelp/yelp-info-parser.c:766: dereference: Dereferencing a pointer that might be null "node" when calling "strncmp".
| -rw-r--r-- | libyelp/yelp-info-parser.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libyelp/yelp-info-parser.c b/libyelp/yelp-info-parser.c index d0e767bc..0c383bfe 100644 --- a/libyelp/yelp-info-parser.c +++ b/libyelp/yelp-info-parser.c @@ -734,7 +734,7 @@ process_page (GtkTreeStore *tree, g_free (next); next = NULL; } - if (g_str_equal (node, "Top") && prev != NULL) { + if (node && g_str_equal (node, "Top") && prev != NULL) { g_free (prev); prev = NULL; } @@ -763,7 +763,7 @@ process_page (GtkTreeStore *tree, } if (prev && g_ascii_strncasecmp (prev, "(dir)", 5)) { - if (strncmp (node, "Top", 3)) { + if (node && strncmp (node, "Top", 3)) { /* Special case the Top node to always appear first */ } else { page = node2page (nodes2pages, prev); |