summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDon Scorgie <dscorgie@src.gnome.org>2008-08-12 19:06:55 +0000
committerDon Scorgie <dscorgie@src.gnome.org>2008-08-12 19:06:55 +0000
commit13d72ada90cd90b01933c86bd93ba46acfc206f9 (patch)
tree19bd0de7dad568441f2251a6309bc952d108aba7
parent46aa17fc19ca76cff4a323f7112fc76e8cea17b5 (diff)
downloadyelp-13d72ada90cd90b01933c86bd93ba46acfc206f9.tar.gz
Fix string vulnerability bug #546364 - patch from Christian Persch
* src/yelp-window.c (window_error): Fix string vulnerability bug #546364 - patch from Christian Persch reported by Aaron Grattafiori svn path=/trunk/; revision=3173
-rw-r--r--ChangeLog7
-rw-r--r--src/yelp-window.c4
2 files changed, 9 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index 4482336a..ca9f8048 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-08-12 Don Scorgie <dscorgie@svn.gnome.org>
+
+ * src/yelp-window.c (window_error):
+ Fix string vulnerability
+ bug #546364 - patch from Christian Persch
+ reported by Aaron Grattafiori
+
2008-06-27 Luca Ferretti <elle.uca@libero.it>
* src/yelp-main.c: (main):
diff --git a/src/yelp-window.c b/src/yelp-window.c
index ef4a6cc0..01c0f8c3 100644
--- a/src/yelp-window.c
+++ b/src/yelp-window.c
@@ -1152,9 +1152,9 @@ window_error (YelpWindow *window, gchar *title, gchar *message, gboolean pop)
GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
GTK_MESSAGE_ERROR,
GTK_BUTTONS_OK,
- title);
+ "%s", title);
gtk_message_dialog_format_secondary_markup
- (GTK_MESSAGE_DIALOG (dialog), message);
+ (GTK_MESSAGE_DIALOG (dialog), "%s", message);
gtk_dialog_run (GTK_DIALOG (dialog));
gtk_widget_destroy (dialog);