summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTomas Popela <tpopela@redhat.com>2018-07-23 11:15:10 +0200
committerDavid King <amigadave@amigadave.com>2019-01-21 14:38:59 +0000
commit6b05dd2a96f210ea46d057c2c571987adceb1e89 (patch)
tree79f48c2e7925313e8f1cf2e7c6d47568697629ca
parent9252d10b415c62147f20bdedff82318dd303c73e (diff)
downloadyelp-6b05dd2a96f210ea46d057c2c571987adceb1e89.tar.gz
Check whether parser is null before dereferencing it
yelp-3.28.1/libyelp/yelp-man-parser.c:445: var_compare_op: Comparing "parser" to null implies that "parser" might be null. yelp-3.28.1/libyelp/yelp-man-parser.c:449: var_deref_op: Dereferencing null pointer "parser".
-rw-r--r--libyelp/yelp-man-parser.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/libyelp/yelp-man-parser.c b/libyelp/yelp-man-parser.c
index 46073a2e..8d097820 100644
--- a/libyelp/yelp-man-parser.c
+++ b/libyelp/yelp-man-parser.c
@@ -442,10 +442,12 @@ void
yelp_man_parser_free (YelpManParser *parser)
{
guint k;
- if (parser) {
- for (k=0; k<MAN_FONTS; k++)
- g_free (parser->font_registers[k]);
- }
+
+ if (parser == NULL)
+ return;
+
+ for (k=0; k<MAN_FONTS; k++)
+ g_free (parser->font_registers[k]);
g_string_free (parser->accumulator, TRUE);
g_free (parser->title_str);
g_free (parser->section);