summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDon Scorgie <dscorgie@src.gnome.org>2007-07-07 13:42:15 +0000
committerDon Scorgie <dscorgie@src.gnome.org>2007-07-07 13:42:15 +0000
commit12acaca737765cb15544838c151ff97851f5c11e (patch)
tree36a18d97788381564a7dd7aaf94e02a22c4ad115
parent2325dfe0241b1eb9d6c53d51aadc81a477e54306 (diff)
downloadyelp-12acaca737765cb15544838c151ff97851f5c11e.tar.gz
Fix param problem in yelp-toc resulting in badness
* src/yelp-toc.c: Fix param problem in yelp-toc resulting in badness svn path=/branches/yelp-spoon/; revision=2830
-rw-r--r--ChangeLog12
-rw-r--r--src/yelp-toc.c1
2 files changed, 13 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index b7f1538a..05dc4131 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2007-07-07 Don Scorgie <dscorgie@svn.gnome.org>
+
+ * src/yelp-toc.c:
+ Fix the most annoying error message in the world EVER
+ Unexpected async xlib errors generally mean threading issues
+ except, apparently, when you're trying to parse using libxml
+ in which case, they could mean anything. In this case, it
+ meant the params passed in was not NULL terminating.
+ Why this resulted in an unexpected xlib async reply is
+ left as an exercise to the reader. I spent 7 days trying to
+ figure it out.
+
2007-07-01 Don Scorgie <dscorgie@svn.gnome.org>
* src/yelp-toc.c:
diff --git a/src/yelp-toc.c b/src/yelp-toc.c
index 7d6cb966..0307ab8b 100644
--- a/src/yelp-toc.c
+++ b/src/yelp-toc.c
@@ -568,6 +568,7 @@ toc_process (YelpToc *toc)
gtk_icon_info_free (info);
}
+ params[params_i] = NULL;
while (!priv->info_processed || !priv->man_processed) {
g_thread_yield ();