| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
* top/maint.mk (sc_po_check): Sorting before removing the $(srcdir)/
prefix would have led to an unwarranted failure in GNU parted.
Sort after that transformation.
|
|
|
|
|
| |
* top/maint.mk (sc_po_check): Fix fatal typo in yesterday's change.
Patch by Bruno Haible.
|
|
|
|
|
|
|
|
| |
* top/maint.mk (po_file): Allow cfg.mk override.
(sc_po_check): Allow VPATH use.
Reported by Jiri Denemark.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
|
|
|
| |
Before, you would have had to create one .x-sc_ file per rule in order
to exempt offending files. Now, you may instead use a Make variable --
usually defined in cfg.mk -- whose name identifies the affected rule.
* top/maint.mk (_sc_excl): Define.
(VC_LIST_EXCEPT): Use it to exclude names on a per-rule basis.
(_sc_search_regexp): When not using VC_LIST_EXCEPT, exclude here, too.
|
|
|
|
|
| |
* top/maint.mk (sc_unmarked_diagnostics): Allow 0 or 1 space
between "ngettext" and the following "(".
|
|
|
|
|
| |
* top/maint.mk (sc_unmarked_diagnostics): Don't warn when
diagnostics are marked with ngettext.
|
|
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_empty_lines_at_EOF): Adjust so that
it also detects when a file lacks a newline at EOF.
(require_exactly_one_NL_at_EOF_): Renamed from
detect_empty_lines_at_EOF_. I opted not to rename the rule,
since people may well have .x-sc_... file names tied to the
existing name. Suggested by Eric Blake.
|
|
|
|
|
|
|
|
|
| |
* top/maint.mk (no-vc-detected): New rule.
(local-checks-available): Use it to avoid hanging if someone tries
'make syntax-check' from a tarball. Also append to any non-syntax
checks already defined in cfg.mk.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
| |
* top/maint.mk (sc_prohibit_stddef_without_use): New rule.
|
|
|
|
|
|
|
|
| |
* top/maint.mk (public-submodule-commit): Rewrite to avoid
merge-base --independent, which Ubuntu 10.04 git 1.7.0.4 lacks.
Reported by Matthias Bolte.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
| |
* top/maint.mk (gl_public_submodule_commit): Rename the variable
to be lower case.
|
|
|
|
| |
* top/maint.mk (GL_PUBLIC_SUBMODULE_COMMIT): New overridable variable.
|
|
|
|
|
|
|
|
| |
* top/maint.mk (public-submodule-commit): Prefix with $(AM_V_GEN),
to suppress printing of its commands... unless V=1.
Add git submodule's --quiet option to suppress printing of e.g.,
"Entering gnulib" output.
"cd" into $(srcdir) before running git submodule.
|
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_strcmp): Detect strcmp()!=0, as
documented. Also, detect strcmp((expr),expr) == 0. Exempt the
definition of STRNEQ.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
| |
* top/maint.mk (public-submodule-commit): New rule.
(submodule-checks): New variable.
(alpha beta stable): Depend on the variable.
|
|
|
|
| |
Run the new "make update-copyright" rule.
|
|
|
|
| |
* top/maint.mk (sc_texinfo_acronym): Add a URL in a comment.
|
|
|
|
|
| |
* top/maint.mk (gl_noteworthy_news_): Rename from "noteworthy"
and move definition closer to sole use.
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_test_double_equal): Also cover shell
scripts generated within C files, for libvirt.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_test_double_equal): Restrict this
test to files that contain something like #!/bin/sh.
Without this, coreutils would get two false positives in
the comments of C source files.
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_test_double_equal): New rule.
Based on a report by Matthias Bolte.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_bindtextdomain): Check for evidence that _()
will likely work.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
| |
* top/GNUmakefile (_is-dist-target): s/major/stable/ to match the
lists in maint.mk and announce-gen. Without this, "make stable"
would fail to ensure that $(VERSION) is up to date.
|
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_always_true_header_tests):
Don't use a literal \n in a halt=... assignment. It would not be
expanded, and the two \n bytes would appear in the diagnostic output
rather than the desired newline. Use halt=$$(printf ... instead.
(sc_vulnerable_makefile_CVE-2009-4029): Likewise.
|
|
|
|
|
|
|
| |
* top/maint.mk (v_etc_file): Prepend $(gnulib_dir)/, to avoid
false positives (whose names may be ill-chosen) when searching
non-VC'd files. Otherwise, a file named "a b/lib/version-etc.c"
would cause a false-positive.
|
|
|
|
|
| |
* top/maint.mk (news-check-lines-spec) New variable.
(news-check): Use "sed -n 1,10p" in place of "head".
|
|
|
|
|
|
|
| |
* build-aux/git-version-gen (tag_sed_script): New variable. Use it to
transform the output of "git describe" to the canonical form.
* top/GNUmakefile (_curr-ver): Pass $(git-version-gen-tag-sed-script) as
a second argument to `git-version-gen'.
|
|
|
|
|
|
|
| |
* top/maint.mk (def_sym_regex): Handle #undef as well as #define.
Allow more than one space before the symbol name.
(sc_prohibit_always-defined_macros): Use grep's -E, now that
the regexp uses alternation.
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are still other potentially non-portable uses of echo
throughout this file, if $(ME) contains \ or starts with -,
but this patch is a trivial step in the right direction.
* top/maint.mk (gzip_rsyncable): Convert all uses of echo -* to
printf.
Reported by Matthias Bolte.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
| |
* top/maint.mk (gl_extract_significant_defines_): Make exclusion
regexps tighter by anchoring at EOL, and make the new group "shy"
for slightly decreased overhead.
|
|
|
|
|
|
|
|
|
|
| |
Gnulib conditionally defines NSIG to 32 for some platforms. But since
NSIG is not mandated by standards, and there are platforms with 64
signals, we should not promise that NSIG is guaranteed.
* top/maint.mk (gl_extract_significant_defines_): Exclude NSIG.
Signed-off-by: Eric Blake <eblake@redhat.com>
|
|
|
|
|
|
|
|
| |
* top/maint.mk (.re-defmac): Remove rule.
(gl_trap_): Remove definition.
(sc_prohibit_always-defined_macros): Rewrite not to create and
depend on a temporary file. Instead, depend on GNU grep's ability
to read a list of regular expressions from stdin when given "-f -".
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With my recent change in init.sh from the two-line form:
-# : ${srcdir=.}
-# . "$srcdir/init.sh"; path_prepend_ .
+# . "${srcdir=.}/init.sh"; path_prepend_ .
I noticed that using the one-line form would cause this test
to fail with a false-positive, or to stop working altogether,
depending on whether help-version changed or all the tests did.
* top/maint.mk (_hv_regex): Remove this definition.
(_hv_regex_weak): Use a weak regex to select all init.sh-sourcing files.
(_hv_regex_strong): Use a stronger regex to check for conformance.
(sc_cross_check_PATH_usage_in_tests): Rewrite to use the above.
Give a separate diagnostic for lack of conforming use.
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_always-defined_macros): Reject the
definition of symbols defined by gnulib.
|
|
|
|
|
| |
* top/maint.mk (web-manual): Pass gendocs_options_ to gendocs.sh.
(gendocs_options_): New overridable variable.
|
|
|
|
|
|
|
| |
* top/maint.mk (translation_project_): Define default.
(announcement_Cc_, announcement_mail_headers_): Likewise.
(announcement): Invoke announce-gen with new --mail-headers option.
* build-aux/announce-gen: New option: --mail-headers=HEADERS.
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_strings_without_use): Reject inclusion of
strings.h in a file that does not also use strcasecmp, strncasecmp,
ffs or ffsll.
|
|
|
|
| |
* top/maint.mk: Remove stale, commented-out rules.
|
| |
|
|
|
|
|
|
| |
* top/maint.mk (gl_assured_headers_): Now that all names are on
one line, use sed's "g" modifier. Note that while the \.in\.h LHS
is not anchored to end of word, it should be adequate.
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_always_true_header_tests): Rework not
to run commands via $(shell...), and hence to incur cost only when
the new rule is actually run.
|
|
|
|
|
|
|
|
| |
Derive the list of guaranteed header names from gnulib/lib/*.in.h,
and use that to create a regexp used to detect all #if HAVE_..._H uses.
* top/maint.mk (sc_prohibit_always_true_header_tests): New rule.
(gl_assured_headers_, az_, AZ_): Define.
(gl_header_upper_case_or_, gl_have_header_regex_): Define.
|
| |
|
|
|
|
|
| |
* top/maint.mk (detect_empty_lines_at_EOF_): Clean up formatting.
Rename variable: s/two/last_two_bytes/
|
|
|
|
| |
* top/maint.mk (texinfo_suffix_re_): Fix default regexp.
|
| |
|
|
|
|
|
| |
* top/maint.mk ($(sc_z_rules_)): Remove the ":", "sc_" prefix and
" done" from each line that reports a syntax-check test duration.
|
|
|
|
| |
* top/maint.mk: Remove bogus include directive.
|
|
|
|
|
|
|
| |
* top/maint.mk (sc_prohibit_empty_lines_at_EOF): Use Perl-based
solution, rather than tail+Perl-based one. The latter would read
a few kilobytes from the end of each file, and did not handle empty
files properly.
|
|
|
|
|
|
| |
* top/maint.mk (sc_m_rules_): Save start time in a file.
(sc_z_rules_): New rules: remove temp file and print elapsed time.
(local-check): Interpose the .z rules
|