summaryrefslogtreecommitdiff
path: root/top
Commit message (Collapse)AuthorAgeFilesLines
...
* maint.mk: handle missing git with more gracePeter Rosin2012-12-311-2/+4
| | | | | | | | * top/maint.mk (no-submodule-changes, public-submodule-commit): Quietly proceed if git is not present. Copyright-paperwork-exempt: yes Signed-off-by: Peter Rosin <peda@lysator.liu.se>
* maint.mk: typofix in commentsStefano Lattarini2012-12-081-1/+1
|
* maint.mk: avoid extra forksStefano Lattarini2012-12-081-1/+1
| | | | | | * top/maint.mk (_cfg_mk): The GNU make manual documents that "$(wildcard FILE)" expands to empty if FILE doesn't exist. So use that instead of "$(shell test -f FILE && echo FILE)".
* maint.mk: avoid gratuitous failureTheophile Ranquet2012-11-211-2/+3
| | | | | | Reported by Stefano Lattarini in <http://lists.gnu.org/archive/html/bug-bison/2012-11/msg00022.html> * top/maint.mk (public-submodule-commit): Quote more safely.
* maint.mk: rename a new configurable variableJim Meyering2012-10-301-3/+3
| | | | | | * top/maint.mk (_gl_translatable_string_re): Rename from translation-markers: _gl_ prefix to insulate from user Makefile code, and the _re suffix to inform that it's a regular expression.
* maint.mk: let packages tweak sc_po_check patternEric Blake2012-10-261-2/+4
| | | | | | | | | | | | | libosinfo wants to look for XML files with translation markers of the form <_name>string to translate</_name>. Rather than globally adding this to the regex, I thought it would be easier to make it possible for cfg.mk to override the default pattern. https://www.redhat.com/archives/virt-tools-list/2012-October/msg00270.html * top/maint.mk (sc_po_check): Add translation-markers, to allow finding files with other translation markers. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: fix strict vs. lazy variable issues with RELEASEAkim Demaille2012-09-251-27/+35
| | | | | | | | | | | | | | * top/maint.mk (_equal): New function. (member_check): Strip the result to avoid spurious spaces. (url_dir_list): Do not use ifeq, which is strict, as it will require RELEASE_TYPE to be defined. (announcement_Cc_, announcement_mail_headers_): Likewise: instead of relying on ifeq, use $(release_type) to dispatch (lazily) onto... (announcement_Cc_alpha,announcement_mail_headers_alpha) (announcement_Cc_beta,announcement_mail_headers_beta) (announcement_Cc_stable,announcement_mail_headers_stable): these. (release): Do not depend on $(release-type), as it forces its evaluation. Bounce to it.
* maint.mk: formatting changesAkim Demaille2012-09-251-12/+12
| | | | * top/maint.mk: Indent bodies of if's.
* maint.mk: provide "make upload" to ease uploadingAkim Demaille2012-09-252-10/+28
| | | | | | | | | | | | | | | | See <http://lists.gnu.org/archive/html/bug-gnulib/2012-08/msg00028.html>. Do not depend simply on the current $(VERSION), as there may have been new commits since the tarball generation. Rather, rely on $(RELEASE), as "make release-commit" already does. For consistency, add "make release RELEASE='X.Y TYPE'" as an alias for "make TYPE". * top/maint.mk (upload_command, upload, release): New. (RELEASE_TYPE): If undefined, default to the second word of $(RELEASE). (VERSION): first word of $(RELEASE) is always right. (emit_upload_commands): Adjust. * top/README-release: Update.
* maint.mk: factor the validation of RELEASE_TYPEAkim Demaille2012-09-251-8/+24
| | | | | | | | | | With help from Jim Meyering. http://lists.gnu.org/archive/html/bug-gnulib/2012-09/msg00132.html * top/maint.mk (_empty, _sp): Move their definition earlier. (member-check, release-type): New. Use the latter instead of $(RELEASE_TYPE). Remove now useless local checks.
* maint.mk: silent rulesAkim Demaille2012-09-251-2/+4
| | | | | | | With help from Stefano Lattarini. * top/maint.mk (writable-files): Use $(AM_V_GEN). (announcement): Use $(AM_V_at).
* maint.mk: generalize _gl_tight_scope for non-recursive makeJim Meyering2012-09-181-1/+3
| | | | | | | * top/maint.mk (_gl_tight_scope): Remove a hard-coded assumption that *.h would describe additional .h files in the directory specified by $(_gl_TS_dir). I.e., add this... (_gl_TS_other_headers): New variable.
* maint.mk: exempt trailing blanks found in "binary" filesJim Meyering2012-09-181-0/+1
| | | | | | * top/maint.mk (sc_trailing_blank): Filter out any matches found in "binary" files, as reported by grep. Suggested by Richard W.M. Jones in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
* maint.mk: sc_prohibit_path_max_allocation: don't FP for UNIX_PATH_MAXJim Meyering2012-09-181-1/+1
| | | | | | * top/maint.mk (sc_prohibit_path_max_allocation): Avoid false-positive match for symbols like UNIX_PATH_MAX. Reported by Richard W.M. Jones in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
* maint.mk: teach sc_prohibit_magic_number_exit to accept 77Jim Meyering2012-09-181-1/+1
| | | | | | | | | * top/maint.mk (sc_prohibit_magic_number_exit): Do not complain about uses like "exit (77)". "77" is automake's "skip this test" exit code. It is not in the same category as "exit (0)" or "exit (1)", and besides, I know of no symbolic name for that 77. Reported by Richard W.M. Jones in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
* maint.mk: relax sc_prohibit_strcmp, to avoid a false positiveJim Meyering2012-09-181-1/+1
| | | | | | | * top/maint.mk (sc_prohibit_strcmp): Relax regexp, so as to match all uses of #define, not just those that start in column 1. Richard W.M. Jones reported a false positive in http://thread.gmane.org/gmane.comp.emulators.guestfs/1902
* maint.mk: avoid redundant file name in messageEric Blake2012-08-201-5/+5
| | | | | | | | | | | | | $(_sc_search_regexp) already prefixes its errors with $(ME), so failure on one of these rules looked like: maint.mk: maint.mk: replace strcmp calls above with STREQ/STRNEQ * top/maint.mk (sc_prohibit_strcmp, sc_unmarked_diagnostics) (sc_prohibit_defined_have_decl_tests, sc_const_long_option) (sc_makefile_path_separator_check): Remove bogus $(ME). Signed-off-by: Eric Blake <eblake@redhat.com>
* maintainer-makefile: Fix syntax error with dash.Simon Josefsson2012-08-071-2/+2
| | | | | * top/maint.mk (sc_vulnerable_makefile_CVE-2009-4029): Quote arguments. (sc_vulnerable_makefile_CVE-2012-3386): Likewise.
* maint.mk: sc_prohibit_magic_number_exit: avoid new false positivesJim Meyering2012-08-051-1/+1
| | | | | | * top/maint.mk (sc_prohibit_magic_number_exit): Also filter out matches for /error ?([^,]*)/. This avoids false-positives for strings like "Unknown error (252)", introduced via commit v0.0-7538-g92875a6.
* maint.mk: a "release-commit" wrapper to do-release-commit-and-tagAkim Demaille2012-08-012-8/+9
| | | | | | | | | | * build-aux/do-release-commit-and-tag: Move variable definitions together. ($branch): Instead of defaulting to "master", default to the current branch (as gnu-web-doc-update does). (help): Display the current values of the option arguments. * top/maint.mk (release-commit): New. * top/README-release: Simplify the corresponding step.
* maint.mk: use silent-rules support from AutomakeAkim Demaille2012-07-301-23/+26
| | | | | | * top/maint.mk (news-check, vc-diff-check, announcement) (no-submodule-changes, alpha beta stable, release-prep) (web-manual, update-copyright): Use $(AM_V_GEN) and $(AM_V_at).
* maint.mk: provide a web-manual-update targetAkim Demaille2012-07-302-9/+11
| | | | | * top/maint.mk: here. * top/README-release: Use it to simplify the web manual update step.
* README-release: shorten the circuit to post a newsAkim Demaille2012-07-301-6/+6
| | | | * top/README-release: Point directly to the news submission form.
* maint.mk: avoid a sub-shellJim Meyering2012-07-301-1/+1
| | | | * top/maint.mk (release-prep): Remove unneeded sub-shell.
* maint.mk: absolute VPATH issueAkim Demaille2012-07-301-3/+2
| | | | | * top/maint.mk (release-prep): Help Git find .git/. From Jim Meyering.
* maint.mk: absolute VPATH build fixAkim Demaille2012-07-291-4/+5
| | | | | * top/maint.mk (gpg_key_ID): Help git find .git when, for instance, $(srcdir) is not a parent of $(builddir).
* maint.mk: new rule: refresh-gnulib-patchesJim Meyering2012-07-271-0/+25
| | | | | | I noticed that 8 of coreutils' 9 gl/**/*.diff files was stale. Use this rule to refresh them. * top/maint.mk (refresh-gnulib-patches): New rule.
* maint.mk: forbid exit(-1)Eric Blake2012-07-201-2/+3
| | | | | | | | | Libvirt accidentally had an 'exit (-1)' which got by the syntax checker; generally, exiting with 255 is not a wise idea. * top/maint.mk (sc_prohibit_magic_number_exit): Detect negatives. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: minor simplification.Akim Demaille2012-07-171-1/+1
| | | | | * top/maint.mk (_sc_excl): Use $(or...) instead of $(if...) for default values.
* README-release: make it more legibleReuben Thomas2012-07-151-3/+9
| | | | * top/README-release: improve typography slightly.
* maint.mk: add leading "@" to quiet new "make syntax-check" ruleJim Meyering2012-07-151-1/+1
| | | | * top/maint.mk (sc_prohibit_defined_have_decl_tests): Add "@".
* maint.mk: new syntax check for HAVE_DECL checksEric Blake2012-07-131-0/+5
| | | | | | | | | | | | | | | | | Based on Karel's report, we might as well enforce a syntax check to help avoid future problems. https://lists.gnu.org/archive/html/coreutils/2012-06/msg00037.html Exempt a few files that still get picked up in the wild rather than as a full gnulib module with m4 files. * top/maint.mk (sc_prohibit_defined_have_decl_tests): New rule. * cfg.mk (exclude_file_name_regexp--sc_prohibit_defined_have_decl_tests): Exempt some false positives. Based on a report by Karel Zak. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: add sc_vulnerable_makefile_CVE-2012-3386Jim Meyering2012-07-091-0/+9
| | | | * top/maint.mk (sc_vulnerable_makefile_CVE-2012-3386): New rule.
* maint.mk: _sc_search_regexp, sc_vulnerable_makefile_CVE-2009-4029: fixJim Meyering2012-07-091-5/+7
| | | | | | | | | | | | | Bugs in both of those conspired to make the sc_vulnerable_makefile_CVE-2009-4029 rule 99% useless. _sc_search_regexp's handling of non-empty $in_files would filter out any offending file names. sc_vulnerable_makefile_CVE-2009-4029's choice of in_files value meant there would be no match in most projects, due to the presence of two or more Makefile.in files. * top/maint.mk (_sc_search_regexp) [in_vc_files,in_files]: Clarify. Fix a bug in how a non-empty $$in_files was processed: (sc_vulnerable_makefile_CVE-2009-4029): Fix erroneous use of in_files: in spite of the name, it's a regexp, not a list of file names.
* maint.mk: fix typo in code to derive GPG key at release timeJim Meyering2012-06-171-1/+1
| | | | * top/maint.mk (gpg_key_ID): Fix typo: $3 -> $$3
* announce-gen: VPATH issuesAkim Demaille2012-06-121-0/+1
| | | | | | * build-aux/announce-gen (--srcdir): New option, used to trim the $srcdir part of the path from $builddir to NEWS. * top/maint.mk (announcement): Adjust.
* gnu-web-doc-update: VPATH buildsAkim Demaille2012-06-121-1/+3
| | | | | | | | | | | | | * build-aux/gnu-web-doc-update (--builddir): New option. Revamp the handling of options. Prefer $(...) to `...`. Don't pass --tmpdir=. to mktemp, it is useless given that we specify the template, and it is GNU mktemp specific. Prefer set -e to long series of &&. Restore the initial git branch, not "master". Properly initialize submodules (don't rely only on bootstrap) Do not reconfigure blindly, use config.status. * top/README-release: Update instructions for gnu-web-doc-update.
* maint.mk: revert most of the previous change re "all these"Jim Meyering2012-06-111-1/+1
| | | | | | * top/maint.mk (prohibit_undesirable_word_seq_RE_): Remove that pair. For rationale, see the discussion at http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/30912
* maint.mk: prohibit common grammar error: "all these"Jim Meyering2012-06-101-1/+1
| | | | | | * top/maint.mk (prohibit_undesirable_word_seq_RE_): Add "all these" to the list of prohibited word sequences. It should be "all of these". * lib/tempname.c (__gen_tempname): Fix one of them.
* do-release-commit-and-tag: support VPATH buildsAkim Demaille2012-06-071-2/+7
| | | | | | | | | | | | | | | | * build-aux/do-release-commit-and-tag: Prefer $(...) to `...`. (noteworthy): Defined earlier to factor its value. (noteworthy_stub): New. Use it to factor. (help_version): Split into... (help, version): these. Adjust the option processing part. Support "--option=value" in addition to "--option value". (builddir): New. (--builddir): New option. * top/README-release: Document this. Reword slightly so that the reader cannot understand that he has to do these steps before calling do-release-commit-and-tag.
* maint.mk: fix VPATH issues.Akim Demaille2012-06-071-2/+2
| | | | | * top/maint.mk (news-check): GNU Make understand $< very well. (release-prep): NEWS is in $(srcdir).
* maint.mk: add strncpy-prohibiting syntax-check ruleJim Meyering2012-05-251-0/+8
| | | | * top/maint.mk (sc_prohibit_strncpy): New rule, from coreutils.
* maint.mk: compute $(gpg_key_ID) more portablyJim Meyering2012-05-241-1/+1
| | | | | | | * top/maint.mk (gpg_key_ID): Use awk in place of sed '{...;...;}'. That use of sed is not portable to some fringe systems. Reported by Paul Eggert in http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/30793/focus=30802
* maint.mk: gpg_key_ID: use sed more portablyAkim Demaille2012-05-231-2/+2
| | | | | | * top/maint.mk (gpg_key_ID): End sed block with a semicolon before the closing brace. (refresh-po): Fuse two sed invocations into one.
* maint.mk: expand syntax-check rule to catch @xref and @pxref abuseAkim Demaille2012-04-171-1/+8
| | | | | | * top/maint.mk (prohibit_undesirable_word_seq_RE_): An @xref{...} should start a sentence and should not be preceded by "see", "see also", etc. Add heuristic for @pxref too.
* maint.mk: fix syntax checks without exclusionsEric Blake2012-03-291-1/+1
| | | | | | | | | | | Commit 727075d0 skipped per-line exclusions if ${exclude} is left undefined, but was immediately broken by commit 44de969c which always initialized the variable to the empty string. * top/maint.mk (_sc_search_regexp): Allow for empty variable. Reported by Daniel P. Berrange. Signed-off-by: Eric Blake <eblake@redhat.com>
* README-release: simplify slightlyReuben Thomas2012-03-201-4/+4
| | | | * top/README-release: Run "git checkout master" only once.
* quote: fix syntax-checkAkim Demaille2012-03-131-1/+2
| | | | | * top/maint.mk (sc_prohibit_quote_without_use): quote.h also exports quote_quoting_options.
* maint: don't specify XZ_OPT=-9ev in dist-related ruleJim Meyering2012-03-021-1/+1
| | | | | | | | | Using xz's -9 option is warranted only if you have a very large tarball (see xz's documentation for the sizes vs. presets), and requires 64MiB of memory at decompression time. * top/maint.mk (alpha beta stable): Don't specify XZ_OPT=-9ev. Automake's default of just "-e" is fine. Override on a per-package basis by setting XZ_OPT e.g., in cfg.mk.
* maint.mk: allow announcement for non-gnulib projectEric Blake2012-03-011-1/+2
| | | | | | | | | | | | | | Currently, autoconf does not use a gnulib submodule; this tripped up the 'make beta' with: announce-gen: when specifying gnulib as a tool, you must also specify --gnulib-version=V, where V is the result of running git describe in the gnulib source directory. Try 'announce-gen --help' for more information. * maint.mk (announcement): Skip gnulib version if not used. Signed-off-by: Eric Blake <eblake@redhat.com>