summaryrefslogtreecommitdiff
path: root/top
Commit message (Collapse)AuthorAgeFilesLines
...
* maint.mk: avoid spurious failure of _sc_search_regexp-using testsJim Meyering2012-03-011-0/+11
| | | | | | * top/maint.mk: Initialize _sc_search_regexp parameters, so that envvar settings cannot interfere. Otherwise, setting envvars like prohibit=foo require=bar, etc. would cause spurious test failures.
* maint.mk: add per-line exclusions to prohibitionsEric Blake2012-03-011-15/+23
| | | | | | | | | | | | | | | | | | | | _sc_search_regexp would let you skip entire files, but not individual lines, until now. As proof that adding in a new per-line regex exception mechanism is useful, I found three syntax checks that were previously open-coded, only because they had to exclude individual lines. The exclude filtering is done on 'file:line:contents' output from grep, rather than the original files, so filtering for empty lines is a no-op, and searching for contents anchored at the beginning of the line in the original file should instead be anchored against ':' at the time of the filtering. * maint.mk (_sc_search_regexp): Add $exclude parameter. (sc_prohibit_strcmp, sc_unmarked_diagnostics) (sc_const_long_option): Use it. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: tell sc_prohibit_strcmp to ding "0 == strcmp (...)", tooJim Meyering2012-02-241-2/+3
| | | | | | | * top/maint.mk (sc_prohibit_strcmp): Also prohibit uses of strcmp uses with "==" *before* the call, e.g., 0 == strcmp (...) Remove now-unnecessary str''cmp obfuscation. Suggested by Akim Demaille.
* README-release: make it easier to execute commandsReuben Thomas2012-02-181-4/+8
| | | | * top/README-release: break commands out on to separate lines.
* GNUmakefile: simplify detection of unconfigured treesStefano Lattarini2012-02-161-12/+2
| | | | | | * top/GNUmakefile: Use $(wildcard) instead of $(shell) to determine whether the tree make is being run from is already configured or not. Related simplifications.
* README-release: various improvementsReuben Thomas2012-02-111-10/+10
|
* README-release: capitalize a word and split a lineReuben Thomas2012-02-091-2/+4
| | | | * top/README-release: Fix punctuation and spacing.
* maint.mk: also prohibit lower-case @var@Eric Blake2012-02-071-2/+2
| | | | | | | * top/maint.mk (sc_makefile_at_at_check): Enhance check to cover lower case, like @top_srcdir@. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: sc_prohibit_canonicalize_without_use: avoid false positiveJim Meyering2012-01-291-1/+1
| | | | | * top/maint.mk (sc_prohibit_canonicalize_without_use): Also detect uses of canonicalize_file_name.
* doc: clarify README-releaseJim Meyering2012-01-281-2/+2
| | | | | | | | * top/README-release: Clarify: you should make a point to have the latest stable versions of build tools in your PATH, and the reference to buildreq is solely for its list of tool names, not for its minimal-functional version numbers. Prompted by discussion with Reuben Thomas and Gary V. Vaughan.
* maint.mk: use more readable (yet functionally equivalent) quotingJim Meyering2012-01-281-4/+4
| | | | | | | | | | | | | It is common to quote a single quote in a single quoted string like this: '...'\''...'. Unless you know the idiom, that looks like gibberish, so prefer to double-quote the string when possible. Then you can use a more readable, lone single quote: "...'..." * top/maint.mk (sc_cast_of_argument_to_free): Quoting like this "don't" is more readable than the equivalent 'don'\''t'. (sc_cast_of_x_alloc_return_value): Likewise. (sc_cast_of_alloca_return_value): Likewise. (sc_makefile_path_separator_check): Similar: use ":" in '...', rather than '\'':'\''.
* maint: enable sc_prohibit_hash_pjw_without_useJim Meyering2012-01-211-1/+1
| | | | | | | * cfg.mk: Enable sc_prohibit_hash_pjw_without_use. * top/maint.mk (sc_prohibit_hash_pjw_without_use): Adjust regexp to match any use of \<hash_pjw\>, i.e., not necessarily with a following " (".
* maint.mk: fix description in commentJim Meyering2012-01-101-1/+1
| | | | * top/maint.mk (require_exactly_one_NL_at_EOF_): Fix comment.
* In commentary, do not use ` to quote.Paul Eggert2012-01-052-14/+14
|
* Use ', not `, for quoting output.Paul Eggert2012-01-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * build-aux/announce-gen (usage, sizes, print_news_deltas) (print_changelog_deltas, get_tool_versions, main program): * build-aux/git-version-gen: * build-aux/gitlog-to-changelog (usage, parse_amend_file): * build-aux/move-if-change (help): * build-aux/useless-if-before-free (usage, main program): * check-module (parse_module_file, usage) (find_included_lib_files, check_module): * lib/argmatch.c (main) [TEST]: * lib/argp-help.c (_help): * lib/getopt1.c (main) [TEST]: * lib/git-merge-changelog.c (usage): * lib/xstrtol-error.c (xstrtol_error): * m4/alloca.m4 (_AC_LIBOBJ_ALLOCA): * m4/argz.m4 (gl_FUNC_ARGZ): * m4/bison.m4 (gl_BISON): * m4/calloc.m4 (gl_FUNC_CALLOC_GNU): * m4/extensions.m4 (AC_USE_SYSTEM_EXTENSIONS): * m4/flexmember.m4 (AC_C_FLEXIBLE_ARRAY_MEMBER): * m4/fpending.m4 (gl_PREREQ_FPENDING): * m4/gc-random.m4 (gl_GC_RANDOM): * m4/intl.m4 (gt_CHECK_DECL): * m4/link-follow.m4 (gl_FUNC_LINK_FOLLOWS_SYMLINK): * m4/longlong.m4 (AC_TYPE_LONG_LONG_INT) (AC_TYPE_UNSIGNED_LONG_LONG_INT): * m4/ls-mntd-fs.m4 (gl_LIST_MOUNTED_FILE_SYSTEMS): * m4/lstat.m4 (gl_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK): * m4/onceonly.m4 (AC_CHECK_FUNCS_ONCE): * m4/posixver.m4 (gl_DEFAULT_POSIX2_VERSION): * tests/test-dirname.c (main): * tests/test-getpass.c (main): * tests/test-iconvme.c (main): * tests/test-parse-datetime.c (LOG): * tests/test-xstrtoimax.sh: * tests/test-xstrtol.sh: * tests/test-xstrtoll.sh: * tests/test-xstrtoumax.sh: * tests/unigbrk/test-uc-is-grapheme-break.c (main): * top/GNUmakefile (abort-due-to-no-makefile): Quote 'like this', not `like this', as per the recent change to the GNU coding standards.
* maint.mk: remove temporary transition aid from over 1.5 years agoJim Meyering2012-01-031-9/+0
| | | | | | | * top/maint.mk (_prohibit_regexp): Remove definition whose sole purpose was to aid in the transition (avoiding silent malfunction) from that old name to the new _sc_search_regexp. This shim was added by commit 219c504b.
* maint: update all copyright year number rangesJim Meyering2012-01-012-2/+2
| | | | Run "make update-copyright".
* README-release: fix punctuationReuben Thomas2011-12-181-1/+1
| | | | * top/README-release: s/:/./
* maint.mk: add syntax check for use of compare from init.shEric Blake2011-11-291-0/+10
| | | | | | | | | | | | Comparing expected against actual gives more consistent diff listings when reporting test failures. Enforce this idiom on test files that use init.sh, and allow projects to recognize an alternate pattern for recognizing tests scripts that use a compare function. * top/maint.mk (sc_prohibit_reversed_compare_failure): New rule, moved here from coreutils. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: fix tight-scope.mk generation in VPATH builds.Gary V. Vaughan2011-11-151-1/+1
| | | | | | | | * top/maint.mk (tight-scope.mk): Make sure to prefix file reference with $(srcdir) so that the file is found correctly even when running `make syntax-check' in a VPATH build. Signed-off-by: Gary V. Vaughan <gary@gnu.org>
* GNUmakefile: behave when Makefile is missing.Simon Josefsson2011-11-081-0/+5
| | | | * top/GNUmakefile: Always initialize _build-aux and _autoreconf.
* maint.mk: extract GPG key ID without using a temporary fileJim Meyering2011-11-081-3/+3
| | | | | | * top/maint.mk (gpg_key_ID): Extract GPG key ID from signed tag, but without using a temporary file. Based on a suggestion from Werner Koch in http://thread.gmane.org/gmane.comp.encryption.gpg.devel/16496
* maint.mk: silence new syntax checkEric Blake2011-11-071-1/+1
| | | | | | * top/maint.mk (sc_prohibit_dirent_without_use): Add missing @. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: also prohibit inclusion of dirent.h without useJim Meyering2011-11-051-0/+10
| | | | * top/maint.mk (sc_prohibit_dirent_without_use): New rule.
* GNUmakefile: reenable "make syntax-check" for most projectsJim Meyering2011-10-301-1/+2
| | | | | | | | | | Since Friday's commit 05e2d798, "maint.mk: don't maintain a second build-aux variable", "syntax-check" would do nothing but succeed with the "No version control files detected..." diagnostic (unless you happened to override _build-aux via cfg.mk). * top/GNUmakefile (_autoreconf, _build-aux): Move default definitions to precede inclusion of maint.mk. Otherwise, these variables would be used undefined in any project that does not override the default.
* maint.mk: don't maintain a second build-aux variable.Gary V. Vaughan2011-10-281-8/+12
| | | | | | | | | * maint.mk (build_aux): Removed. The maintainer-makefile module depends on GNUmakefile, which already maintains a cfg.mk overridable $(_build-aux) for projects with a non-standard build-aux directory location, although without the $(srcdir) prefix. Use that variable consistently instead of introducing a second one. Adjust all call sites.
* maint.mk: fix a bug in sc_prohibit_stddef_without_useJim Meyering2011-10-251-1/+1
| | | | | | * top/maint.mk (sc_prohibit_stddef_without_use): Don't require / *\(/ after symbols like NULL, size_t, etc. Reported by Alfred M. Szmidt.
* maint.mk: exempt ENODATA from a syntax-check ruleJim Meyering2011-10-251-1/+3
| | | | | | | * top/maint.mk (gl_extract_significant_defines_): Also exempt ENODATA from the sc_prohibit_always-defined_macros syntax-check rule. Add a comment. See this for more details: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/28739/focus=28795
* readme-release: improve safety of release prep instructions.Gary V. Vaughan2011-10-231-8/+6
| | | | | | | | | | * README-release: Don't git pull all branches when only master is needed for the release process. Run make maintainer-clean before changing trees and merging. Don't try to run ./configure right after git pull in case files that influence the bootstrap process have changed, move the ./configure step to after running ./bootstrap. Don't bootstrap "one last time"... it's the first time!
* maint.mk: Respect $(build_aux) in web-manual rule.Gary V. Vaughan2011-10-191-1/+1
| | | | | * top/maint.mk (web-manual): Find gen-announce script in user's $(build_aux) directory instead of hard-coding 'build-aux'.
* maint.mk: adjust a release-related rule not to require use of gzipJim Meyering2011-10-011-7/+11
| | | | | | * top/maint.mk (writable-files): Don't hard-code use of .tar.gz. Instead, check each file in $(DIST_ARCHIVES). This is better for projects that build only .tar.xz files. Also fix an erroneous test.
* maint.mk: avoid warnings from perl about missing filesMartin von Gagern2011-09-191-1/+2
| | | | | | * top/maint.mk (def_sym_regex): Ignore files listed in $(gl_other_headers_) that do not exist, say because a project does not use a corresponding module.
* maint.mk: sc_tight_scope: propagate failure from sub-makeJim Meyering2011-09-141-3/+5
| | | | | * top/maint.mk (sc_tight_scope): Actually initialize and use $fail. Reported by Martin von Gagern.
* maint.mk: mark the post-release commit log with "maint: " prefixJim Meyering2011-09-081-3/+3
| | | | | * top/maint.mk (emit-commit-log): Add "maint: " prefix to the one-line commit-log summary.
* doc: fix typo in README-releaseReuben Thomas2011-08-201-1/+1
| | | | * top/README-release: Capitalize first word of a sentence.
* maint.mk: relax the default _gl_TS_function_match regexpJim Meyering2011-08-021-1/+1
| | | | | | * top/maint.mk (_gl_TS_function_match): Don't require at least one space between function name and "(" in an "extern" declaration. That would fail to match a decl with no space there: extern void foo();
* maint.mk: avoid sc_prohibit_always-defined_macros failure in coreutilsJim Meyering2011-07-271-0/+1
| | | | | | | | | * top/maint.mk (gl_extract_significant_defines_): Now that SA_RESETHAND and SA_RESTART are #defined (albeit conditionally) in gnulib/lib/signal.in.h, and now that we recommend to define-if-undefined those two symbols in application code, we must filter them out of the "significant" list. This avoids a "make syntax-check" failure in coreutils.
* maint.mk: prohibit inclusion of "verify.h" without useJim Meyering2011-07-211-0/+6
| | | | * top/maint.mk (sc_prohibit_verify_without_use): New rule.
* * top/maint.mk: Adjust to new noreturn support.Paul Eggert2011-07-121-2/+1
| | | | | (gl_extract_significant_defines_): Omit pattern ATTRIBUTE_NORETURN. (def_sym_regex): Do not remove ATTRIBUTE_NORETURN.
* maint.mk: correct omissions in prohibit_argmatch_without_use checkJim Meyering2011-07-031-1/+1
| | | | | | | This rule would mistakenly report that argmatch.h is included without use even when both the argmatch and invalid_arg macro were used. * top/maint.mk (sc_prohibit_argmatch_without_use): Also detect uses of argmatch and invalid_arg.
* maint.mk: enhance useless header checksEric Blake2011-06-241-30/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Libvirt was mistakenly using <intprops.h> instead of "intprops.h" in one place; when I fixed that, I was surprised to get a syntax-check failure from an unused header. * top/maint.mk (_sc_header_without_use): Check both include styles. (sc_prohibit_assert_without_use) (sc_prohibit_close_stream_without_use) (sc_prohibit_getopt_without_use) (sc_prohibit_quotearg_without_use) (sc_prohibit_quote_without_use) (sc_prohibit_long_options_without_use) (sc_prohibit_inttostr_without_use) (sc_prohibit_ignore_value_without_use) (sc_prohibit_error_without_use, sc_prohibit_xalloc_without_use) (sc_prohibit_hash_without_use, sc_prohibit_cloexec_without_use) (sc_prohibit_posixver_without_use, sc_prohibit_same_without_use) (sc_prohibit_hash_pjw_without_use) (sc_prohibit_safe_read_without_use) (sc_prohibit_argmatch_without_use) (sc_prohibit_canonicalize_without_use) (sc_prohibit_root_dev_ino_without_use) (sc_prohibit_openat_without_use) (sc_prohibit_c_ctype_without_use) (sc_prohibit_signal_without_use) (sc_prohibit_stdio--_without_use) (sc_prohibit_stdio-safer_without_use) (sc_prohibit_strings_without_use) (sc_prohibit_intprops_without_use) (sc_prohibit_stddef_without_use) (sc_prohibit_xfreopen_without_use): Update clients. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: update sc_prohibit_intprops_without_useEric Blake2011-06-241-2/+8
| | | | | | | | This syntax check needs to reflect commit 8cc0fee and following. * top/maint.mk (_intprops_names): Match recent changes. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: test further PATH_MAX issuesEric Blake2011-06-231-5/+5
| | | | | | | | * top/maint.mk (sc_prohibit_path_max_array): Rename... (sc_prohibit_path_max_allocation): ...and also test alloca. Suggested by Jim Meyering. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: add syntax-check to avoid char[PATH_MAX]Eric Blake2011-06-221-0/+9
| | | | | | | | | | | | POSIX allows PATH_MAX to be undefined. And even if you use the gnulib pathmax module, where "pathmax.h" guarantees a definition, the definition might not be constant or might be so large as to be wasteful or cause stack overflows. PATH_MAX should only be used as a limit or hueristic, not an array size. * top/maint.mk (sc_prohibit_path_max_array): New rule. Signed-off-by: Eric Blake <eblake@redhat.com>
* maint.mk: sc_unmarked_diagnostics: don't hard-code "error"Jim Meyering2011-06-041-1/+6
| | | | | | * top/maint.mk (sc_unmarked_diagnostics): Don't hard-code the function name, "error". (_gl_translatable_diag_func_re): New configurable variable.
* maint.mk: add three prohibit-header-without-use rulesJim Meyering2011-06-041-0/+10
| | | | | | | Prohibit use of cloexec.h, posixver.h, same.h without use. * top/maint.mk (sc_prohibit_cloexec_without_use): New rule. (sc_prohibit_posixver_without_use): Likewise. (sc_prohibit_same_without_use): Likewise.
* maint.mk: more tight_scope improvementsJim Meyering2011-05-231-14/+18
| | | | | | | | | * top/maint.mk: (_gl_TS_var_match): Use $(_gl_TS_extern) here, too. (_gl_TS_headers): Define only in if-0'd block. (_gl_TS_dir): Omit the $(srcdir)/ prefix. Sometimes we need it, sometimes we must *not* use it. Adjust uses accordingly. (sc_tight_scope): Use much simpler grep-based test to determine whether we skip this rule.
* maint.mk: generalize/improve the tight-scope ruleJim Meyering2011-05-231-19/+39
| | | | | | | | | | | | | * top/maint.mk: Emit a warning when the test is skipped. (_gl_TS_dir): Add $(srcdir)/ prefix. (_gl_TS_function_match): Simplify, rather than trying to enumerate common types. Otherwise, it would fail to match an "extern unsigned char const *" declaration in idutils. (_gl_TS_extern): Do not endorse use of "XTERN", but do provide a way to support use of that type of macro. (_gl_TS_var_match): Simplify regexp. (_gl_TS_obj_files): New configurable variable. (_gl_TS_headers): Likewise.
* maint.mk: three new prohibit_<HDR>_without_use rulesJim Meyering2011-05-181-0/+14
| | | | | | * top/maint.mk (sc_prohibit_stdio--_without_use): New rule. (sc_prohibit_stdio-safer_without_use): Likewise. (sc_prohibit_xfreopen_without_use): Likewise.
* maint.mk: exclude compiler symbols from sc_tight_scopePádraig Brady2011-05-181-3/+6
|
View Lorry Controller Status