From 3a8a76d5b33b734ebd2b6436c00b6770e1112e19 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Sat, 4 Sep 2010 12:45:22 +0200
Subject: tests: prohibit augmenting PATH via TESTS_ENVIRONMENT

* Makefile (sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT): New rule.
---
 Makefile | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

(limited to 'Makefile')

diff --git a/Makefile b/Makefile
index 0596ba6a57..345e3028a3 100644
--- a/Makefile
+++ b/Makefile
@@ -13,7 +13,9 @@ info html dvi pdf:
 	cd doc && $(MAKE) $@ && $(MAKE) mostlyclean
 
 # Perform some platform independent checks on the gnulib code.
-check: sc_prefer_ac_check_funcs_once
+check: \
+  sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT			\
+  sc_prefer_ac_check_funcs_once
 
 sc_prefer_ac_check_funcs_once:
 	if test -d .git; then						\
@@ -22,6 +24,14 @@ sc_prefer_ac_check_funcs_once:
                    in modules/ 1>&2; exit 1; } || :			\
 	else :; fi
 
+sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT:
+	if test -d .git; then						\
+          url=http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/22874;	\
+	  git grep '^[	 ]*TESTS_ENVIRONMENT += PATH=' modules		\
+	    && { printf '%s\n' 'Do not augment PATH via TESTS_ENVIRONMENT;' \
+		 "  see <$$url>" 1>&2; exit 1; } || :			\
+	else :; fi
+
 # Regenerate some files that are stored in the repository.
 regen: MODULES.html
 
-- 
cgit v1.2.1