From 636b8d6abf5b75d3cd96949c58519f100779c7e2 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 28 Jan 2009 09:27:32 +0100 Subject: useless-if-before-free: correction It does *not* recognize "if (p != (void*)0) free(p);", since the RHS in this example may not contain ")" --- build-aux/useless-if-before-free | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'build-aux/useless-if-before-free') diff --git a/build-aux/useless-if-before-free b/build-aux/useless-if-before-free index a2fc773c35..696c62147c 100755 --- a/build-aux/useless-if-before-free +++ b/build-aux/useless-if-before-free @@ -2,9 +2,9 @@ # Detect instances of "if (p) free (p);". # Likewise for "if (p != NULL) free (p);". And with braces. # Also detect "if (NULL != p) free (p);". -# And with 0 or "(void *)0" in place of NULL. +# And with 0 in place of NULL. -my $VERSION = '2009-01-28 08:16'; # UTC +my $VERSION = '2009-01-28 08:23'; # UTC # The definition above must lie within the first 8 lines in order # for the Emacs time-stamp write hook (at end) to update it. # If you change this file with Emacs, please let the write hook @@ -89,9 +89,7 @@ EOF sub is_NULL ($) { my ($expr) = @_; - return ($expr eq 'NULL' - || $expr eq '0' - || $expr =~ /^\(\s*(char|void)\s*\*\s*\)\s*0$/); + return ($expr eq 'NULL' || $expr eq '0'); } { -- cgit v1.2.1