From 46540554bb4564e2929d5fecdae194701142777d Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 21 Dec 2021 10:43:56 -0800 Subject: Move AM_V_GEN to recipe start MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is especially needed when building Emacs, as it uses ‘AM_V_GEN=@$(info GEN $@)', which means the GEN line is output by GNU make just before the recipe runs, regardless of where AM_V_GEN appears in the recipe. And it’s also good practice even if the default Automake ‘AM_V_GEN=@echo GEN $@;’ is used, as it’s better to output the GEN line consistently at the start of every recipe, even if this precedes a preparatory command that almost always works silently. * modules/arpa_inet, modules/dynarray, modules/net_if: * modules/netinet_in, modules/scratch_buffer, modules/selinux-h: * modules/sys_file, modules/sys_ioctl, modules/sys_random: * modules/sys_resource, modules/sys_select, modules/sys_socket: * modules/sys_stat, modules/sys_time, modules/sys_times: * modules/sys_types, modules/sys_uio, modules/sys_utsname: * modules/sys_wait, modules/unicase/special-casing, top/maint.mk: Use AM_V_GEN only at the start of each recipe. --- modules/sys_times | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'modules/sys_times') diff --git a/modules/sys_times b/modules/sys_times index 704fc17cb7..68cb605185 100644 --- a/modules/sys_times +++ b/modules/sys_times @@ -21,8 +21,8 @@ BUILT_SOURCES += sys/times.h # We need the following in order to create when the system # doesn't have one that works with the given compiler. sys/times.h: sys_times.in.h $(top_builddir)/config.status $(WARN_ON_USE_H) $(ARG_NONNULL_H) - $(AM_V_at)$(MKDIR_P) '%reldir%/sys' - $(AM_V_GEN)rm -f $@-t $@ && \ + $(AM_V_GEN)$(MKDIR_P) '%reldir%/sys' + $(AM_V_at)rm -f $@-t $@ && \ { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \ sed -e 's|@''GUARD_PREFIX''@|${gl_include_guard_prefix}|g' \ -e 's/@''HAVE_SYS_TIMES_H''@/$(HAVE_SYS_TIMES_H)/g' \ -- cgit v1.2.1