summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikos Mavrogiannopoulos <nmav@redhat.com>2017-01-02 14:55:14 +0100
committerNikos Mavrogiannopoulos <nmav@redhat.com>2017-01-02 16:07:29 +0100
commit7486c3c76604d71b8893e1c253b828fa9b9824b4 (patch)
treeec6308700e4b75bd4ff886cf1347663bd4703507
parent10028bd326e47f731a5887586dae4d097e5a6f8e (diff)
downloadgnutls-7486c3c76604d71b8893e1c253b828fa9b9824b4.tar.gz
certtool: pkcs8_info_int: fix memory leak
-rw-r--r--src/certtool.c12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/certtool.c b/src/certtool.c
index cd947ff1a6..f818a5b904 100644
--- a/src/certtool.c
+++ b/src/certtool.c
@@ -3653,12 +3653,11 @@ void pkcs8_info_int(gnutls_datum_t *data, unsigned format,
if (ret == GNUTLS_E_UNKNOWN_CIPHER_TYPE) {
fprintf(out, "PKCS #8 information:\n");
fprintf(out, "\tSchema: unsupported (%s)\n", oid);
- gnutls_free(oid);
- return;
+ goto cleanup;
} else if (ret == GNUTLS_E_INVALID_REQUEST) {
fprintf(out, "PKCS #8 information:\n");
fprintf(out, "\tSchema: unencrypted key\n");
- return;
+ goto cleanup;
}
if (ret < 0) {
@@ -3668,16 +3667,16 @@ void pkcs8_info_int(gnutls_datum_t *data, unsigned format,
gnutls_strerror(ret));
exit(1);
}
- gnutls_free(oid);
fprintf(out, "%sPKCS #8 information:\n", tab);
fprintf(out, "%s\tCipher: %s\n", tab, gnutls_cipher_get_name(cipher));
str = gnutls_pkcs_schema_get_name(schema);
if (str != NULL) {
- fprintf(out, "%s\tSchema: %s (%s)\n", tab, str, gnutls_pkcs_schema_get_oid(schema));
+ fprintf(out, "%s\tSchema: %s (%s)\n", tab, str, gnutls_pkcs_schema_get_oid(schema));
}
+
bin.data = salt;
bin.size = salt_size;
ret = gnutls_hex_encode(&bin, hex, &hex_size);
@@ -3690,6 +3689,9 @@ void pkcs8_info_int(gnutls_datum_t *data, unsigned format,
fprintf(out, "%s\tSalt: %s\n", tab, hex);
fprintf(out, "%s\tSalt size: %u\n", tab, salt_size);
fprintf(out, "%s\tIteration count: %u\n\n", tab, iter_count);
+
+ cleanup:
+ gnutls_free(oid);
}
void pkcs8_info(void)