summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikos Mavrogiannopoulos <nmav@redhat.com>2018-05-15 16:35:32 +0200
committerNikos Mavrogiannopoulos <nmav@gnutls.org>2018-05-26 04:12:04 +0000
commit6965bf94038e66917f3ae449a0d397623dfc15d6 (patch)
treef8195ec573ebdcd6c88d2488236b7fbde0dd0412
parent0711893b2a5f9ed4f91d1a9a3d07519693bf428e (diff)
downloadgnutls-6965bf94038e66917f3ae449a0d397623dfc15d6.tar.gz
session_ticket: use random nonces
Avoid using any time values in plain as this could allow association of clients. Signed-off-by: Nikos Mavrogiannopoulos <nmav@redhat.com>
-rw-r--r--lib/ext/session_ticket.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/lib/ext/session_ticket.c b/lib/ext/session_ticket.c
index 2c91c9ec2d..40bbe5b112 100644
--- a/lib/ext/session_ticket.c
+++ b/lib/ext/session_ticket.c
@@ -278,7 +278,6 @@ _gnutls_encrypt_session_ticket(gnutls_session_t session,
gnutls_datum_t encrypted_state = {NULL,0};
uint8_t iv[IV_SIZE];
gnutls_datum_t mac_secret;
- uint32_t t;
struct ticket_st ticket;
int ret;
@@ -300,9 +299,7 @@ _gnutls_encrypt_session_ticket(gnutls_session_t session,
IV.data = iv;
IV.size = IV_SIZE;
- t = gnutls_time(0);
- memcpy(iv, &t, 4);
- ret = gnutls_rnd(GNUTLS_RND_NONCE, iv+4, IV_SIZE-4);
+ ret = gnutls_rnd(GNUTLS_RND_NONCE, iv, IV_SIZE);
if (ret < 0) {
gnutls_assert();
goto cleanup;